pjht/buku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Feature/fix request on test (#238)

Browse Source 
* chg: dev: fix request on test

* chg: test: ignore printed text

* chg: test: method to test print

* new: test: ignore instance attribute pylint error
This commit is contained in:
rachmadani haryono 2017-12-13 11:16:17 +08:00 committed by Arun Prakash Jana
parent 20fd90975e
commit 4facc4ba29
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/.pylintrc
View File

@ -29,6 +29,7 @@ disable=
too-many-arguments,
too-many-boolean-expressions,
too-many-branches,
too-many-instance-attributes,
too-many-lines,
too-many-locals,
too-many-nested-blocks,

18
tests/test_buku.py
View File

@ -1,6 +1,7 @@
"""test module."""
from itertools import product
from unittest import mock
import json
import os
import signal
import sys
@ -291,7 +292,6 @@ def test_browse(url, opened_url, platform):
m_webbrowser.open.assert_called_once_with(opened_url, new=2)
@unittest.skip('skipping')
@only_python_3_5
@pytest.mark.parametrize(
'status_code, latest_release',
@ -300,24 +300,22 @@ def test_browse(url, opened_url, platform):
def test_check_upstream_release(status_code, latest_release):
"""test func."""
resp = mock.Mock()
resp.status_code = status_code
with mock.patch('buku.requests') as m_requests, \
resp.status = status_code
m_manager = mock.Mock()
m_manager.request.return_value = resp
with mock.patch('buku.urllib3') as m_urllib3, \
mock.patch('buku.print') as m_print:
import buku
if latest_release:
latest_version = 'v{}'.format(buku.__version__)
else:
latest_version = 'v0'
resp.json.return_value = [{'tag_name': latest_version}]
m_requests.get.return_value = resp
m_urllib3.PoolManager.return_value = m_manager
resp.data.decode.return_value = json.dumps([{'tag_name': latest_version}])
buku.check_upstream_release()
if status_code != 200:
return
if latest_release:
print_text = 'This is the latest release'
else:
print_text = 'Latest upstream release is %s' % latest_version
m_print.assert_called_once_with(print_text)
len(m_print.mock_calls) == 1
@pytest.mark.parametrize(