7c65a9dc0e
144 Commits
Author | SHA1 | Message | Date | |
---|---|---|---|---|
David Tolnay
|
a9a6ee9d7f
|
Pull in proc-macro2 sccache fix | ||
David Tolnay
|
9cdf332029
|
Remove 'remember to update' reminder from Cargo.toml | ||
David Tolnay
|
ddc1ee564b
|
Release serde_derive_internals 0.29.0 | ||
David Tolnay
|
f969080b9f
|
Pull in syn fix that makes serde test suite independent of "full" feature
See https://github.com/dtolnay/syn/pull/1491. |
||
David Tolnay
|
74fe70855f
|
Ignore return_self_not_must_use pedantic clippy lint
warning: missing `#[must_use]` attribute on a method returning `Self` --> serde_derive_internals/src/attr.rs:204:5 | 204 | / pub fn or(self, other_rules: Self) -> Self { 205 | | Self { 206 | | serialize: self.serialize.or(other_rules.serialize), 207 | | deserialize: self.deserialize.or(other_rules.deserialize), 208 | | } 209 | | } | |_____^ | = help: consider adding the `#[must_use]` attribute to the method or directly to the `Self` type = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use = note: `-W clippy::return-self-not-must-use` implied by `-W clippy::pedantic` warning: missing `#[must_use]` attribute on a method returning `Self` --> serde_derive_internals/src/case.rs:112:5 | 112 | / pub fn or(self, rule_b: Self) -> Self { 113 | | match self { 114 | | None => rule_b, 115 | | _ => self, 116 | | } 117 | | } | |_____^ | = help: consider adding the `#[must_use]` attribute to the method or directly to the `Self` type = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use |
||
David Tolnay
|
30db83fc44
|
Restore bare_trait_objects lint within serde_derive code | ||
David Tolnay
|
0fb672a1ef
|
Eliminate #[macro_use] from serde_derive | ||
David Tolnay
|
166c89fabf
|
Opt in to generate-link-to-definition when building on docs.rs | ||
David Tolnay
|
07dcc4f7fe
|
Remove unneeded 'include' Cargo.toml entries | ||
David Tolnay
|
8264e002a7
|
Reject suffixed string literals inside serde attrs | ||
David Tolnay
|
296db177e2
|
Pull in syn fix for issue 2414 | ||
David Tolnay
|
992a01bad2
|
Sort dependency features in Cargo.toml | ||
David Tolnay
|
0289d31724
|
Fix -Zminimal-versions build | ||
David Tolnay
|
20a48c9580
|
Remove .clippy.toml in favor of respecting rust-version from Cargo.toml | ||
David Tolnay
|
1aebdc2760
|
Release serde_derive_internals 0.28.0 | ||
David Tolnay
|
acfd19cb46
|
Release serde_derive_internals 0.27.0 | ||
David Tolnay
|
c42e7c8012
|
Reflect serde_derive required compiler in build script and rust-version metadata | ||
David Tolnay
|
5b8e0657d4
|
Ignore single_match_else pedantic clippy lint in serde_derive_internals
error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> serde_derive_internals/src/attr.rs:1412:8 | 1412 | Ok(match string.parse() { | ________^ 1413 | | Ok(path) => Some(path), 1414 | | Err(_) => { 1415 | | cx.error_spanned_by( ... | 1420 | | } 1421 | | }) | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else = note: `-D clippy::single-match-else` implied by `-D clippy::pedantic` help: try this | 1412 ~ Ok(if let Ok(path) = string.parse() { Some(path) } else { 1413 + cx.error_spanned_by( 1414 + &string, 1415 + format!("failed to parse path: {:?}", string.value()), 1416 + ); 1417 + None 1418 ~ }) | error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> serde_derive_internals/src/attr.rs:1434:8 | 1434 | Ok(match string.parse() { | ________^ 1435 | | Ok(expr) => Some(expr), 1436 | | Err(_) => { 1437 | | cx.error_spanned_by( ... | 1442 | | } 1443 | | }) | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else help: try this | 1434 ~ Ok(if let Ok(expr) = string.parse() { Some(expr) } else { 1435 + cx.error_spanned_by( 1436 + &string, 1437 + format!("failed to parse path: {:?}", string.value()), 1438 + ); 1439 + None 1440 ~ }) | error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> serde_derive_internals/src/attr.rs:1478:8 | 1478 | Ok(match string.parse() { | ________^ 1479 | | Ok(ty) => Some(ty), 1480 | | Err(_) => { 1481 | | cx.error_spanned_by( ... | 1486 | | } 1487 | | }) | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else help: try this | 1478 ~ Ok(if let Ok(ty) = string.parse() { Some(ty) } else { 1479 + cx.error_spanned_by( 1480 + &string, 1481 + format!("failed to parse type: {} = {:?}", attr_name, string.value()), 1482 + ); 1483 + None 1484 ~ }) | |
||
David Tolnay
|
32f0d00ff9
|
Update to syn 2 | ||
David Tolnay
|
a13c6382b6
|
Ignore let_underscore_untyped pedantic clippy lint
error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:157:5 | 157 | / forward_to_deserialize_any! { 158 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 159 | | bytes byte_buf unit unit_struct newtype_struct seq tuple tuple_struct 160 | | map struct enum identifier ignored_any 161 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: `-D clippy::let-underscore-untyped` implied by `-D clippy::pedantic` = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:157:5 | 157 | / forward_to_deserialize_any! { 158 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 159 | | bytes byte_buf unit unit_struct newtype_struct seq tuple tuple_struct 160 | | map struct enum identifier ignored_any 161 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:219:5 | 219 | / forward_to_deserialize_any! { 220 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 221 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 222 | | tuple_struct map struct enum identifier ignored_any 223 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:291:1 | 291 | primitive_deserializer!(bool, "a `bool`.", BoolDeserializer, visit_bool); | ------------------------------------------------------------------------ in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:292:1 | 292 | primitive_deserializer!(i8, "an `i8`.", I8Deserializer, visit_i8); | ----------------------------------------------------------------- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:293:1 | 293 | primitive_deserializer!(i16, "an `i16`.", I16Deserializer, visit_i16); | --------------------------------------------------------------------- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:294:1 | 294 | primitive_deserializer!(i32, "an `i32`.", I32Deserializer, visit_i32); | --------------------------------------------------------------------- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:295:1 | 295 | primitive_deserializer!(i64, "an `i64`.", I64Deserializer, visit_i64); | --------------------------------------------------------------------- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:296:1 | 296 | primitive_deserializer!(isize, "an `isize`.", IsizeDeserializer, visit_i64 as i64); | ---------------------------------------------------------------------------------- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:297:1 | 297 | primitive_deserializer!(u8, "a `u8`.", U8Deserializer, visit_u8); | ---------------------------------------------------------------- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:298:1 | 298 | primitive_deserializer!(u16, "a `u16`.", U16Deserializer, visit_u16); | -------------------------------------------------------------------- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:299:1 | 299 | primitive_deserializer!(u64, "a `u64`.", U64Deserializer, visit_u64); | -------------------------------------------------------------------- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:300:1 | 300 | primitive_deserializer!(usize, "a `usize`.", UsizeDeserializer, visit_u64 as u64); | --------------------------------------------------------------------------------- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:301:1 | 301 | primitive_deserializer!(f32, "an `f32`.", F32Deserializer, visit_f32); | --------------------------------------------------------------------- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:302:1 | 302 | primitive_deserializer!(f64, "an `f64`.", F64Deserializer, visit_f64); | --------------------------------------------------------------------- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:303:1 | 303 | primitive_deserializer!(char, "a `char`.", CharDeserializer, visit_char); | ------------------------------------------------------------------------ in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:306:5 | 306 | primitive_deserializer!(i128, "an `i128`.", I128Deserializer, visit_i128); | ------------------------------------------------------------------------- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:307:5 | 307 | primitive_deserializer!(u128, "a `u128`.", U128Deserializer, visit_u128); | ------------------------------------------------------------------------ in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `primitive_deserializer` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:345:5 | 345 | / forward_to_deserialize_any! { 346 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 347 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 348 | | tuple_struct map struct identifier ignored_any 349 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/de/value.rs:367:9 | 367 | let _ = name; | ^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/value.rs:368:9 | 368 | let _ = variants; | ^^^^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/value.rs:450:9 | 450 | let _ = name; | ^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/value.rs:451:9 | 451 | let _ = variants; | ^^^^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:455:5 | 455 | / forward_to_deserialize_any! { 456 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 457 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 458 | | tuple_struct map struct identifier ignored_any 459 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/de/value.rs:529:9 | 529 | let _ = name; | ^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/value.rs:530:9 | 530 | let _ = variants; | ^^^^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:534:5 | 534 | / forward_to_deserialize_any! { 535 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 536 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 537 | | tuple_struct map struct identifier ignored_any 538 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/de/value.rs:630:9 | 630 | let _ = name; | ^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/value.rs:631:9 | 631 | let _ = variants; | ^^^^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:635:5 | 635 | / forward_to_deserialize_any! { 636 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 637 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 638 | | tuple_struct map struct identifier ignored_any 639 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/de/value.rs:736:9 | 736 | let _ = name; | ^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/value.rs:737:9 | 737 | let _ = variants; | ^^^^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:741:5 | 741 | / forward_to_deserialize_any! { 742 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 743 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 744 | | tuple_struct map struct identifier ignored_any 745 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:818:5 | 818 | / forward_to_deserialize_any! { 819 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 820 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 821 | | tuple_struct map struct enum identifier ignored_any 822 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:866:5 | 866 | / forward_to_deserialize_any! { 867 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 868 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 869 | | tuple_struct map struct enum identifier ignored_any 870 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:945:5 | 945 | / forward_to_deserialize_any! { 946 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 947 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 948 | | tuple_struct map struct enum identifier ignored_any 949 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:1073:5 | 1073 | / forward_to_deserialize_any! { 1074 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 1075 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 1076 | | tuple_struct map struct enum identifier ignored_any 1077 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/de/value.rs:1183:9 | 1183 | let _ = len; | ^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:1187:5 | 1187 | / forward_to_deserialize_any! { 1188 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 1189 | | bytes byte_buf option unit unit_struct newtype_struct tuple_struct map 1190 | | struct enum identifier ignored_any 1191 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:1326:5 | 1326 | / forward_to_deserialize_any! { 1327 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 1328 | | bytes byte_buf option unit unit_struct newtype_struct tuple_struct map 1329 | | struct enum identifier ignored_any 1330 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:1486:5 | 1486 | / forward_to_deserialize_any! { 1487 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 1488 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 1489 | | tuple_struct map struct identifier ignored_any 1490 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/de/value.rs:1539:5 | 1539 | / forward_to_deserialize_any! { 1540 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 1541 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 1542 | | tuple_struct map struct enum identifier ignored_any 1543 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/de/ignored_any.rs:123:9 | 123 | let _ = x; | ^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/ignored_any.rs:129:9 | 129 | let _ = x; | ^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/ignored_any.rs:136:13 | 136 | let _ = x; | ^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/ignored_any.rs:143:9 | 143 | let _ = x; | ^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/ignored_any.rs:150:13 | 150 | let _ = x; | ^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/ignored_any.rs:157:9 | 157 | let _ = x; | ^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/ignored_any.rs:166:9 | 166 | let _ = s; | ^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/ignored_any.rs:223:9 | 223 | let _ = bytes; | ^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/mod.rs:957:13 | 957 | let _ = visitor; | ^^^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/mod.rs:991:13 | 991 | let _ = visitor; | ^^^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/mod.rs:1554:9 | 1554 | let _ = v; | ^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/mod.rs:1615:9 | 1615 | let _ = deserializer; | ^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/mod.rs:1639:9 | 1639 | let _ = deserializer; | ^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/mod.rs:1650:9 | 1650 | let _ = seq; | ^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/mod.rs:1661:9 | 1661 | let _ = map; | ^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/de/mod.rs:1672:9 | 1672 | let _ = data; | ^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/impossible.rs:79:9 | 79 | let _ = value; | ^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/impossible.rs:99:9 | 99 | let _ = value; | ^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/impossible.rs:119:9 | 119 | let _ = value; | ^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/impossible.rs:139:9 | 139 | let _ = value; | ^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/impossible.rs:159:9 | 159 | let _ = key; | ^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/impossible.rs:167:9 | 167 | let _ = value; | ^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/impossible.rs:187:9 | 187 | let _ = key; | ^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/impossible.rs:188:9 | 188 | let _ = value; | ^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/impossible.rs:208:9 | 208 | let _ = key; | ^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/impossible.rs:209:9 | 209 | let _ = value; | ^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/mod.rs:512:13 | 512 | let _ = v; | ^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/mod.rs:622:13 | 622 | let _ = v; | ^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/mod.rs:1906:9 | 1906 | let _ = key; | ^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/ser/mod.rs:1972:9 | 1972 | let _ = key; | ^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/private/de.rs:47:9 | 47 | / forward_to_deserialize_any! { 48 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 49 | | bytes byte_buf unit unit_struct newtype_struct seq tuple 50 | | tuple_struct map struct enum identifier ignored_any 51 | | } | |_________- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/private/de.rs:1451:13 | 1451 | let _ = visitor; | ^^^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/private/de.rs:1633:9 | 1633 | / forward_to_deserialize_any! { 1634 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 1635 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 1636 | | tuple_struct map struct enum identifier ignored_any 1637 | | } | |_________- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/private/de.rs:1731:9 | 1731 | / forward_to_deserialize_any! { 1732 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 1733 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 1734 | | tuple_struct map struct enum identifier ignored_any 1735 | | } | |_________- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/private/de.rs:2174:13 | 2174 | let _ = visitor; | ^^^^^^^^^^^^^^^^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/private/de.rs:2343:9 | 2343 | / forward_to_deserialize_any! { 2344 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 2345 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 2346 | | tuple_struct map struct enum identifier ignored_any 2347 | | } | |_________- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/private/de.rs:2443:9 | 2443 | / forward_to_deserialize_any! { 2444 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 2445 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 2446 | | tuple_struct map struct enum identifier ignored_any 2447 | | } | |_________- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/private/de.rs:2611:5 | 2611 | / forward_to_deserialize_any! { 2612 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 2613 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 2614 | | tuple_struct map struct enum identifier ignored_any 2615 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde/src/macros.rs:132:17 | 132 | let _ = $arg; | ^^^^^^^^^^^^^ | ::: serde/src/private/de.rs:2636:5 | 2636 | / forward_to_deserialize_any! { 2637 | | bool i8 i16 i32 i64 i128 u8 u16 u32 u64 u128 f32 f64 char str string 2638 | | bytes byte_buf option unit unit_struct newtype_struct seq tuple 2639 | | tuple_struct map struct enum identifier ignored_any 2640 | | } | |_____- in this macro invocation | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: this error originates in the macro `forward_to_deserialize_any_method` which comes from the expansion of the macro `forward_to_deserialize_any` (in Nightly builds, run with -Z macro-backtrace for more info) error: non-binding `let` without a type annotation --> serde_derive/src/internals/attr.rs:591:17 | 591 | / let _ = attr.parse_args_with(|input: ParseStream| { 592 | | while let Some(token) = input.parse()? { 593 | | if let TokenTree::Ident(ident) = token { 594 | | is_packed |= ident == "packed"; ... | 597 | | Ok(()) 598 | | }); | |___________________^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: `-D clippy::let-underscore-untyped` implied by `-D clippy::pedantic` error: non-binding `let` without a type annotation --> serde_derive_internals/src/attr.rs:591:17 | 591 | / let _ = attr.parse_args_with(|input: ParseStream| { 592 | | while let Some(token) = input.parse()? { 593 | | if let TokenTree::Ident(ident) = token { 594 | | is_packed |= ident == "packed"; ... | 597 | | Ok(()) 598 | | }); | |___________________^ | = help: consider adding a type annotation or removing the `let` keyword = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped = note: `-D clippy::let-underscore-untyped` implied by `-D clippy::pedantic` |
||
David Tolnay
|
4f157a8b81
|
Prevent build.rs rerunning unnecessarily on all source changes | ||
David Tolnay
|
50354c2d0b
|
Improve error message on remote derive duplicate generics | ||
David Tolnay
|
e19844c659
|
Fix renamed let_underscore_drop lint
warning: lint `clippy::let_underscore_drop` has been renamed to `let_underscore_drop` --> serde_derive/src/lib.rs:46:5 | 46 | clippy::let_underscore_drop, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `let_underscore_drop` | = note: `#[warn(renamed_and_removed_lints)]` on by default |
||
David Tolnay
|
a925ce4119
|
Sort package entries in Cargo.toml | ||
David Tolnay
|
2e38e2bf2f
|
Ignore derive_partial_eq_without_eq clippy lint
error: you are deriving `PartialEq` and can implement `Eq` --> serde/src/de/value.rs:51:17 | 51 | #[derive(Clone, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = note: `-D clippy::derive-partial-eq-without-eq` implied by `-D clippy::all` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> serde_derive/src/internals/case.rs:13:23 | 13 | #[derive(Copy, Clone, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/unstable/mod.rs:6:21 | 6 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_ignored_any.rs:7:10 | 7 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_identifier.rs:7:34 | 7 | #[derive(Deserialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_identifier.rs:24:34 | 24 | #[derive(Deserialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_identifier.rs:41:34 | 41 | #[derive(Deserialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_identifier.rs:59:34 | 59 | #[derive(Deserialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_ser.rs:46:10 | 46 | #[derive(PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_value.rs:11:34 | 11 | #[derive(Deserialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de_error.rs:15:23 | 15 | #[derive(Copy, Clone, PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de_error.rs:18:10 | 18 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de_error.rs:26:10 | 26 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de_error.rs:34:10 | 34 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de_error.rs:41:19 | 41 | #[derive(Default, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de_error.rs:60:10 | 60 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_borrow.rs:70:34 | 70 | #[derive(Deserialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_borrow.rs:97:34 | 97 | #[derive(Deserialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_borrow.rs:106:34 | 106 | #[derive(Deserialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de.rs:43:23 | 43 | #[derive(Copy, Clone, PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de.rs:46:10 | 46 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de.rs:49:10 | 49 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de.rs:52:10 | 52 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de.rs:76:10 | 76 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de.rs:82:10 | 82 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de.rs:102:10 | 102 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de.rs:109:19 | 109 | #[derive(Default, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de.rs:128:10 | 128 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de.rs:135:10 | 135 | #[derive(PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_de.rs:185:14 | 185 | #[derive(PartialEq, Debug, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:25:17 | 25 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:110:17 | 110 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:580:21 | 580 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:607:21 | 607 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:681:21 | 681 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:684:21 | 684 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:816:21 | 816 | #[derive(Debug, PartialEq, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:976:21 | 976 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1027:21 | 1027 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1273:21 | 1273 | #[derive(Debug, PartialEq, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1342:21 | 1342 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1413:21 | 1413 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1450:21 | 1450 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1474:21 | 1474 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1509:21 | 1509 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1543:21 | 1543 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1601:21 | 1601 | #[derive(Debug, PartialEq, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1743:45 | 1743 | #[derive(Serialize, Deserialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1763:45 | 1763 | #[derive(Serialize, Deserialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1770:45 | 1770 | #[derive(Serialize, Deserialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1870:21 | 1870 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_macros.rs:1888:21 | 1888 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:108:17 | 108 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:124:17 | 124 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:147:17 | 147 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:344:17 | 344 | #[derive(Debug, PartialEq, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:394:17 | 394 | #[derive(Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:413:17 | 413 | #[derive(Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:458:17 | 458 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:512:17 | 512 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:520:17 | 520 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:528:17 | 528 | #[derive(Debug, PartialEq, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:647:17 | 647 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_gen.rs:835:17 | 835 | #[derive(Debug, PartialEq, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:675:17 | 675 | #[derive(Debug, PartialEq, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:1047:17 | 1047 | #[derive(Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:1050:17 | 1050 | #[derive(Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:1196:17 | 1196 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:1514:17 | 1514 | #[derive(Debug, PartialEq, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:1548:41 | 1548 | #[derive(Clone, Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:1566:41 | 1566 | #[derive(Clone, Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:1600:30 | 1600 | #[derive(Clone, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:1803:21 | 1803 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:1843:21 | 1843 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:1852:21 | 1852 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:1947:21 | 1947 | #[derive(Debug, PartialEq, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2003:21 | 2003 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2037:21 | 2037 | #[derive(Debug, PartialEq, Serialize, Deserialize)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2074:45 | 2074 | #[derive(Deserialize, Serialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2080:45 | 2080 | #[derive(Deserialize, Serialize, Debug, PartialEq)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2157:38 | 2157 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2193:38 | 2193 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2200:38 | 2200 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2240:38 | 2240 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2279:38 | 2279 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2316:38 | 2316 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2359:38 | 2359 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2390:38 | 2390 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2421:38 | 2421 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2426:38 | 2426 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2483:38 | 2483 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2507:38 | 2507 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2521:27 | 2521 | #[derive(Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2552:27 | 2552 | #[derive(Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2558:27 | 2558 | #[derive(Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2586:14 | 2586 | #[derive(PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2624:27 | 2624 | #[derive(Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq error: you are deriving `PartialEq` and can implement `Eq` --> test_suite/tests/test_annotations.rs:2647:27 | 2647 | #[derive(Deserialize, PartialEq, Debug)] | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq |
||
David Tolnay
|
52391fd868
|
Inform clippy of supported compiler version in clippy.toml | ||
David Tolnay
|
b23a768414
|
Update exhaustive matching to syn 1.0.90 | ||
David Tolnay
|
8f16ac0a94
|
Move deny(clippy) to command line arguments in the CI job | ||
David Tolnay
|
4a97386cb9
|
Clippy if_then_panic lint has been renamed to manual_assert | ||
David Tolnay
|
01ded9f405
|
Declare minimum Rust version in Cargo metadata | ||
David Tolnay
|
5c785eee58
|
Ignore if_then_panic clippy lint
error: only a `panic!` in `if`-then statement --> serde_derive/src/internals/ctxt.rs:58:9 | 58 | / if !thread::panicking() && self.errors.borrow().is_some() { 59 | | panic!("forgot to check for errors"); 60 | | } | |_________^ help: try: `assert!(!!thread::panicking() && self.errors.borrow().is_some(), "forgot to check for errors");` | note: the lint level is defined here --> serde_derive/src/lib.rs:18:9 | 18 | #![deny(clippy::all, clippy::pedantic)] | ^^^^^^^^^^^ = note: `#[deny(clippy::if_then_panic)]` implied by `#[deny(clippy::all)]` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_then_panic error: only a `panic!` in `if`-then statement --> serde_test/src/assert.rs:73:5 | 73 | / if ser.remaining() > 0 { 74 | | panic!("{} remaining tokens", ser.remaining()); 75 | | } | |_____^ help: try: `assert!(!ser.remaining() > 0, "{} remaining tokens", ser.remaining());` | note: the lint level is defined here --> serde_test/src/lib.rs:149:44 | 149 | #![cfg_attr(feature = "cargo-clippy", deny(clippy, clippy_pedantic))] | ^^^^^^ = note: `#[deny(clippy::if_then_panic)]` implied by `#[deny(clippy::all)]` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_then_panic error: only a `panic!` in `if`-then statement --> serde_test/src/assert.rs:126:5 | 126 | / if ser.remaining() > 0 { 127 | | panic!("{} remaining tokens", ser.remaining()); 128 | | } | |_____^ help: try: `assert!(!ser.remaining() > 0, "{} remaining tokens", ser.remaining());` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_then_panic error: only a `panic!` in `if`-then statement --> serde_test/src/assert.rs:166:5 | 166 | / if de.remaining() > 0 { 167 | | panic!("{} remaining tokens", de.remaining()); 168 | | } | |_____^ help: try: `assert!(!de.remaining() > 0, "{} remaining tokens", de.remaining());` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_then_panic error: only a `panic!` in `if`-then statement --> serde_test/src/assert.rs:180:5 | 180 | / if de.remaining() > 0 { 181 | | panic!("{} remaining tokens", de.remaining()); 182 | | } | |_____^ help: try: `assert!(!de.remaining() > 0, "{} remaining tokens", de.remaining());` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_then_panic error: only a `panic!` in `if`-then statement --> serde_test/src/assert.rs:220:5 | 220 | / if de.remaining() > 0 { 221 | | panic!("{} remaining tokens", de.remaining()); 222 | | } | |_____^ help: try: `assert!(!de.remaining() > 0, "{} remaining tokens", de.remaining());` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_then_panic error: only a `panic!` in `if`-then statement --> test_suite/tests/test_de.rs:1349:9 | 1349 | / if de.remaining() > 0 { 1350 | | panic!("{} remaining tokens", de.remaining()); 1351 | | } | |_________^ help: try: `assert!(!de.remaining() > 0, "{} remaining tokens", de.remaining());` | = note: `-D clippy::if-then-panic` implied by `-D clippy::all` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_then_panic |
||
David Tolnay
|
f309485787
|
Ignore buggy collapsible_match clippy lint
https://github.com/rust-lang/rust-clippy/issues/7575 |
||
David Tolnay
|
7aa4950504
|
Release serde_derive_internals 0.26.0 | ||
David Tolnay
|
dc4c31eb50
|
Build using relative path in repo if Windows lost symlink | ||
David Tolnay
|
ce0844b9ec
|
Suppress match_wildcard_for_single_variants clippy false positive
https://github.com/rust-lang/rust-clippy/issues/6984 error: wildcard matches only a single variant and will also match any future added variants --> serde_derive/src/internals/attr.rs:1918:9 | 1918 | _ => {} | ^ help: try this: `syn::Type::__TestExhaustive(_)` | note: the lint level is defined here --> serde_derive/src/lib.rs:18:22 | 18 | #![deny(clippy::all, clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[deny(clippy::match_wildcard_for_single_variants)]` implied by `#[deny(clippy::pedantic)]` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants error: wildcard matches only a single variant and will also match any future added variants --> serde_derive/src/internals/receiver.rs:153:13 | 153 | _ => {} | ^ help: try this: `Type::__TestExhaustive(_)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants error: wildcard matches only a single variant and will also match any future added variants --> serde_derive/src/bound.rs:190:17 | 190 | _ => {} | ^ help: try this: `syn::Type::__TestExhaustive(_)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants |
||
David Tolnay
|
c261015325
|
Ignore incorrect suggestion from manual_map lint
https://github.com/rust-lang/rust-clippy/issues/6797 error[E0382]: use of partially moved value: `self` --> serde_derive/src/internals/attr.rs:71:24 | 71 | self.value.map(|value| (self.tokens, value)) | ----^^^^^^^---------------------- | | | | | | | use occurs due to use in closure | | value used here after partial move | `self.value` partially moved due to this method call | note: this function takes ownership of the receiver `self`, which moves `self.value` --> /home/david/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/option.rs:485:38 | 485 | pub fn map<U, F: FnOnce(T) -> U>(self, f: F) -> Option<U> { | ^^^^ = note: partial move occurs because `self.value` has type `std::option::Option<T>`, which does not implement the `Copy` trait |
||
David Tolnay
|
6b5e5a83d0
|
Ignore let_underscore_drop pedantic clippy lint | ||
David Tolnay
|
beb21cb640
|
Ignore new missing_panics_doc pedantic clippy lint | ||
David Tolnay
|
b054ea4105
|
Ignore some pedantic lints in serde_derive_internals from PR 1830
error: item name ends with its containing module's name --> serde_derive_internals/src/receiver.rs:11:1 | 11 | / pub fn replace_receiver(input: &mut DeriveInput) { 12 | | let self_ty = { 13 | | let ident = &input.ident; 14 | | let ty_generics = input.generics.split_for_impl().1; ... | 19 | | visitor.visit_data_mut(&mut input.data); 20 | | } | |_^ | note: the lint level is defined here --> serde_derive_internals/lib.rs:3:22 | 3 | #![deny(clippy::all, clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[deny(clippy::module_name_repetitions)]` implied by `#[deny(clippy::pedantic)]` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions error: binding's name is too similar to existing binding --> serde_derive_internals/src/receiver.rs:31:29 | 31 | fn self_to_qself(&self, qself: &mut Option<QSelf>, path: &mut Path) { | ^^^^^ | note: the lint level is defined here --> serde_derive_internals/lib.rs:3:22 | 3 | #![deny(clippy::all, clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[deny(clippy::similar_names)]` implied by `#[deny(clippy::pedantic)]` note: existing binding defined here --> serde_derive_internals/src/receiver.rs:31:23 | 31 | fn self_to_qself(&self, qself: &mut Option<QSelf>, path: &mut Path) { | ^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names error: unused `self` argument --> serde_derive_internals/src/receiver.rs:286:24 | 286 | fn visit_macro_mut(&mut self, _mac: &mut Macro) {} | ^^^^^^^^^ | note: the lint level is defined here --> serde_derive_internals/lib.rs:3:22 | 3 | #![deny(clippy::all, clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[deny(clippy::unused_self)]` implied by `#[deny(clippy::pedantic)]` = help: consider refactoring to a associated function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_self |
||
David Tolnay
|
e5efb6ad93
|
Remove dependency on syn/visit-mut feature | ||
David Tolnay
|
6c5bf701be
|
Merge pull request 1830 from taiki-e/self | ||
David Tolnay
|
ff0f467e25
|
Opt in to pedantic clippy lints in serde_derive_internals | ||
David Tolnay
|
d1975f3661
|
Update serde_derive_internals to tool attrs | ||
David Tolnay
|
b91713e824
|
Suppress clippy should_implement_trait lint
I think there is no ambiguity in from_str as a method name so "choose a less ambiguous method name" is unnecessary, and it can't be a FromStr impl in this case because FromStr's error type cannot borrow from the input string slice. warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` --> serde_derive_internals/src/case.rs:50:5 | 50 | / pub fn from_str(rename_all_str: &str) -> Result<Self, ParseError> { 51 | | for (name, rule) in RENAME_RULES { 52 | | if rename_all_str == *name { 53 | | return Ok(*rule); ... | 58 | | }) 59 | | } | |_____^ | = note: `#[warn(clippy::should_implement_trait)]` on by default = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait |
||
David Tolnay
|
85c6904a93
|
Remove dependency on syn/visit feature
The builtin visitor is fairly expensive to compile (3700 lines of code), particularly if something else in the dependency graph also enables syn/full. For the usage in serde_derive, it turns out to be easy to replace. |
||
Taiki Endo
|
c67017d466 | Fix handling of Self keyword in type definition | ||
David Tolnay
|
0e1c4093c8
|
Suppress new result_unit_err clippy lint | ||
David Tolnay
|
a9f8ea0a1e
|
Simplify search for packed repr attr | ||
David Tolnay
|
95b1a5d3d9
|
Ignore unnested_or_patterns suggesting unstable code
Clippy bug: https://github.com/rust-lang/rust-clippy/issues/5704 |
||
David Tolnay
|
0856a2c101
|
No need to specify Cargo.toml in package.include
Cargo.toml is always included in the published crate. |