Add serde default attribute for fields
When annotated with #[serde(default)], a field gets a default value using std:default::Default, and will not error when decoding if the field is missing from the input. Addresses #9 Refactor default_value to use if-let
This commit is contained in:
parent
5c4327cd16
commit
bb1a9b2389
@ -6,9 +6,12 @@ extern crate rustc;
|
|||||||
use syntax::ast::{
|
use syntax::ast::{
|
||||||
Ident,
|
Ident,
|
||||||
MetaItem,
|
MetaItem,
|
||||||
|
MetaItem_,
|
||||||
Item,
|
Item,
|
||||||
Expr,
|
Expr,
|
||||||
MutMutable,
|
MutMutable,
|
||||||
|
StructDef,
|
||||||
|
EnumDef,
|
||||||
};
|
};
|
||||||
use syntax::ast;
|
use syntax::ast;
|
||||||
use syntax::ast_util;
|
use syntax::ast_util;
|
||||||
@ -607,7 +610,7 @@ fn deserialize_substructure(cx: &ExtCtxt, span: Span, substr: &Substructure) ->
|
|||||||
let state = substr.nonself_args[0].clone();
|
let state = substr.nonself_args[0].clone();
|
||||||
|
|
||||||
match *substr.fields {
|
match *substr.fields {
|
||||||
StaticStruct(_, ref fields) => {
|
StaticStruct(ref struct_def, ref fields) => {
|
||||||
deserialize_struct(
|
deserialize_struct(
|
||||||
cx,
|
cx,
|
||||||
span,
|
span,
|
||||||
@ -615,15 +618,17 @@ fn deserialize_substructure(cx: &ExtCtxt, span: Span, substr: &Substructure) ->
|
|||||||
substr.type_ident,
|
substr.type_ident,
|
||||||
cx.path(span, vec![substr.type_ident]),
|
cx.path(span, vec![substr.type_ident]),
|
||||||
fields,
|
fields,
|
||||||
state)
|
state,
|
||||||
|
struct_def)
|
||||||
}
|
}
|
||||||
StaticEnum(_, ref fields) => {
|
StaticEnum(ref enum_def, ref fields) => {
|
||||||
deserialize_enum(
|
deserialize_enum(
|
||||||
cx,
|
cx,
|
||||||
span,
|
span,
|
||||||
substr.type_ident,
|
substr.type_ident,
|
||||||
&fields,
|
&fields,
|
||||||
state)
|
state,
|
||||||
|
enum_def)
|
||||||
}
|
}
|
||||||
_ => cx.bug("expected StaticEnum or StaticStruct in derive(Deserialize)")
|
_ => cx.bug("expected StaticEnum or StaticStruct in derive(Deserialize)")
|
||||||
}
|
}
|
||||||
@ -637,6 +642,7 @@ fn deserialize_struct(
|
|||||||
struct_path: ast::Path,
|
struct_path: ast::Path,
|
||||||
fields: &StaticFields,
|
fields: &StaticFields,
|
||||||
state: P<ast::Expr>,
|
state: P<ast::Expr>,
|
||||||
|
struct_def: &StructDef
|
||||||
) -> P<ast::Expr> {
|
) -> P<ast::Expr> {
|
||||||
match *fields {
|
match *fields {
|
||||||
Unnamed(ref fields) => {
|
Unnamed(ref fields) => {
|
||||||
@ -644,16 +650,16 @@ fn deserialize_struct(
|
|||||||
deserialize_struct_empty_fields(
|
deserialize_struct_empty_fields(
|
||||||
cx,
|
cx,
|
||||||
span,
|
span,
|
||||||
type_ident,
|
type_ident,
|
||||||
struct_ident,
|
struct_ident,
|
||||||
struct_path,
|
struct_path,
|
||||||
state)
|
state)
|
||||||
} else {
|
} else {
|
||||||
deserialize_struct_unnamed_fields(
|
deserialize_struct_unnamed_fields(
|
||||||
cx,
|
cx,
|
||||||
span,
|
span,
|
||||||
type_ident,
|
type_ident,
|
||||||
struct_ident,
|
struct_ident,
|
||||||
struct_path,
|
struct_path,
|
||||||
&fields[],
|
&fields[],
|
||||||
state)
|
state)
|
||||||
@ -663,11 +669,12 @@ fn deserialize_struct(
|
|||||||
deserialize_struct_named_fields(
|
deserialize_struct_named_fields(
|
||||||
cx,
|
cx,
|
||||||
span,
|
span,
|
||||||
type_ident,
|
type_ident,
|
||||||
struct_ident,
|
struct_ident,
|
||||||
struct_path,
|
struct_path,
|
||||||
&fields[],
|
&fields[],
|
||||||
state)
|
state,
|
||||||
|
struct_def)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@ -803,6 +810,7 @@ fn deserialize_struct_named_fields(
|
|||||||
struct_path: ast::Path,
|
struct_path: ast::Path,
|
||||||
fields: &[(Ident, Span)],
|
fields: &[(Ident, Span)],
|
||||||
state: P<ast::Expr>,
|
state: P<ast::Expr>,
|
||||||
|
struct_def: &StructDef,
|
||||||
) -> P<ast::Expr> {
|
) -> P<ast::Expr> {
|
||||||
let struct_name = cx.expr_str(span, token::get_ident(struct_ident));
|
let struct_name = cx.expr_str(span, token::get_ident(struct_ident));
|
||||||
|
|
||||||
@ -824,6 +832,7 @@ fn deserialize_struct_named_fields(
|
|||||||
struct_path,
|
struct_path,
|
||||||
&field_names[],
|
&field_names[],
|
||||||
fields,
|
fields,
|
||||||
|
struct_def
|
||||||
);
|
);
|
||||||
|
|
||||||
quote_expr!(cx, {
|
quote_expr!(cx, {
|
||||||
@ -931,18 +940,49 @@ fn declare_map_field_deserializer(
|
|||||||
]
|
]
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
fn default_value(field: &ast::StructField) -> bool {
|
||||||
|
field.node.attrs.iter()
|
||||||
|
.any(|sa|
|
||||||
|
if let MetaItem_::MetaList(ref n, ref vals) = sa.node.value.node {
|
||||||
|
if n == &"serde" {
|
||||||
|
vals.iter()
|
||||||
|
.map(|mi|
|
||||||
|
if let MetaItem_::MetaWord(ref n) = mi.node {
|
||||||
|
n == &"default"
|
||||||
|
} else {
|
||||||
|
false
|
||||||
|
})
|
||||||
|
.any(|x| x)
|
||||||
|
} else {
|
||||||
|
false
|
||||||
|
}
|
||||||
|
}
|
||||||
|
else {
|
||||||
|
false
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
fn declare_visit_map(
|
fn declare_visit_map(
|
||||||
cx: &ExtCtxt,
|
cx: &ExtCtxt,
|
||||||
span: Span,
|
span: Span,
|
||||||
struct_path: ast::Path,
|
struct_path: ast::Path,
|
||||||
field_names: &[Ident],
|
field_names: &[Ident],
|
||||||
fields: &[(Ident, Span)],
|
fields: &[(Ident, Span)],
|
||||||
|
struct_def: &StructDef,
|
||||||
) -> P<ast::Expr> {
|
) -> P<ast::Expr> {
|
||||||
|
|
||||||
// Declare each field.
|
// Declare each field.
|
||||||
let let_values: Vec<P<ast::Stmt>> = field_names.iter()
|
let let_values: Vec<P<ast::Stmt>> = field_names.iter()
|
||||||
.map(|field| {
|
.zip(struct_def.fields.iter())
|
||||||
quote_stmt!(cx, let mut $field = None;)
|
.map(|(field, sf)| {
|
||||||
|
if default_value(sf) {
|
||||||
|
quote_stmt!(
|
||||||
|
cx,
|
||||||
|
let mut $field = Some(::std::default::Default::default());)
|
||||||
|
} else {
|
||||||
|
quote_stmt!(cx, let mut $field = None;)
|
||||||
|
}
|
||||||
})
|
})
|
||||||
.collect();
|
.collect();
|
||||||
|
|
||||||
@ -1001,12 +1041,14 @@ fn deserialize_enum(
|
|||||||
type_ident: Ident,
|
type_ident: Ident,
|
||||||
fields: &[(Ident, Span, StaticFields)],
|
fields: &[(Ident, Span, StaticFields)],
|
||||||
state: P<ast::Expr>,
|
state: P<ast::Expr>,
|
||||||
|
enum_def: &EnumDef,
|
||||||
) -> P<ast::Expr> {
|
) -> P<ast::Expr> {
|
||||||
let type_name = cx.expr_str(span, token::get_ident(type_ident));
|
let type_name = cx.expr_str(span, token::get_ident(type_ident));
|
||||||
|
|
||||||
// Match arms to extract a variant from a string
|
// Match arms to extract a variant from a string
|
||||||
let variant_arms: Vec<ast::Arm> = fields.iter()
|
let variant_arms: Vec<ast::Arm> = fields.iter()
|
||||||
.map(|&(name, span, ref fields)| {
|
.zip(enum_def.variants.iter())
|
||||||
|
.map(|(&(name, span, ref fields), variant_ptr)| {
|
||||||
let value = deserialize_enum_variant(
|
let value = deserialize_enum_variant(
|
||||||
cx,
|
cx,
|
||||||
span,
|
span,
|
||||||
@ -1014,6 +1056,7 @@ fn deserialize_enum(
|
|||||||
name,
|
name,
|
||||||
fields,
|
fields,
|
||||||
cx.expr_ident(span, cx.ident_of("visitor")),
|
cx.expr_ident(span, cx.ident_of("visitor")),
|
||||||
|
variant_ptr,
|
||||||
);
|
);
|
||||||
|
|
||||||
let s = cx.expr_str(span, token::get_ident(name));
|
let s = cx.expr_str(span, token::get_ident(name));
|
||||||
@ -1058,6 +1101,7 @@ fn deserialize_enum_variant(
|
|||||||
variant_ident: Ident,
|
variant_ident: Ident,
|
||||||
fields: &StaticFields,
|
fields: &StaticFields,
|
||||||
state: P<ast::Expr>,
|
state: P<ast::Expr>,
|
||||||
|
variant_ptr: &P<ast::Variant>,
|
||||||
) -> P<ast::Expr> {
|
) -> P<ast::Expr> {
|
||||||
let variant_path = cx.path(span, vec![type_ident, variant_ident]);
|
let variant_path = cx.path(span, vec![type_ident, variant_ident]);
|
||||||
|
|
||||||
@ -1119,6 +1163,10 @@ fn deserialize_enum_variant(
|
|||||||
variant_path,
|
variant_path,
|
||||||
&field_names[],
|
&field_names[],
|
||||||
fields,
|
fields,
|
||||||
|
match variant_ptr.node.kind {
|
||||||
|
ast::VariantKind::StructVariantKind(ref sd) => &*sd,
|
||||||
|
_ => panic!("Mismatched enum types")
|
||||||
|
},
|
||||||
);
|
);
|
||||||
|
|
||||||
quote_expr!(cx, {
|
quote_expr!(cx, {
|
||||||
|
Loading…
Reference in New Issue
Block a user