mikros/serde
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Produce error about mismatched types of #[serde(with = "...")] and #[serde(default = "...")] attributes on the attribute itself

Browse Source
This commit is contained in:
Mingun 2023-07-22 19:44:59 +05:00 committed by Mingun
parent 291ec50d98
commit 74b538b8ec
3 changed files with 59 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
serde_derive/src/de.rs
View File

@ -371,7 +371,11 @@ fn deserialize_transparent(cont: &Container, params: &Parameters) -> Fragment {
} else { } else {
let value = match field.attrs.default() { let value = match field.attrs.default() {
attr::Default::Default => quote!(_serde::__private::Default::default()), attr::Default::Default => quote!(_serde::__private::Default::default()),
attr::Default::Path(path) => quote!(#path()), // If #path returns wrong type, error will be reported here (^^^^^).
// We attach span of the path to the function so it will be reported
// on the #[serde(default = "...")]
// ^^^^^
attr::Default::Path(path) => quote_spanned!(path.span()=> #path()),
attr::Default::None => quote!(_serde::__private::PhantomData), attr::Default::None => quote!(_serde::__private::PhantomData),
}; };
quote!(#member: #value) quote!(#member: #value)
@ -751,7 +755,11 @@ fn deserialize_seq(
attr::Default::Default => Some(quote!( attr::Default::Default => Some(quote!(
let __default: Self::Value = _serde::__private::Default::default(); let __default: Self::Value = _serde::__private::Default::default();
)), )),
attr::Default::Path(path) => Some(quote!( // If #path returns wrong type, error will be reported here (^^^^^).
// We attach span of the path to the function so it will be reported
// on the #[serde(default = "...")]
// ^^^^^
attr::Default::Path(path) => Some(quote_spanned!(path.span()=>
let __default: Self::Value = #path(); let __default: Self::Value = #path();
)), )),
attr::Default::None => { attr::Default::None => {
@ -833,7 +841,11 @@ fn deserialize_seq_in_place(
attr::Default::Default => Some(quote!( attr::Default::Default => Some(quote!(
let __default: #this_type #ty_generics = _serde::__private::Default::default(); let __default: #this_type #ty_generics = _serde::__private::Default::default();
)), )),
attr::Default::Path(path) => Some(quote!( // If #path returns wrong type, error will be reported here (^^^^^).
// We attach span of the path to the function so it will be reported
// on the #[serde(default = "...")]
// ^^^^^
attr::Default::Path(path) => Some(quote_spanned!(path.span()=>
let __default: #this_type #ty_generics = #path(); let __default: #this_type #ty_generics = #path();
)), )),
attr::Default::None => { attr::Default::None => {
@ -867,7 +879,11 @@ fn deserialize_newtype_struct(
} }
} }
Some(path) => { Some(path) => {
quote! { // If #path returns wrong type, error will be reported here (^^^^^).
// We attach span of the path to the function so it will be reported
// on the #[serde(with = "...")]
// ^^^^^
quote_spanned! {path.span()=>
#path(__e)? #path(__e)?
} }
} }
@ -2634,7 +2650,11 @@ fn deserialize_map(
attr::Default::Default => Some(quote!( attr::Default::Default => Some(quote!(
let __default: Self::Value = _serde::__private::Default::default(); let __default: Self::Value = _serde::__private::Default::default();
)), )),
attr::Default::Path(path) => Some(quote!( // If #path returns wrong type, error will be reported here (^^^^^).
// We attach span of the path to the function so it will be reported
// on the #[serde(default = "...")]
// ^^^^^
attr::Default::Path(path) => Some(quote_spanned!(path.span()=>
let __default: Self::Value = #path(); let __default: Self::Value = #path();
)), )),
attr::Default::None => { attr::Default::None => {
@ -2801,7 +2821,11 @@ fn deserialize_map_in_place(
attr::Default::Default => Some(quote!( attr::Default::Default => Some(quote!(
let __default: #this_type #ty_generics = _serde::__private::Default::default(); let __default: #this_type #ty_generics = _serde::__private::Default::default();
)), )),
attr::Default::Path(path) => Some(quote!( // If #path returns wrong type, error will be reported here (^^^^^).
// We attach span of the path to the function so it will be reported
// on the #[serde(default = "...")]
// ^^^^^
attr::Default::Path(path) => Some(quote_spanned!(path.span()=>
let __default: #this_type #ty_generics = #path(); let __default: #this_type #ty_generics = #path();
)), )),
attr::Default::None => { attr::Default::None => {
@ -2840,6 +2864,13 @@ fn wrap_deserialize_with(
split_with_de_lifetime(params); split_with_de_lifetime(params);
let delife = params.borrowed.de_lifetime(); let delife = params.borrowed.de_lifetime();
// If #deserialize_with returns wrong type, error will be reported here (^^^^^).
// We attach span of the path to the function so it will be reported
// on the #[serde(with = "...")]
// ^^^^^
let value = quote_spanned! {deserialize_with.span()=>
#deserialize_with(__deserializer)?
};
let wrapper = quote! { let wrapper = quote! {
#[doc(hidden)] #[doc(hidden)]
struct __DeserializeWith #de_impl_generics #where_clause { struct __DeserializeWith #de_impl_generics #where_clause {
@ -2854,7 +2885,7 @@ fn wrap_deserialize_with(
__D: _serde::Deserializer<#delife>, __D: _serde::Deserializer<#delife>,
{ {
_serde::__private::Ok(__DeserializeWith { _serde::__private::Ok(__DeserializeWith {
value: #deserialize_with(__deserializer)?, value: #value,
phantom: _serde::__private::PhantomData, phantom: _serde::__private::PhantomData,
lifetime: _serde::__private::PhantomData, lifetime: _serde::__private::PhantomData,
}) })
@ -2945,7 +2976,11 @@ fn expr_is_missing(field: &Field, cattrs: &attr::Container) -> Fragment {
return quote_expr!(#func()); return quote_expr!(#func());
} }
attr::Default::Path(path) => { attr::Default::Path(path) => {
return quote_expr!(#path()); // If #path returns wrong type, error will be reported here (^^^^^).
// We attach span of the path to the function so it will be reported
// on the #[serde(default = "...")]
// ^^^^^
return Fragment::Expr(quote_spanned!(path.span()=> #path()));
} }
attr::Default::None => { /* below */ } attr::Default::None => { /* below */ }
} }
@ -2988,6 +3023,10 @@ fn expr_is_missing_seq(
return quote_spanned!(span=> #assign_to _serde::__private::Default::default()); return quote_spanned!(span=> #assign_to _serde::__private::Default::default());
} }
attr::Default::Path(path) => { attr::Default::Path(path) => {
// If #path returns wrong type, error will be reported here (^^^^^).
// We attach span of the path to the function so it will be reported
// on the #[serde(default = "...")]
// ^^^^^
return quote_spanned!(path.span()=> #assign_to #path()); return quote_spanned!(path.span()=> #assign_to #path());
} }
attr::Default::None => { /* below */ } attr::Default::None => { /* below */ }

9
serde_derive/src/internals/attr.rs
View File

@ -8,6 +8,7 @@ use std::iter::FromIterator;
use syn::meta::ParseNestedMeta; use syn::meta::ParseNestedMeta;
use syn::parse::ParseStream; use syn::parse::ParseStream;
use syn::punctuated::Punctuated; use syn::punctuated::Punctuated;
use syn::spanned::Spanned;
use syn::{parse_quote, token, Ident, Lifetime, Token}; use syn::{parse_quote, token, Ident, Lifetime, Token};
// This module handles parsing of `#[serde(...)]` attributes. The entrypoints // This module handles parsing of `#[serde(...)]` attributes. The entrypoints
@ -898,13 +899,13 @@ impl Variant {
ser_path ser_path
.path .path
.segments .segments
.push(Ident::new("serialize", Span::call_site()).into()); .push(Ident::new("serialize", ser_path.span()).into());
serialize_with.set(&meta.path, ser_path); serialize_with.set(&meta.path, ser_path);
let mut de_path = path; let mut de_path = path;
de_path de_path
.path .path
.segments .segments
.push(Ident::new("deserialize", Span::call_site()).into()); .push(Ident::new("deserialize", de_path.span()).into());
deserialize_with.set(&meta.path, de_path); deserialize_with.set(&meta.path, de_path);
} }
} else if meta.path == SERIALIZE_WITH { } else if meta.path == SERIALIZE_WITH {
@ -1180,13 +1181,13 @@ impl Field {
ser_path ser_path
.path .path
.segments .segments
.push(Ident::new("serialize", Span::call_site()).into()); .push(Ident::new("serialize", ser_path.span()).into());
serialize_with.set(&meta.path, ser_path); serialize_with.set(&meta.path, ser_path);
let mut de_path = path; let mut de_path = path;
de_path de_path
.path .path
.segments .segments
.push(Ident::new("deserialize", Span::call_site()).into()); .push(Ident::new("deserialize", de_path.span()).into());
deserialize_with.set(&meta.path, de_path); deserialize_with.set(&meta.path, de_path);
} }
} else if meta.path == BOUND { } else if meta.path == BOUND {

8
serde_derive/src/ser.rs
View File

@ -1229,9 +1229,15 @@ fn wrap_serialize_with(
}) })
}); });
quote!({ // If #serialize_with returns wrong type, error will be reported on here.
// We attach span of the path to this piece so error will be reported
// on the #[serde(with = "...")]
// ^^^^^
quote_spanned!(serialize_with.span()=> {
#[doc(hidden)] #[doc(hidden)]
struct __SerializeWith #wrapper_impl_generics #where_clause { struct __SerializeWith #wrapper_impl_generics #where_clause {
// If #field_tys is empty, `values` does not used
#[allow(dead_code)]
values: (#(&'__a #field_tys, )*), values: (#(&'__a #field_tys, )*),
phantom: _serde::__private::PhantomData<#this_type #ty_generics>, phantom: _serde::__private::PhantomData<#this_type #ty_generics>,
} }