diff --git a/serde_tests/benches/bench_enum.rs b/serde_tests/benches/bench_enum.rs index 0618e1f7..220f0de3 100644 --- a/serde_tests/benches/bench_enum.rs +++ b/serde_tests/benches/bench_enum.rs @@ -17,18 +17,18 @@ pub enum Animal { #[derive(Debug)] pub enum Error { - EndOfStreamError, - SyntaxError, + EndOfStream, + Syntax, } impl serde::de::Error for Error { - fn custom(_: String) -> Error { Error::SyntaxError } + fn custom(_: String) -> Error { Error::Syntax } - fn end_of_stream() -> Error { Error::EndOfStreamError } + fn end_of_stream() -> Error { Error::EndOfStream } - fn unknown_field(_: &str) -> Error { Error::SyntaxError } + fn unknown_field(_: &str) -> Error { Error::Syntax } - fn missing_field(_: &'static str) -> Error { Error::SyntaxError } + fn missing_field(_: &'static str) -> Error { Error::Syntax } } impl fmt::Display for Error { @@ -54,12 +54,11 @@ mod decoder { use super::{Animal, Error}; use super::Animal::{Dog, Frog}; - use self::State::{AnimalState, IsizeState, StringState}; enum State { - AnimalState(Animal), - IsizeState(isize), - StringState(String), + Animal(Animal), + Isize(isize), + String(String), } pub struct AnimalDecoder { @@ -71,7 +70,7 @@ mod decoder { #[inline] pub fn new(animal: Animal) -> AnimalDecoder { AnimalDecoder { - stack: vec!(AnimalState(animal)), + stack: vec!(State::Animal(animal)), } } } @@ -79,35 +78,35 @@ mod decoder { impl Decoder for AnimalDecoder { type Error = Error; - fn error(&mut self, _: &str) -> Error { Error::SyntaxError } + fn error(&mut self, _: &str) -> Error { Error::Syntax } // Primitive types: - fn read_nil(&mut self) -> Result<(), Error> { Err(Error::SyntaxError) } - fn read_usize(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u16(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u8(&mut self) -> Result { Err(Error::SyntaxError) } + fn read_nil(&mut self) -> Result<(), Error> { Err(Error::Syntax) } + fn read_usize(&mut self) -> Result { Err(Error::Syntax) } + fn read_u64(&mut self) -> Result { Err(Error::Syntax) } + fn read_u32(&mut self) -> Result { Err(Error::Syntax) } + fn read_u16(&mut self) -> Result { Err(Error::Syntax) } + fn read_u8(&mut self) -> Result { Err(Error::Syntax) } #[inline] fn read_isize(&mut self) -> Result { match self.stack.pop() { - Some(IsizeState(x)) => Ok(x), - _ => Err(Error::SyntaxError), + Some(State::Isize(x)) => Ok(x), + _ => Err(Error::Syntax), } } - fn read_i64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i16(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i8(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_bool(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_f64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_f32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_char(&mut self) -> Result { Err(Error::SyntaxError) } + fn read_i64(&mut self) -> Result { Err(Error::Syntax) } + fn read_i32(&mut self) -> Result { Err(Error::Syntax) } + fn read_i16(&mut self) -> Result { Err(Error::Syntax) } + fn read_i8(&mut self) -> Result { Err(Error::Syntax) } + fn read_bool(&mut self) -> Result { Err(Error::Syntax) } + fn read_f64(&mut self) -> Result { Err(Error::Syntax) } + fn read_f32(&mut self) -> Result { Err(Error::Syntax) } + fn read_char(&mut self) -> Result { Err(Error::Syntax) } #[inline] fn read_str(&mut self) -> Result { match self.stack.pop() { - Some(StringState(x)) => Ok(x), - _ => Err(Error::SyntaxError), + Some(State::String(x)) => Ok(x), + _ => Err(Error::Syntax), } } @@ -117,15 +116,15 @@ mod decoder { F: FnOnce(&mut AnimalDecoder) -> Result, { match self.stack.pop() { - Some(AnimalState(animal)) => { - self.stack.push(AnimalState(animal)); + Some(State::Animal(animal)) => { + self.stack.push(State::Animal(animal)); if name == "Animal" { f(self) } else { - Err(Error::SyntaxError) + Err(Error::Syntax) } } - _ => Err(Error::SyntaxError) + _ => Err(Error::Syntax) } } @@ -134,18 +133,18 @@ mod decoder { F: FnOnce(&mut AnimalDecoder, usize) -> Result, { let name = match self.stack.pop() { - Some(AnimalState(Dog)) => "Dog", - Some(AnimalState(Frog(x0, x1))) => { - self.stack.push(IsizeState(x1)); - self.stack.push(StringState(x0)); + Some(State::Animal(Dog)) => "Dog", + Some(State::Animal(Frog(x0, x1))) => { + self.stack.push(State::Isize(x1)); + self.stack.push(State::String(x0)); "Frog" } - _ => { return Err(Error::SyntaxError); } + _ => { return Err(Error::Syntax); } }; let idx = match names.iter().position(|n| *n == name) { Some(idx) => idx, - None => { return Err(Error::SyntaxError); } + None => { return Err(Error::Syntax); } }; f(self, idx) @@ -161,56 +160,56 @@ mod decoder { fn read_enum_struct_variant(&mut self, _names: &[&str], _f: F) -> Result where F: FnOnce(&mut AnimalDecoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_struct_variant_field(&mut self, _f_name: &str, _f_idx: usize, _f: F) -> Result where F: FnOnce(&mut AnimalDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_struct(&mut self, _s_name: &str, _len: usize, _f: F) -> Result where F: FnOnce(&mut AnimalDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_struct_field(&mut self, _f_name: &str, _f_idx: usize, _f: F) -> Result where F: FnOnce(&mut AnimalDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple(&mut self, _len: usize, _f: F) -> Result where F: FnOnce(&mut AnimalDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut AnimalDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_struct(&mut self, _s_name: &str, _len: usize, _f: F) -> Result where F: FnOnce(&mut AnimalDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_struct_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut AnimalDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } // Specialized types: fn read_option(&mut self, _f: F) -> Result where F: FnOnce(&mut AnimalDecoder, bool) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } #[inline] @@ -230,19 +229,19 @@ mod decoder { fn read_map(&mut self, _f: F) -> Result where F: FnOnce(&mut AnimalDecoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_map_elt_key(&mut self, _idx: usize, _f: F) -> Result where F: FnOnce(&mut AnimalDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_map_elt_val(&mut self, _idx: usize, _f: F) -> Result where F: FnOnce(&mut AnimalDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } } } @@ -256,10 +255,10 @@ mod deserializer { #[derive(Debug)] enum State { - AnimalState(Animal), - IsizeState(isize), - StrState(&'static str), - StringState(String), + Animal(Animal), + Isize(isize), + Str(&'static str), + String(String), UnitState, } @@ -271,7 +270,7 @@ mod deserializer { #[inline] pub fn new(animal: Animal) -> AnimalDeserializer { AnimalDeserializer { - stack: vec!(State::AnimalState(animal)), + stack: vec!(State::Animal(animal)), } } } @@ -284,23 +283,23 @@ mod deserializer { where V: de::Visitor, { match self.stack.pop() { - Some(State::IsizeState(value)) => { + Some(State::Isize(value)) => { visitor.visit_isize(value) } - Some(State::StringState(value)) => { + Some(State::String(value)) => { visitor.visit_string(value) } - Some(State::StrState(value)) => { + Some(State::Str(value)) => { visitor.visit_str(value) } Some(State::UnitState) => { visitor.visit_unit() } Some(_) => { - Err(Error::SyntaxError) + Err(Error::Syntax) } None => { - Err(Error::EndOfStreamError) + Err(Error::EndOfStream) } } } @@ -313,27 +312,27 @@ mod deserializer { where V: de::EnumVisitor, { match self.stack.pop() { - Some(State::AnimalState(Animal::Dog)) => { + Some(State::Animal(Animal::Dog)) => { self.stack.push(State::UnitState); - self.stack.push(State::StrState("Dog")); + self.stack.push(State::Str("Dog")); visitor.visit(DogVisitor { de: self, }) } - Some(State::AnimalState(Animal::Frog(x0, x1))) => { - self.stack.push(State::IsizeState(x1)); - self.stack.push(State::StringState(x0)); - self.stack.push(State::StrState("Frog")); + Some(State::Animal(Animal::Frog(x0, x1))) => { + self.stack.push(State::Isize(x1)); + self.stack.push(State::String(x0)); + self.stack.push(State::Str("Frog")); visitor.visit(FrogVisitor { de: self, state: 0, }) } Some(_) => { - Err(Error::SyntaxError) + Err(Error::Syntax) } None => { - Err(Error::EndOfStreamError) + Err(Error::EndOfStream) } } } @@ -405,7 +404,7 @@ mod deserializer { if self.state == 2 { Ok(()) } else { - Err(Error::SyntaxError) + Err(Error::Syntax) } } diff --git a/serde_tests/benches/bench_map.rs b/serde_tests/benches/bench_map.rs index f753953c..beab38f8 100644 --- a/serde_tests/benches/bench_map.rs +++ b/serde_tests/benches/bench_map.rs @@ -14,16 +14,16 @@ use serde::de::{Deserializer, Deserialize}; #[derive(PartialEq, Debug)] pub enum Error { EndOfStream, - SyntaxError, + Syntax, MissingField, } impl serde::de::Error for Error { - fn custom(_: String) -> Error { Error::SyntaxError } + fn custom(_: String) -> Error { Error::Syntax } fn end_of_stream() -> Error { Error::EndOfStream } - fn unknown_field(_: &str) -> Error { Error::SyntaxError } + fn unknown_field(_: &str) -> Error { Error::Syntax } fn missing_field(_: &'static str) -> Error { Error::MissingField @@ -53,11 +53,10 @@ mod decoder { use rustc_serialize; use super::Error; - use self::Value::{StringValue, IsizeValue}; enum Value { - StringValue(String), - IsizeValue(isize), + String(String), + Isize(isize), } pub struct IsizeDecoder { @@ -81,37 +80,37 @@ mod decoder { type Error = Error; fn error(&mut self, _msg: &str) -> Error { - Error::SyntaxError + Error::Syntax } // Primitive types: - fn read_nil(&mut self) -> Result<(), Error> { Err(Error::SyntaxError) } - fn read_usize(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u16(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u8(&mut self) -> Result { Err(Error::SyntaxError) } + fn read_nil(&mut self) -> Result<(), Error> { Err(Error::Syntax) } + fn read_usize(&mut self) -> Result { Err(Error::Syntax) } + fn read_u64(&mut self) -> Result { Err(Error::Syntax) } + fn read_u32(&mut self) -> Result { Err(Error::Syntax) } + fn read_u16(&mut self) -> Result { Err(Error::Syntax) } + fn read_u8(&mut self) -> Result { Err(Error::Syntax) } #[inline] fn read_isize(&mut self) -> Result { match self.stack.pop() { - Some(IsizeValue(x)) => Ok(x), - Some(_) => Err(Error::SyntaxError), + Some(Value::Isize(x)) => Ok(x), + Some(_) => Err(Error::Syntax), None => Err(Error::EndOfStream), } } - fn read_i64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i16(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i8(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_bool(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_f64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_f32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_char(&mut self) -> Result { Err(Error::SyntaxError) } + fn read_i64(&mut self) -> Result { Err(Error::Syntax) } + fn read_i32(&mut self) -> Result { Err(Error::Syntax) } + fn read_i16(&mut self) -> Result { Err(Error::Syntax) } + fn read_i8(&mut self) -> Result { Err(Error::Syntax) } + fn read_bool(&mut self) -> Result { Err(Error::Syntax) } + fn read_f64(&mut self) -> Result { Err(Error::Syntax) } + fn read_f32(&mut self) -> Result { Err(Error::Syntax) } + fn read_char(&mut self) -> Result { Err(Error::Syntax) } #[inline] fn read_str(&mut self) -> Result { match self.stack.pop() { - Some(StringValue(x)) => Ok(x), - Some(_) => Err(Error::SyntaxError), + Some(Value::String(x)) => Ok(x), + Some(_) => Err(Error::Syntax), None => Err(Error::EndOfStream), } } @@ -120,86 +119,86 @@ mod decoder { fn read_enum(&mut self, _name: &str, _f: F) -> Result where F: FnOnce(&mut IsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_variant(&mut self, _names: &[&str], _f: F) -> Result where F: FnOnce(&mut IsizeDecoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_variant_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut IsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_struct_variant(&mut self, _names: &[&str], _f: F) -> Result where F: FnOnce(&mut IsizeDecoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_struct_variant_field(&mut self, _f_name: &str, _f_idx: usize, _f: F) -> Result where F: FnOnce(&mut IsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_struct(&mut self, _s_name: &str, _len: usize, _f: F) -> Result where F: FnOnce(&mut IsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_struct_field(&mut self, _f_name: &str, _f_idx: usize, _f: F) -> Result where F: FnOnce(&mut IsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple(&mut self, _len: usize, _f: F) -> Result where F: FnOnce(&mut IsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut IsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_struct(&mut self, _s_name: &str, _len: usize, _f: F) -> Result where F: FnOnce(&mut IsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_struct_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut IsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } // Specialized types: fn read_option(&mut self, _f: F) -> Result where F: FnOnce(&mut IsizeDecoder, bool) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_seq(&mut self, _f: F) -> Result where F: FnOnce(&mut IsizeDecoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_seq_elt(&mut self, _idx: usize, _f: F) -> Result where F: FnOnce(&mut IsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } #[inline] @@ -215,12 +214,12 @@ mod decoder { { match self.iter.next() { Some((key, value)) => { - self.stack.push(IsizeValue(value)); - self.stack.push(StringValue(key)); + self.stack.push(Value::Isize(value)); + self.stack.push(Value::String(key)); f(self) } None => { - Err(Error::SyntaxError) + Err(Error::Syntax) } } } @@ -247,8 +246,8 @@ mod deserializer { #[derive(PartialEq, Debug)] enum State { StartState, - KeyState(String), - ValueState(isize), + Key(String), + Value(isize), } pub struct IsizeDeserializer { @@ -276,10 +275,10 @@ mod deserializer { Some(State::StartState) => { visitor.visit_map(self) } - Some(State::KeyState(key)) => { + Some(State::Key(key)) => { visitor.visit_string(key) } - Some(State::ValueState(value)) => { + Some(State::Value(value)) => { visitor.visit_isize(value) } None => { @@ -297,8 +296,8 @@ mod deserializer { { match self.iter.next() { Some((key, value)) => { - self.stack.push(State::ValueState(value)); - self.stack.push(State::KeyState(key)); + self.stack.push(State::Value(value)); + self.stack.push(State::Key(key)); Ok(Some(try!(de::Deserialize::deserialize(self)))) } None => { @@ -315,7 +314,7 @@ mod deserializer { fn end(&mut self) -> Result<(), Error> { match self.iter.next() { - Some(_) => Err(Error::SyntaxError), + Some(_) => Err(Error::Syntax), None => Ok(()), } } @@ -332,14 +331,14 @@ mod deserializer { #[inline] fn next(&mut self) -> Option> { match self.stack.pop() { - Some(StartState) => { + Some(State::StartState) => { self.stack.push(KeyOrEndState); Some(Ok(de::Token::MapStart(self.len))) } - Some(KeyOrEndState) => { + Some(State::KeyOrEndState) => { match self.iter.next() { Some((key, value)) => { - self.stack.push(ValueState(value)); + self.stack.push(Value(value)); Some(Ok(de::Token::String(key))) } None => { @@ -348,7 +347,7 @@ mod deserializer { } } } - Some(ValueState(x)) => { + Some(State::Value(x)) => { self.stack.push(KeyOrEndState); Some(Ok(de::Token::Isize(x))) } @@ -370,24 +369,24 @@ mod deserializer { #[inline] fn syntax(&mut self, _token: de::Token, _expected: &[de::TokenKind]) -> Error { - SyntaxError + Syntax } #[inline] fn unexpected_name(&mut self, _token: de::Token) -> Error { - SyntaxError + Syntax } #[inline] fn conversion_error(&mut self, _token: de::Token) -> Error { - SyntaxError + Syntax } #[inline] fn missing_field< T: de::Deserialize >(&mut self, _field: &'static str) -> Result { - Err(Error::SyntaxError) + Err(Error::Syntax) } } */ diff --git a/serde_tests/benches/bench_struct.rs b/serde_tests/benches/bench_struct.rs index d8e62e23..7ad311f7 100644 --- a/serde_tests/benches/bench_struct.rs +++ b/serde_tests/benches/bench_struct.rs @@ -29,17 +29,17 @@ pub struct Outer { #[derive(Debug, PartialEq)] pub enum Error { EndOfStream, - SyntaxError, + Syntax, MissingField, OtherError, } impl serde::de::Error for Error { - fn custom(_: String) -> Error { Error::SyntaxError } + fn custom(_: String) -> Error { Error::Syntax } fn end_of_stream() -> Error { Error::EndOfStream } - fn unknown_field(_: &str) -> Error { Error::SyntaxError } + fn unknown_field(_: &str) -> Error { Error::Syntax } fn missing_field(_: &'static str) -> Error { Error::MissingField @@ -68,31 +68,18 @@ mod decoder { use super::{Outer, Inner, Error}; - use self::State::{ - OuterState, - InnerState, - NullState, - UsizeState, - CharState, - StringState, - FieldState, - VecState, - MapState, - OptionState, - }; - #[derive(Debug)] enum State { - OuterState(Outer), - InnerState(Inner), - NullState, - UsizeState(usize), - CharState(char), - StringState(String), - FieldState(&'static str), - VecState(Vec), - MapState(HashMap>), - OptionState(bool), + Outer(Outer), + Inner(Inner), + Null, + Usize(usize), + Char(char), + String(String), + Field(&'static str), + Vec(Vec), + Map(HashMap>), + Option(bool), } pub struct OuterDecoder { @@ -104,7 +91,7 @@ mod decoder { #[inline] pub fn new(animal: Outer) -> OuterDecoder { OuterDecoder { - stack: vec!(OuterState(animal)), + stack: vec!(State::Outer(animal)), } } } @@ -120,41 +107,41 @@ mod decoder { #[inline] fn read_nil(&mut self) -> Result<(), Error> { match self.stack.pop() { - Some(NullState) => Ok(()), - _ => Err(Error::SyntaxError), + Some(State::Null) => Ok(()), + _ => Err(Error::Syntax), } } #[inline] fn read_usize(&mut self) -> Result { match self.stack.pop() { - Some(UsizeState(value)) => Ok(value), - _ => Err(Error::SyntaxError), + Some(State::Usize(value)) => Ok(value), + _ => Err(Error::Syntax), } } - fn read_u64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u16(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u8(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_isize(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i16(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i8(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_bool(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_f64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_f32(&mut self) -> Result { Err(Error::SyntaxError) } + fn read_u64(&mut self) -> Result { Err(Error::Syntax) } + fn read_u32(&mut self) -> Result { Err(Error::Syntax) } + fn read_u16(&mut self) -> Result { Err(Error::Syntax) } + fn read_u8(&mut self) -> Result { Err(Error::Syntax) } + fn read_isize(&mut self) -> Result { Err(Error::Syntax) } + fn read_i64(&mut self) -> Result { Err(Error::Syntax) } + fn read_i32(&mut self) -> Result { Err(Error::Syntax) } + fn read_i16(&mut self) -> Result { Err(Error::Syntax) } + fn read_i8(&mut self) -> Result { Err(Error::Syntax) } + fn read_bool(&mut self) -> Result { Err(Error::Syntax) } + fn read_f64(&mut self) -> Result { Err(Error::Syntax) } + fn read_f32(&mut self) -> Result { Err(Error::Syntax) } #[inline] fn read_char(&mut self) -> Result { match self.stack.pop() { - Some(CharState(c)) => Ok(c), - _ => Err(Error::SyntaxError), + Some(State::Char(c)) => Ok(c), + _ => Err(Error::Syntax), } } #[inline] fn read_str(&mut self) -> Result { match self.stack.pop() { - Some(StringState(value)) => Ok(value), - _ => Err(Error::SyntaxError), + Some(State::String(value)) => Ok(value), + _ => Err(Error::Syntax), } } @@ -162,31 +149,31 @@ mod decoder { fn read_enum(&mut self, _name: &str, _f: F) -> Result where F: FnOnce(&mut OuterDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_variant(&mut self, _names: &[&str], _f: F) -> Result where F: FnOnce(&mut OuterDecoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_variant_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut OuterDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_struct_variant(&mut self, _names: &[&str], _f: F) -> Result where F: FnOnce(&mut OuterDecoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_struct_variant_field(&mut self, _f_name: &str, _f_idx: usize, _f: F) -> Result where F: FnOnce(&mut OuterDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } #[inline] @@ -194,31 +181,31 @@ mod decoder { F: FnOnce(&mut OuterDecoder) -> Result, { match self.stack.pop() { - Some(OuterState(Outer { inner })) => { + Some(State::Outer(Outer { inner })) => { if s_name == "Outer" { - self.stack.push(VecState(inner)); - self.stack.push(FieldState("inner")); + self.stack.push(State::Vec(inner)); + self.stack.push(State::Field("inner")); f(self) } else { - Err(Error::SyntaxError) + Err(Error::Syntax) } } - Some(InnerState(Inner { a: (), b, c })) => { + Some(State::Inner(Inner { a: (), b, c })) => { if s_name == "Inner" { - self.stack.push(MapState(c)); - self.stack.push(FieldState("c")); + self.stack.push(State::Map(c)); + self.stack.push(State::Field("c")); - self.stack.push(UsizeState(b)); - self.stack.push(FieldState("b")); + self.stack.push(State::Usize(b)); + self.stack.push(State::Field("b")); - self.stack.push(NullState); - self.stack.push(FieldState("a")); + self.stack.push(State::Null); + self.stack.push(State::Field("a")); f(self) } else { - Err(Error::SyntaxError) + Err(Error::Syntax) } } - _ => Err(Error::SyntaxError), + _ => Err(Error::Syntax), } } #[inline] @@ -226,39 +213,39 @@ mod decoder { F: FnOnce(&mut OuterDecoder) -> Result, { match self.stack.pop() { - Some(FieldState(name)) => { + Some(State::Field(name)) => { if f_name == name { f(self) } else { - Err(Error::SyntaxError) + Err(Error::Syntax) } } - _ => Err(Error::SyntaxError) + _ => Err(Error::Syntax) } } fn read_tuple(&mut self, _len: usize, _f: F) -> Result where F: FnOnce(&mut OuterDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut OuterDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_struct(&mut self, _s_name: &str, _len: usize, _f: F) -> Result where F: FnOnce(&mut OuterDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_struct_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut OuterDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } // Specialized types: @@ -267,8 +254,8 @@ mod decoder { F: FnOnce(&mut OuterDecoder, bool) -> Result, { match self.stack.pop() { - Some(OptionState(b)) => f(self, b), - _ => Err(Error::SyntaxError), + Some(State::Option(b)) => f(self, b), + _ => Err(Error::Syntax), } } @@ -277,14 +264,14 @@ mod decoder { F: FnOnce(&mut OuterDecoder, usize) -> Result, { match self.stack.pop() { - Some(VecState(value)) => { + Some(State::Vec(value)) => { let len = value.len(); for inner in value.into_iter().rev() { - self.stack.push(InnerState(inner)); + self.stack.push(State::Inner(inner)); } f(self, len) } - _ => Err(Error::SyntaxError) + _ => Err(Error::Syntax) } } #[inline] @@ -299,23 +286,23 @@ mod decoder { F: FnOnce(&mut OuterDecoder, usize) -> Result, { match self.stack.pop() { - Some(MapState(map)) => { + Some(State::Map(map)) => { let len = map.len(); for (key, value) in map { match value { Some(c) => { - self.stack.push(CharState(c)); - self.stack.push(OptionState(true)); + self.stack.push(State::Char(c)); + self.stack.push(State::Option(true)); } None => { - self.stack.push(OptionState(false)); + self.stack.push(State::Option(false)); } } - self.stack.push(StringState(key)); + self.stack.push(State::String(key)); } f(self, len) } - _ => Err(Error::SyntaxError), + _ => Err(Error::Syntax), } } #[inline] @@ -346,16 +333,16 @@ mod deserializer { #[derive(Debug)] enum State { - OuterState(Outer), - InnerState(Inner), - StrState(&'static str), - NullState, - UsizeState(usize), - CharState(char), - StringState(String), - OptionState(bool), - VecState(Vec), - MapState(HashMap>), + Outer(Outer), + Inner(Inner), + Str(&'static str), + Null, + Usize(usize), + Char(char), + String(String), + Option(bool), + Vec(Vec), + Map(HashMap>), } pub struct OuterDeserializer { @@ -366,7 +353,7 @@ mod deserializer { #[inline] pub fn new(outer: Outer) -> OuterDeserializer { OuterDeserializer { - stack: vec!(State::OuterState(outer)), + stack: vec!(State::Outer(outer)), } } } @@ -378,40 +365,40 @@ mod deserializer { where V: de::Visitor, { match self.stack.pop() { - Some(State::VecState(value)) => { + Some(State::Vec(value)) => { visitor.visit_seq(OuterSeqVisitor { de: self, iter: value.into_iter(), }) } - Some(State::MapState(value)) => { + Some(State::Map(value)) => { visitor.visit_map(MapVisitor { de: self, iter: value.into_iter(), }) } - Some(State::NullState) => { + Some(State::Null) => { visitor.visit_unit() } - Some(State::UsizeState(x)) => { + Some(State::Usize(x)) => { visitor.visit_usize(x) } - Some(State::CharState(x)) => { + Some(State::Char(x)) => { visitor.visit_char(x) } - Some(State::StrState(x)) => { + Some(State::Str(x)) => { visitor.visit_str(x) } - Some(State::StringState(x)) => { + Some(State::String(x)) => { visitor.visit_string(x) } - Some(State::OptionState(false)) => { + Some(State::Option(false)) => { visitor.visit_none() } - Some(State::OptionState(true)) => { + Some(State::Option(true)) => { visitor.visit_some(self) } - Some(_) => Err(Error::SyntaxError), + Some(_) => Err(Error::Syntax), None => Err(Error::EndOfStream), } } @@ -423,32 +410,32 @@ mod deserializer { where V: de::Visitor, { match self.stack.pop() { - Some(State::OuterState(Outer { inner })) => { + Some(State::Outer(Outer { inner })) => { if name != "Outer" { - return Err(Error::SyntaxError); + return Err(Error::Syntax); } - self.stack.push(State::VecState(inner)); - self.stack.push(State::StrState("inner")); + self.stack.push(State::Vec(inner)); + self.stack.push(State::Str("inner")); visitor.visit_map(OuterMapVisitor { de: self, state: 0, }) } - Some(State::InnerState(Inner { a: (), b, c })) => { + Some(State::Inner(Inner { a: (), b, c })) => { if name != "Inner" { - return Err(Error::SyntaxError); + return Err(Error::Syntax); } - self.stack.push(State::MapState(c)); - self.stack.push(State::StrState("c")); + self.stack.push(State::Map(c)); + self.stack.push(State::Str("c")); - self.stack.push(State::UsizeState(b)); - self.stack.push(State::StrState("b")); + self.stack.push(State::Usize(b)); + self.stack.push(State::Str("b")); - self.stack.push(State::NullState); - self.stack.push(State::StrState("a")); + self.stack.push(State::Null); + self.stack.push(State::Str("a")); visitor.visit_map(InnerMapVisitor { de: self, @@ -456,7 +443,7 @@ mod deserializer { }) } _ => { - Err(Error::SyntaxError) + Err(Error::Syntax) } } } @@ -494,7 +481,7 @@ mod deserializer { if self.state == 1 { Ok(()) } else { - Err(Error::SyntaxError) + Err(Error::Syntax) } } @@ -517,7 +504,7 @@ mod deserializer { { match self.iter.next() { Some(value) => { - self.de.stack.push(State::InnerState(value)); + self.de.stack.push(State::Inner(value)); Ok(Some(try!(de::Deserialize::deserialize(self.de)))) } None => { @@ -528,7 +515,7 @@ mod deserializer { fn end(&mut self) -> Result<(), Error> { match self.iter.next() { - Some(_) => Err(Error::SyntaxError), + Some(_) => Err(Error::Syntax), None => Ok(()), } } @@ -570,7 +557,7 @@ mod deserializer { if self.state == 3 { Ok(()) } else { - Err(Error::SyntaxError) + Err(Error::Syntax) } } @@ -593,14 +580,14 @@ mod deserializer { { match self.iter.next() { Some((key, Some(value))) => { - self.de.stack.push(State::CharState(value)); - self.de.stack.push(State::OptionState(true)); - self.de.stack.push(State::StringState(key)); + self.de.stack.push(State::Char(value)); + self.de.stack.push(State::Option(true)); + self.de.stack.push(State::String(key)); Ok(Some(try!(de::Deserialize::deserialize(self.de)))) } Some((key, None)) => { - self.de.stack.push(State::OptionState(false)); - self.de.stack.push(State::StringState(key)); + self.de.stack.push(State::Option(false)); + self.de.stack.push(State::String(key)); Ok(Some(try!(de::Deserialize::deserialize(self.de)))) } None => { @@ -617,7 +604,7 @@ mod deserializer { fn end(&mut self) -> Result<(), Error> { match self.iter.next() { - Some(_) => Err(Error::SyntaxError), + Some(_) => Err(Error::Syntax), None => Ok(()), } } diff --git a/serde_tests/benches/bench_vec.rs b/serde_tests/benches/bench_vec.rs index eac501aa..01edcf09 100644 --- a/serde_tests/benches/bench_vec.rs +++ b/serde_tests/benches/bench_vec.rs @@ -12,18 +12,18 @@ use serde::de::{Deserializer, Deserialize}; #[derive(PartialEq, Debug)] pub enum Error { - EndOfStreamError, - SyntaxError, + EndOfStream, + Syntax, } impl serde::de::Error for Error { - fn custom(_: String) -> Error { Error::SyntaxError } + fn custom(_: String) -> Error { Error::Syntax } - fn end_of_stream() -> Error { Error::EndOfStreamError } + fn end_of_stream() -> Error { Error::EndOfStream } - fn unknown_field(_: &str) -> Error { Error::SyntaxError } + fn unknown_field(_: &str) -> Error { Error::Syntax } - fn missing_field(_: &'static str) -> Error { Error::SyntaxError } + fn missing_field(_: &'static str) -> Error { Error::Syntax } } impl fmt::Display for Error { @@ -67,104 +67,104 @@ mod decoder { impl rustc_serialize::Decoder for UsizeDecoder { type Error = Error; - fn error(&mut self, _: &str) -> Error { Error::SyntaxError } + fn error(&mut self, _: &str) -> Error { Error::Syntax } // Primitive types: - fn read_nil(&mut self) -> Result<(), Error> { Err(Error::SyntaxError) } + fn read_nil(&mut self) -> Result<(), Error> { Err(Error::Syntax) } #[inline] fn read_usize(&mut self) -> Result { match self.iter.next() { Some(value) => Ok(value), - None => Err(Error::EndOfStreamError), + None => Err(Error::EndOfStream), } } - fn read_u64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u16(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u8(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_isize(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i16(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i8(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_bool(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_f64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_f32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_char(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_str(&mut self) -> Result { Err(Error::SyntaxError) } + fn read_u64(&mut self) -> Result { Err(Error::Syntax) } + fn read_u32(&mut self) -> Result { Err(Error::Syntax) } + fn read_u16(&mut self) -> Result { Err(Error::Syntax) } + fn read_u8(&mut self) -> Result { Err(Error::Syntax) } + fn read_isize(&mut self) -> Result { Err(Error::Syntax) } + fn read_i64(&mut self) -> Result { Err(Error::Syntax) } + fn read_i32(&mut self) -> Result { Err(Error::Syntax) } + fn read_i16(&mut self) -> Result { Err(Error::Syntax) } + fn read_i8(&mut self) -> Result { Err(Error::Syntax) } + fn read_bool(&mut self) -> Result { Err(Error::Syntax) } + fn read_f64(&mut self) -> Result { Err(Error::Syntax) } + fn read_f32(&mut self) -> Result { Err(Error::Syntax) } + fn read_char(&mut self) -> Result { Err(Error::Syntax) } + fn read_str(&mut self) -> Result { Err(Error::Syntax) } // Compound types: fn read_enum(&mut self, _name: &str, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_variant(&mut self, _names: &[&str], _f: F) -> Result where F: FnOnce(&mut UsizeDecoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_variant_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_struct_variant(&mut self, _names: &[&str], _f: F) -> Result where F: FnOnce(&mut UsizeDecoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_struct_variant_field(&mut self, _f_name: &str, _f_idx: usize, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_struct(&mut self, _s_name: &str, _len: usize, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_struct_field(&mut self, _f_name: &str, _f_idx: usize, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple(&mut self, _len: usize, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_struct(&mut self, _s_name: &str, _len: usize, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_struct_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } // Specialized types: fn read_option(&mut self, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder, bool) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } #[inline] @@ -184,19 +184,19 @@ mod decoder { fn read_map(&mut self, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_map_elt_key(&mut self, _idx: usize, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_map_elt_val(&mut self, _idx: usize, _f: F) -> Result where F: FnOnce(&mut UsizeDecoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } } @@ -219,105 +219,105 @@ mod decoder { impl rustc_serialize::Decoder for U8Decoder { type Error = Error; - fn error(&mut self, _: &str) -> Error { Error::SyntaxError } + fn error(&mut self, _: &str) -> Error { Error::Syntax } // Primitive types: - fn read_nil(&mut self) -> Result<(), Error> { Err(Error::SyntaxError) } - fn read_usize(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_u16(&mut self) -> Result { Err(Error::SyntaxError) } + fn read_nil(&mut self) -> Result<(), Error> { Err(Error::Syntax) } + fn read_usize(&mut self) -> Result { Err(Error::Syntax) } + fn read_u64(&mut self) -> Result { Err(Error::Syntax) } + fn read_u32(&mut self) -> Result { Err(Error::Syntax) } + fn read_u16(&mut self) -> Result { Err(Error::Syntax) } #[inline] fn read_u8(&mut self) -> Result { match self.iter.next() { Some(value) => Ok(value), - None => Err(Error::EndOfStreamError), + None => Err(Error::EndOfStream), } } #[inline] - fn read_isize(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i16(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_i8(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_bool(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_f64(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_f32(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_char(&mut self) -> Result { Err(Error::SyntaxError) } - fn read_str(&mut self) -> Result { Err(Error::SyntaxError) } + fn read_isize(&mut self) -> Result { Err(Error::Syntax) } + fn read_i64(&mut self) -> Result { Err(Error::Syntax) } + fn read_i32(&mut self) -> Result { Err(Error::Syntax) } + fn read_i16(&mut self) -> Result { Err(Error::Syntax) } + fn read_i8(&mut self) -> Result { Err(Error::Syntax) } + fn read_bool(&mut self) -> Result { Err(Error::Syntax) } + fn read_f64(&mut self) -> Result { Err(Error::Syntax) } + fn read_f32(&mut self) -> Result { Err(Error::Syntax) } + fn read_char(&mut self) -> Result { Err(Error::Syntax) } + fn read_str(&mut self) -> Result { Err(Error::Syntax) } // Compound types: fn read_enum(&mut self, _name: &str, _f: F) -> Result where F: FnOnce(&mut U8Decoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_variant(&mut self, _names: &[&str], _f: F) -> Result where F: FnOnce(&mut U8Decoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_variant_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut U8Decoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_struct_variant(&mut self, _names: &[&str], _f: F) -> Result where F: FnOnce(&mut U8Decoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_enum_struct_variant_field(&mut self, _f_name: &str, _f_idx: usize, _f: F) -> Result where F: FnOnce(&mut U8Decoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_struct(&mut self, _s_name: &str, _len: usize, _f: F) -> Result where F: FnOnce(&mut U8Decoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_struct_field(&mut self, _f_name: &str, _f_idx: usize, _f: F) -> Result where F: FnOnce(&mut U8Decoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple(&mut self, _len: usize, _f: F) -> Result where F: FnOnce(&mut U8Decoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut U8Decoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_struct(&mut self, _s_name: &str, _len: usize, _f: F) -> Result where F: FnOnce(&mut U8Decoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_tuple_struct_arg(&mut self, _a_idx: usize, _f: F) -> Result where F: FnOnce(&mut U8Decoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } // Specialized types: fn read_option(&mut self, _f: F) -> Result where F: FnOnce(&mut U8Decoder, bool) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } #[inline] @@ -337,19 +337,19 @@ mod decoder { fn read_map(&mut self, _f: F) -> Result where F: FnOnce(&mut U8Decoder, usize) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_map_elt_key(&mut self, _idx: usize, _f: F) -> Result where F: FnOnce(&mut U8Decoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } fn read_map_elt_val(&mut self, _idx: usize, _f: F) -> Result where F: FnOnce(&mut U8Decoder) -> Result, { - Err(Error::SyntaxError) + Err(Error::Syntax) } } } @@ -366,9 +366,9 @@ mod deserializer { #[derive(PartialEq, Debug)] enum State { - StartState, - SepOrEndState, - EndState, + Start, + SepOrEnd, + End, } pub struct Deserializer { @@ -383,7 +383,7 @@ mod deserializer { pub fn new(values: Vec) -> Deserializer { let len = values.len(); Deserializer { - state: State::StartState, + state: State::Start, iter: values.into_iter(), len: len, value: None, @@ -399,15 +399,15 @@ mod deserializer { where V: de::Visitor, { match self.state { - State::StartState => { - self.state = State::SepOrEndState; + State::Start => { + self.state = State::SepOrEnd; visitor.visit_seq(self) } - State::SepOrEndState => { + State::SepOrEnd => { visitor.visit_usize(self.value.take().unwrap()) } - State::EndState => { - Err(Error::EndOfStreamError) + State::End => { + Err(Error::EndOfStream) } } } @@ -427,7 +427,7 @@ mod deserializer { Ok(Some(try!(de::Deserialize::deserialize(self)))) } None => { - self.state = State::EndState; + self.state = State::End; Ok(None) } } @@ -436,9 +436,9 @@ mod deserializer { #[inline] fn end(&mut self) -> Result<(), Error> { match self.iter.next() { - Some(_) => Err(Error::SyntaxError), + Some(_) => Err(Error::Syntax), None => { - self.state = State::EndState; + self.state = State::End; Ok(()) } } @@ -458,15 +458,15 @@ mod deserializer { where V: de::Visitor, { match self.state { - State::StartState => { - self.state = State::SepOrEndState; + State::Start => { + self.state = State::SepOrEnd; visitor.visit_seq(self) } - State::SepOrEndState => { + State::SepOrEnd => { visitor.visit_u8(self.value.take().unwrap()) } - State::EndState => { - Err(Error::EndOfStreamError) + State::End => { + Err(Error::EndOfStream) } } } @@ -486,7 +486,7 @@ mod deserializer { Ok(Some(try!(de::Deserialize::deserialize(self)))) } None => { - self.state = State::EndState; + self.state = State::End; Ok(None) } } @@ -495,9 +495,9 @@ mod deserializer { #[inline] fn end(&mut self) -> Result<(), Error> { match self.iter.next() { - Some(_) => Err(Error::SyntaxError), + Some(_) => Err(Error::Syntax), None => { - self.state = State::EndState; + self.state = State::End; Ok(()) } }