From 02631cef421cb35b98e6353a07a1e1d814fe117a Mon Sep 17 00:00:00 2001 From: David Tolnay Date: Tue, 5 May 2020 17:03:57 -0700 Subject: [PATCH] Remove clippy from main CI workflow We don't run clippy on PRs. It is covered by a separate clippy.yml workflow. --- .github/workflows/ci.yml | 15 --------------- .github/workflows/clippy.yml | 4 +--- 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 16025db9..fd2fa4cb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -104,21 +104,6 @@ jobs: - uses: dtolnay/rust-toolchain@1.36.0 - run: cd serde && cargo build --no-default-features --features alloc - clippy: - name: Clippy - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - uses: dtolnay/rust-toolchain@clippy - # The need for -Aredundant_field_names here is a Clippy bug. - # https://github.com/rust-lang/rust-clippy/issues/5356 - - run: cargo clippy -- -D clippy::all -A clippy::redundant_field_names - - run: cd serde && cargo clippy --features rc,unstable -- -D clippy::all -A clippy::redundant_field_names - - run: cd serde_derive && cargo clippy -- -D clippy::all - - run: cd serde_test && cargo clippy -- -D clippy::all -A clippy::redundant_field_names - - run: cd test_suite && cargo clippy --tests --features unstable -- -D clippy::all -A clippy::redundant_field_names - - run: cd test_suite/no_std && cargo clippy -- -D clippy::all -A clippy::redundant_field_names - emscripten: name: Emscripten runs-on: ubuntu-latest diff --git a/.github/workflows/clippy.yml b/.github/workflows/clippy.yml index d64e23ee..368428ca 100644 --- a/.github/workflows/clippy.yml +++ b/.github/workflows/clippy.yml @@ -22,9 +22,7 @@ jobs: - dir: test_suite/no_std steps: - uses: actions/checkout@v2 - - uses: dtolnay/rust-toolchain@nightly - with: - components: clippy + - uses: dtolnay/rust-toolchain@clippy # The need for -Aredundant_field_names here is a Clippy bug. # https://github.com/rust-lang/rust-clippy/issues/5356 - name: cargo clippy ${{matrix.features && format('--features {0}', matrix.features)}}