c8b76bcf58
On some architectures, vector types may have a different ABI depending on whether the relevant target features are enabled. (The ABI when the feature is disabled is often not specified, but LLVM implements some de-facto ABI.) As discussed in rust-lang/lang-team#235, this turns out to very easily lead to unsound code. This commit makes it a post-monomorphization future-incompat warning to declare or call functions using those vector types in a context in which the corresponding target features are disabled, if using an ABI for which the difference is relevant. This ensures that these functions are always called with a consistent ABI. See the [nomination comment](https://github.com/rust-lang/rust/pull/127731#issuecomment-2288558187) for more discussion. Part of #116558
113 lines
3.0 KiB
Rust
113 lines
3.0 KiB
Rust
use std::path::PathBuf;
|
|
|
|
use rustc_errors::{Diag, DiagCtxtHandle, Diagnostic, EmissionGuarantee, Level};
|
|
use rustc_macros::{Diagnostic, LintDiagnostic};
|
|
use rustc_span::{Span, Symbol};
|
|
|
|
use crate::fluent_generated as fluent;
|
|
|
|
#[derive(Diagnostic)]
|
|
#[diag(monomorphize_recursion_limit)]
|
|
pub(crate) struct RecursionLimit {
|
|
#[primary_span]
|
|
pub span: Span,
|
|
pub shrunk: String,
|
|
#[note]
|
|
pub def_span: Span,
|
|
pub def_path_str: String,
|
|
#[note(monomorphize_written_to_path)]
|
|
pub was_written: bool,
|
|
pub path: PathBuf,
|
|
}
|
|
|
|
#[derive(Diagnostic)]
|
|
#[diag(monomorphize_no_optimized_mir)]
|
|
pub(crate) struct NoOptimizedMir {
|
|
#[note]
|
|
pub span: Span,
|
|
pub crate_name: Symbol,
|
|
}
|
|
|
|
pub(crate) struct UnusedGenericParamsHint {
|
|
pub span: Span,
|
|
pub param_spans: Vec<Span>,
|
|
pub param_names: Vec<String>,
|
|
}
|
|
|
|
impl<G: EmissionGuarantee> Diagnostic<'_, G> for UnusedGenericParamsHint {
|
|
#[track_caller]
|
|
fn into_diag(self, dcx: DiagCtxtHandle<'_>, level: Level) -> Diag<'_, G> {
|
|
let mut diag = Diag::new(dcx, level, fluent::monomorphize_unused_generic_params);
|
|
diag.span(self.span);
|
|
for (span, name) in self.param_spans.into_iter().zip(self.param_names) {
|
|
// FIXME: I can figure out how to do a label with a fluent string with a fixed message,
|
|
// or a label with a dynamic value in a hard-coded string, but I haven't figured out
|
|
// how to combine the two. 😢
|
|
#[allow(rustc::untranslatable_diagnostic)]
|
|
diag.span_label(span, format!("generic parameter `{name}` is unused"));
|
|
}
|
|
diag
|
|
}
|
|
}
|
|
|
|
#[derive(LintDiagnostic)]
|
|
#[diag(monomorphize_large_assignments)]
|
|
#[note]
|
|
pub(crate) struct LargeAssignmentsLint {
|
|
#[label]
|
|
pub span: Span,
|
|
pub size: u64,
|
|
pub limit: u64,
|
|
}
|
|
|
|
#[derive(Diagnostic)]
|
|
#[diag(monomorphize_symbol_already_defined)]
|
|
pub(crate) struct SymbolAlreadyDefined {
|
|
#[primary_span]
|
|
pub span: Option<Span>,
|
|
pub symbol: String,
|
|
}
|
|
|
|
#[derive(Diagnostic)]
|
|
#[diag(monomorphize_couldnt_dump_mono_stats)]
|
|
pub(crate) struct CouldntDumpMonoStats {
|
|
pub error: String,
|
|
}
|
|
|
|
#[derive(Diagnostic)]
|
|
#[diag(monomorphize_encountered_error_while_instantiating)]
|
|
pub(crate) struct EncounteredErrorWhileInstantiating {
|
|
#[primary_span]
|
|
pub span: Span,
|
|
pub formatted_item: String,
|
|
}
|
|
|
|
#[derive(Diagnostic)]
|
|
#[diag(monomorphize_start_not_found)]
|
|
#[help]
|
|
pub(crate) struct StartNotFound;
|
|
|
|
#[derive(Diagnostic)]
|
|
#[diag(monomorphize_unknown_cgu_collection_mode)]
|
|
pub(crate) struct UnknownCguCollectionMode<'a> {
|
|
pub mode: &'a str,
|
|
}
|
|
|
|
#[derive(LintDiagnostic)]
|
|
#[diag(monomorphize_abi_error_disabled_vector_type_def)]
|
|
#[help]
|
|
pub(crate) struct AbiErrorDisabledVectorTypeDef<'a> {
|
|
#[label]
|
|
pub span: Span,
|
|
pub required_feature: &'a str,
|
|
}
|
|
|
|
#[derive(LintDiagnostic)]
|
|
#[diag(monomorphize_abi_error_disabled_vector_type_call)]
|
|
#[help]
|
|
pub(crate) struct AbiErrorDisabledVectorTypeCall<'a> {
|
|
#[label]
|
|
pub span: Span,
|
|
pub required_feature: &'a str,
|
|
}
|