7f928d150e
declared with the same name in the same scope.
This breaks several common patterns. First are unused imports:
use foo::bar;
use baz::bar;
Change this code to the following:
use baz::bar;
Second, this patch breaks globs that import names that are shadowed by
subsequent imports. For example:
use foo::*; // including `bar`
use baz::bar;
Change this code to remove the glob:
use foo::{boo, quux};
use baz::bar;
Or qualify all uses of `bar`:
use foo::{boo, quux};
use baz;
... baz::bar ...
Finally, this patch breaks code that, at top level, explicitly imports
`std` and doesn't disable the prelude.
extern crate std;
Because the prelude imports `std` implicitly, there is no need to
explicitly import it; just remove such directives.
The old behavior can be opted into via the `import_shadowing` feature
gate. Use of this feature gate is discouraged.
This implements RFC #116.
Closes #16464.
[breaking-change]
119 lines
1.7 KiB
Rust
119 lines
1.7 KiB
Rust
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution and at
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
|
|
// Check we do the correct privacy checks when we import a name and there is an
|
|
// item with that name in both the value and type namespaces.
|
|
|
|
#![feature(globs)]
|
|
#![allow(dead_code)]
|
|
#![allow(unused_imports)]
|
|
|
|
|
|
// public type, private value
|
|
pub mod foo1 {
|
|
pub trait Bar {
|
|
}
|
|
pub struct Baz;
|
|
|
|
fn Bar() { }
|
|
}
|
|
|
|
fn test_unused1() {
|
|
use foo1::*;
|
|
}
|
|
|
|
fn test_single1() {
|
|
use foo1::Bar;
|
|
|
|
let _x: Box<Bar>;
|
|
}
|
|
|
|
fn test_list1() {
|
|
use foo1::{Bar,Baz};
|
|
|
|
let _x: Box<Bar>;
|
|
}
|
|
|
|
fn test_glob1() {
|
|
use foo1::*;
|
|
|
|
let _x: Box<Bar>;
|
|
}
|
|
|
|
// private type, public value
|
|
pub mod foo2 {
|
|
trait Bar {
|
|
}
|
|
pub struct Baz;
|
|
|
|
pub fn Bar() { }
|
|
}
|
|
|
|
fn test_unused2() {
|
|
use foo2::*;
|
|
}
|
|
|
|
fn test_single2() {
|
|
use foo2::Bar;
|
|
|
|
Bar();
|
|
}
|
|
|
|
fn test_list2() {
|
|
use foo2::{Bar,Baz};
|
|
|
|
Bar();
|
|
}
|
|
|
|
fn test_glob2() {
|
|
use foo2::*;
|
|
|
|
Bar();
|
|
}
|
|
|
|
// public type, public value
|
|
pub mod foo3 {
|
|
pub trait Bar {
|
|
}
|
|
pub struct Baz;
|
|
|
|
pub fn Bar() { }
|
|
}
|
|
|
|
fn test_unused3() {
|
|
use foo3::*;
|
|
}
|
|
|
|
fn test_single3() {
|
|
use foo3::Bar;
|
|
|
|
Bar();
|
|
let _x: Box<Bar>;
|
|
}
|
|
|
|
fn test_list3() {
|
|
use foo3::{Bar,Baz};
|
|
|
|
Bar();
|
|
let _x: Box<Bar>;
|
|
}
|
|
|
|
fn test_glob3() {
|
|
use foo3::*;
|
|
|
|
Bar();
|
|
let _x: Box<Bar>;
|
|
}
|
|
|
|
fn main() {
|
|
}
|
|
|