Eduardo Broto f8ac1f99ef Address suggestions in PR review

2020-10-30 23:47:22 +01:00

..

methods

Address suggestions in PR review

2020-10-30 23:47:22 +01:00

utils

single_char_push_str lint using insert_str() on single-char literals and suggest insert()

2020-10-30 23:28:17 +01:00

approx_const.rs

…

arithmetic.rs

removed lint for division/modulo for literal 0

2020-10-30 17:31:10 +05:30

as_conversions.rs

…

asm_syntax.rs

Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup

2020-10-09 12:45:29 +02:00

assertions_on_constants.rs

…

assign_ops.rs

…

async_yields_async.rs

…

atomic_ordering.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

attrs.rs

Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup

2020-10-09 12:45:29 +02:00

await_holding_invalid.rs

Merge lints into one pass

2020-10-21 11:04:26 -04:00

bit_mask.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

blacklisted_name.rs

…

blocks_in_if_conditions.rs

Remove an extra blank line in doc examples

2020-10-19 10:34:01 +09:00

booleans.rs

…

bytecount.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

cargo_common_metadata.rs

…

checked_conversions.rs

…

cognitive_complexity.rs

…

collapsible_if.rs

…

comparison_chain.rs

…

consts.rs

Merge commit 'bf1c6f9871f430e284b17aa44059e0d0395e28a6' into clippyup

2020-10-23 22:16:59 +02:00

copies.rs

improve MATCH_LIKE_MATCHES_MACRO lint

2020-10-27 23:45:58 +03:00

copy_iterator.rs

…

create_dir.rs

…

dbg_macro.rs

…

default_trait_access.rs

…

deprecated_lints.rs

Deprecate temporary_cstr_as_ptr

2020-10-28 22:34:45 +01:00

dereference.rs

…

derive.rs

Fix invalid paths

2020-10-27 07:43:38 +02:00

disallowed_method.rs

Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup

2020-10-09 12:45:29 +02:00

doc.rs

Merge commit 'bf1c6f9871f430e284b17aa44059e0d0395e28a6' into clippyup

2020-10-23 22:16:59 +02:00

double_comparison.rs

…

double_parens.rs

…

drop_forget_ref.rs

…

duration_subsec.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

else_if_without_else.rs

…

empty_enum.rs

…

entry.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

enum_clike.rs

…

enum_variants.rs

…

eq_op.rs

Merge commit 'bf1c6f9871f430e284b17aa44059e0d0395e28a6' into clippyup

2020-10-23 22:16:59 +02:00

erasing_op.rs

…

escape.rs

Remove an extra blank line in doc examples

2020-10-19 10:34:01 +09:00

eta_reduction.rs

…

eval_order_dependence.rs

…

excessive_bools.rs

…

exit.rs

…

explicit_write.rs

…

fallible_impl_from.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

float_equality_without_abs.rs

Fix invalid paths

2020-10-27 07:43:38 +02:00

float_literal.rs

…

floating_point_arithmetic.rs

…

format.rs

Merge commit 'bf1c6f9871f430e284b17aa44059e0d0395e28a6' into clippyup

2020-10-23 22:16:59 +02:00

formatting.rs

…

functions.rs

Remove redundant expect_local() call

2020-10-25 19:30:00 +09:00

future_not_send.rs

Run cargo dev fmt

2020-10-15 22:37:53 -07:00

get_last_with_len.rs

…

identity_op.rs

…

if_let_mutex.rs

…

if_let_some_result.rs

…

if_not_else.rs

…

implicit_return.rs

…

implicit_saturating_sub.rs

…

indexing_slicing.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

infinite_iter.rs

…

inherent_impl.rs

…

inherent_to_string.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

inline_fn_without_body.rs

…

int_plus_one.rs

…

integer_division.rs

…

items_after_statements.rs

Lint items after statements in macro expansions

2020-10-14 23:49:48 -04:00

large_const_arrays.rs

…

large_enum_variant.rs

…

large_stack_arrays.rs

…

len_zero.rs

Remove empty lines in doc comment

2020-10-29 15:49:42 +01:00

let_if_seq.rs

…

let_underscore.rs

…

lib.rs

Address suggestions in PR review

2020-10-30 23:47:22 +01:00

lifetimes.rs

needless-lifetime / multiple where clause predicates regression

2020-10-20 00:42:00 +02:00

literal_representation.rs

Integrate suggestions from code review

2020-10-25 11:31:24 -04:00

loops.rs

Fix an invalid suggestion in needless_collect test

2020-10-25 23:58:14 +09:00

macro_use.rs

Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup

2020-10-09 12:45:29 +02:00

main_recursion.rs

…

manual_async_fn.rs

…

manual_non_exhaustive.rs

…

manual_strip.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

manual_unwrap_or.rs

manual-unwrap-or / pr remarks, round 3

2020-10-24 11:35:05 +02:00

map_clone.rs

…

map_err_ignore.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

map_identity.rs

…

map_unit_fn.rs

…

match_on_vec_items.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

matches.rs

improve MATCH_LIKE_MATCHES_MACRO lint

2020-10-27 23:45:58 +03:00

mem_discriminant.rs

…

mem_forget.rs

…

mem_replace.rs

…

minmax.rs

…

misc_early.rs

Remove an extra blank line in doc examples

2020-10-19 10:34:01 +09:00

misc.rs

No lint in external macro for toplevel_ref_arg

2020-10-26 10:14:03 +01:00

missing_const_for_fn.rs

Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup

2020-10-09 12:45:29 +02:00

missing_doc.rs

…

missing_inline.rs

…

modulo_arithmetic.rs

…

multiple_crate_versions.rs

…

mut_key.rs

Merge commit 'bf1c6f9871f430e284b17aa44059e0d0395e28a6' into clippyup

2020-10-23 22:16:59 +02:00

mut_mut.rs

…

mut_mutex_lock.rs

Change from correctness to style and MaybeIncorrect instead of MachineApplicable

2020-10-25 17:41:30 +08:00

mut_reference.rs

…

mutable_debug_assertion.rs

Merge commit 'bf1c6f9871f430e284b17aa44059e0d0395e28a6' into clippyup

2020-10-23 22:16:59 +02:00

mutex_atomic.rs

…

needless_arbitrary_self_type.rs

Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup

2020-10-09 12:45:29 +02:00

needless_bool.rs

No lint with cfg! and fix sugg for macro in needless_bool lint

2020-10-24 09:37:23 +02:00

needless_borrow.rs

…

needless_borrowed_ref.rs

…

needless_continue.rs

…

needless_pass_by_value.rs

…

needless_update.rs

…

neg_cmp_op_on_partial_ord.rs

…

neg_multiply.rs

…

new_without_default.rs

…

no_effect.rs

…

non_copy_const.rs

Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup

2020-10-09 12:45:29 +02:00

non_expressive_names.rs

…

open_options.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

option_env_unwrap.rs

…

option_if_let_else.rs

Merge commit 'bf1c6f9871f430e284b17aa44059e0d0395e28a6' into clippyup

2020-10-23 22:16:59 +02:00

overflow_check_conditional.rs

…

panic_in_result_fn.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

panic_unimplemented.rs

…

partialeq_ne_impl.rs

…

pass_by_ref_or_value.rs

Add large_types_passed_by_value lint

2020-10-24 14:46:56 -03:00

path_buf_push_overwrite.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

pattern_type_mismatch.rs

…

precedence.rs

…

ptr_eq.rs

Merge commit 'bf1c6f9871f430e284b17aa44059e0d0395e28a6' into clippyup

2020-10-23 22:16:59 +02:00

ptr_offset_with_cast.rs

…

ptr.rs

…

question_mark.rs

…

ranges.rs

New lint: manual-range-contains

2020-10-22 08:45:21 +02:00

redundant_clone.rs

clippy: (Body, DefId) -> Body

2020-10-04 16:07:03 -07:00

redundant_closure_call.rs

…

redundant_field_names.rs

…

redundant_pub_crate.rs

…

redundant_static_lifetimes.rs

…

reference.rs

…

regex.rs

Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup

2020-10-09 12:45:29 +02:00

repeat_once.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

returns.rs

…

self_assignment.rs

…

serde_api.rs

…

shadow.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

single_component_path_imports.rs

…

slow_vector_initialization.rs

…

stable_sort_primitive.rs

…

strings.rs

Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup

2020-10-09 12:45:29 +02:00

suspicious_trait_impl.rs

…

swap.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

tabs_in_doc_comments.rs

…

temporary_assignment.rs

…

to_digit_is_some.rs

…

to_string_in_display.rs

…

trait_bounds.rs

…

transmute.rs

Merge commit 'bf1c6f9871f430e284b17aa44059e0d0395e28a6' into clippyup

2020-10-23 22:16:59 +02:00

transmuting_null.rs

…

try_err.rs

…

types.rs

fix the error-causing suggestion of 'borrowed_box'

2020-10-27 12:11:09 +13:00

undropped_manually_drops.rs

Update tests and add known problems to docs

2020-10-21 21:21:11 -04:00

unicode.rs

Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup

2020-10-09 12:45:29 +02:00

unit_return_expecting_ord.rs

…

unnamed_address.rs

…

unnecessary_sort_by.rs

Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup

2020-10-09 12:45:29 +02:00

unnested_or_patterns.rs

…

unsafe_removed_from_name.rs

…

unused_io_amount.rs

…

unused_self.rs

…

unused_unit.rs

…

unwrap_in_result.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

unwrap.rs

…

use_self.rs

…

useless_conversion.rs

Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup

2020-09-24 14:49:22 +02:00

vec_resize_to_zero.rs

…

vec.rs

…

verbose_file_reads.rs

…

wildcard_dependencies.rs

…

wildcard_imports.rs

…

write.rs

Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup

2020-10-09 12:45:29 +02:00

zero_div_zero.rs

…