bors f5d429cd76 Auto merge of #5820 - ThibsG:FixSuspiciousArithmeticImpl, r=flip1995 ...

Fix FP for `suspicious_arithmetic_impl` from `suspicious_trait_impl` …

As discussed in #3215, the `suspicious_trait_impl` lint causes too many false positives, as it is complex to find out if binary operations are suspicious or not.

This PR restricts the number of binary operations to at most one, otherwise we don't lint.
This can be seen as very conservative, but at least FP can be reduced to bare minimum.

Fixes: #3215

changelog: limit the `suspicious_arithmetic_impl` lint to one binop, to avoid many FPs

2020-07-26 19:48:17 +00:00

..

methods

Merge remote-tracking branch 'upstream/master' into rustup

2020-07-18 15:09:58 +02:00

utils

Auto merge of #5830 - flip1995:rustup, r=flip1995

2020-07-21 22:10:04 +00:00

approx_const.rs

…

arithmetic.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

as_conversions.rs

…

assertions_on_constants.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

assign_ops.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

atomic_ordering.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

attrs.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

await_holding_lock.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

bit_mask.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

blacklisted_name.rs

…

blocks_in_if_conditions.rs

…

booleans.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

bytecount.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

cargo_common_metadata.rs

…

checked_conversions.rs

…

cognitive_complexity.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

collapsible_if.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

comparison_chain.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

consts.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

copies.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

copy_iterator.rs

…

dbg_macro.rs

…

default_trait_access.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

deprecated_lints.rs

fix typos (found by codespell)

2020-07-17 01:58:41 +02:00

dereference.rs

Merge remote-tracking branch 'upstream/master' into rustup

2020-07-18 15:09:58 +02:00

derive.rs

…

doc.rs

…

double_comparison.rs

…

double_parens.rs

…

drop_bounds.rs

…

drop_forget_ref.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

duration_subsec.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

else_if_without_else.rs

…

empty_enum.rs

…

entry.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

enum_clike.rs

…

enum_variants.rs

…

eq_op.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

erasing_op.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

escape.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

eta_reduction.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

eval_order_dependence.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

excessive_bools.rs

…

exit.rs

…

explicit_write.rs

…

fallible_impl_from.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

float_literal.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

floating_point_arithmetic.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

format.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

formatting.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

functions.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

future_not_send.rs

…

get_last_with_len.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

identity_op.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

if_let_mutex.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

if_let_some_result.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

if_not_else.rs

…

implicit_return.rs

…

implicit_saturating_sub.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

indexing_slicing.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

infinite_iter.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

inherent_impl.rs

fix typos (found by codespell)

2020-07-17 01:58:41 +02:00

inherent_to_string.rs

…

inline_fn_without_body.rs

…

int_plus_one.rs

…

integer_division.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

items_after_statements.rs

…

large_const_arrays.rs

…

large_enum_variant.rs

…

large_stack_arrays.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

len_zero.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

let_and_return.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

let_if_seq.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

let_underscore.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

lib.rs

redundant_closure_call - extract lint from misc_early.rs, adapt to LatePass

2020-07-20 00:30:43 +02:00

lifetimes.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

literal_representation.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

loops.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

macro_use.rs

…

main_recursion.rs

…

manual_async_fn.rs

…

manual_non_exhaustive.rs

…

map_clone.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

map_identity.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

map_unit_fn.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

match_on_vec_items.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

matches.rs

Auto merge of #5815 - JarredAllen:redundant_pattern_bugfix, r=flip1995

2020-07-18 14:43:36 +00:00

mem_discriminant.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

mem_forget.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

mem_replace.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

minmax.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

misc_early.rs

redundant_closure_call - extract lint from misc_early.rs, adapt to LatePass

2020-07-20 00:30:43 +02:00

misc.rs

Use (std::)f64::EPSILON in the examples as suggested in the lints

2020-07-22 05:23:55 +09:00

missing_const_for_fn.rs

fix typos (found by codespell)

2020-07-17 01:58:41 +02:00

missing_doc.rs

…

missing_inline.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

modulo_arithmetic.rs

Merge remote-tracking branch 'upstream/master' into rustup

2020-07-18 15:09:58 +02:00

multiple_crate_versions.rs

…

mut_key.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

mut_mut.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

mut_reference.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

mutable_debug_assertion.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

mutex_atomic.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

needless_bool.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

needless_borrow.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

needless_borrowed_ref.rs

…

needless_continue.rs

…

needless_pass_by_value.rs

Merge remote-tracking branch 'upstream/master' into rustup

2020-07-18 15:09:58 +02:00

needless_update.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

neg_cmp_op_on_partial_ord.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

neg_multiply.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

new_without_default.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

no_effect.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

non_copy_const.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

non_expressive_names.rs

Fix sync fallout (fmt)

2020-07-17 21:39:05 +02:00

open_options.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

option_env_unwrap.rs

…

option_if_let_else.rs

Merge remote-tracking branch 'upstream/master' into rustup

2020-07-18 15:09:58 +02:00

overflow_check_conditional.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

panic_unimplemented.rs

Clean up dogfood fallout

2020-07-16 16:58:21 -07:00

partialeq_ne_impl.rs

…

path_buf_push_overwrite.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

pattern_type_mismatch.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

precedence.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

ptr_offset_with_cast.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

ptr.rs

…

question_mark.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

ranges.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

redundant_clone.rs

Ignore not really redundant clones of ManuallyDrop

2020-07-20 00:56:27 +02:00

redundant_closure_call.rs

redundant_closure_call - pr review

2020-07-20 00:36:31 +02:00

redundant_field_names.rs

…

redundant_pub_crate.rs

…

redundant_static_lifetimes.rs

…

reference.rs

…

regex.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

repeat_once.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

returns.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

serde_api.rs

…

shadow.rs

Merge remote-tracking branch 'upstream/master' into rustup

2020-07-18 15:09:58 +02:00

single_component_path_imports.rs

…

slow_vector_initialization.rs

…

strings.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

suspicious_trait_impl.rs

Fix FP for suspicious_arithmetic_impl from suspicious_trait_impl lint

2020-07-19 00:00:17 +02:00

swap.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

tabs_in_doc_comments.rs

…

temporary_assignment.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

to_digit_is_some.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

trait_bounds.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

transmute.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

transmuting_null.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

trivially_copy_pass_by_ref.rs

…

try_err.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

types.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

unicode.rs

…

unit_return_expecting_ord.rs

Merge remote-tracking branch 'upstream/master' into rustup

2020-07-18 15:09:58 +02:00

unnamed_address.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

unnecessary_sort_by.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

unnested_or_patterns.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

unsafe_removed_from_name.rs

Avoid storing SymbolStr in a struct.

2020-07-17 08:28:22 +10:00

unused_io_amount.rs

…

unused_self.rs

…

unwrap.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

use_self.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

useless_conversion.rs

Fix FP useless_conversion

2020-07-25 23:58:22 +09:00

vec_resize_to_zero.rs

Merge remote-tracking branch 'upstream/master' into rustup

2020-07-18 15:09:58 +02:00

vec.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

verbose_file_reads.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00

wildcard_dependencies.rs

…

wildcard_imports.rs

…

write.rs

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

2020-07-14 14:59:59 +02:00

zero_div_zero.rs

Rename TypeckTables to TypeckResults.

2020-07-17 08:47:04 +00:00