73 lines
1.6 KiB
Rust
73 lines
1.6 KiB
Rust
#![warn(clippy::blocks_in_if_conditions)]
|
|
#![allow(
|
|
unused,
|
|
clippy::let_and_return,
|
|
clippy::needless_if,
|
|
clippy::unnecessary_literal_unwrap
|
|
)]
|
|
|
|
fn predicate<F: FnOnce(T) -> bool, T>(pfn: F, val: T) -> bool {
|
|
pfn(val)
|
|
}
|
|
|
|
fn pred_test() {
|
|
let v = 3;
|
|
let sky = "blue";
|
|
// This is a sneaky case, where the block isn't directly in the condition,
|
|
// but is actually inside a closure that the condition is using.
|
|
// The same principle applies -- add some extra expressions to make sure
|
|
// linter isn't confused by them.
|
|
if v == 3
|
|
&& sky == "blue"
|
|
&& predicate(
|
|
|x| {
|
|
//~^ ERROR: in an `if` condition, avoid complex blocks or closures with blocks
|
|
//~| NOTE: `-D clippy::blocks-in-if-conditions` implied by `-D warnings`
|
|
let target = 3;
|
|
x == target
|
|
},
|
|
v,
|
|
)
|
|
{}
|
|
|
|
if predicate(
|
|
|x| {
|
|
//~^ ERROR: in an `if` condition, avoid complex blocks or closures with blocks; in
|
|
let target = 3;
|
|
x == target
|
|
},
|
|
v,
|
|
) {}
|
|
}
|
|
|
|
fn closure_without_block() {
|
|
if predicate(|x| x == 3, 6) {}
|
|
}
|
|
|
|
fn macro_in_closure() {
|
|
let option = Some(true);
|
|
|
|
if option.unwrap_or_else(|| unimplemented!()) {
|
|
unimplemented!()
|
|
}
|
|
}
|
|
|
|
fn closure(_: impl FnMut()) -> bool {
|
|
true
|
|
}
|
|
|
|
fn function_with_empty_closure() {
|
|
if closure(|| {}) {}
|
|
}
|
|
|
|
#[rustfmt::skip]
|
|
fn main() {
|
|
let mut range = 0..10;
|
|
range.all(|i| {i < 10} );
|
|
|
|
let v = vec![1, 2, 3];
|
|
if v.into_iter().any(|x| {x == 4}) {
|
|
println!("contains 4!");
|
|
}
|
|
}
|