chansuke ebca1b5d00 Refactor almost_swapped to lint with let statement correctly

2023-02-13 16:16:31 +09:00

..

cargo

…

casts

Auto merge of #10038 - xFrednet:9231-sugg-try-from, r=Jarcho

2023-01-14 16:04:51 +00:00

functions

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

loops

Update clippy_lints/src/loops/needless_range_loop.rs

2023-01-30 09:59:26 -07:00

matches

Pull the is_external test out of the loop

2023-01-30 17:29:29 -07:00

methods

split suggestions into two separate suggestions

2023-02-06 21:34:35 +05:30

misc_early

…

operators

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

transmute

Merge remote-tracking branch 'upstream/master' into rustup

2023-01-27 20:26:35 +01:00

types

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

unit_types

get_parent and find_parent

2023-01-04 00:43:13 +00:00

utils

Make [clippy::dump] support trait items

2023-02-04 19:34:31 +01:00

almost_complete_range.rs

Merge commit '4bdfb0741dbcecd5279a2635c3280726db0604b5' into clippyup

2022-12-17 14:12:54 +01:00

approx_const.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

as_conversions.rs

…

asm_syntax.rs

…

assertions_on_constants.rs

…

assertions_on_result_states.rs

…

async_yields_async.rs

…

attrs.rs

Feed the features_query instead of grabbing it from the session lazily

2023-01-12 17:14:17 +00:00

await_holding_invalid.rs

…

blocks_in_if_conditions.rs

…

bool_assert_comparison.rs

Negate suggestions when needed in bool_assert_comparison

2023-02-04 19:28:11 +00:00

bool_to_int_with_if.rs

…

booleans.rs

…

borrow_deref_ref.rs

…

box_default.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

checked_conversions.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

cognitive_complexity.rs

…

collapsible_if.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

comparison_chain.rs

…

copies.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

copy_iterator.rs

…

crate_in_macro_def.rs

…

create_dir.rs

…

dbg_macro.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

declared_lints.rs

Add extra_unused_type_parameters lint

2023-02-02 19:37:34 -05:00

default_instead_of_iter_empty.rs

…

default_numeric_fallback.rs

…

default_union_representation.rs

…

default.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

deprecated_lints.rs

…

dereference.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

derivable_impls.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

derive.rs

change impl_trait_ref query to return EarlyBinder; remove bound_impl_trait_ref query; add EarlyBinder to impl_trait_ref in metadata

2023-01-14 00:29:56 -07:00

disallowed_macros.rs

Merge commit '4bdfb0741dbcecd5279a2635c3280726db0604b5' into clippyup

2022-12-17 14:12:54 +01:00

disallowed_methods.rs

…

disallowed_names.rs

…

disallowed_script_idents.rs

…

disallowed_types.rs

rustc_hir: Change representation of import paths to support multiple resolutions

2022-12-01 18:51:05 +03:00

doc.rs

Update version attribute for 1.67 lints

2023-01-19 21:58:08 +01:00

double_parens.rs

…

drop_forget_ref.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

duplicate_mod.rs

…

else_if_without_else.rs

…

empty_drop.rs

…

empty_enum.rs

…

empty_structs_with_brackets.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

entry.rs

…

enum_clike.rs

…

enum_variants.rs

Improve span for module_name_repetitions

2023-01-25 07:07:10 +01:00

equatable_if_let.rs

…

escape.rs

get_parent and find_parent

2023-01-04 00:43:13 +00:00

eta_reduction.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

excessive_bools.rs

…

exhaustive_items.rs

…

exit.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

explicit_write.rs

…

extra_unused_type_parameters.rs

Add extra_unused_type_parameters lint

2023-02-02 19:37:34 -05:00

fallible_impl_from.rs

change impl_trait_ref query to return EarlyBinder; remove bound_impl_trait_ref query; add EarlyBinder to impl_trait_ref in metadata

2023-01-14 00:29:56 -07:00

float_literal.rs

…

floating_point_arithmetic.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

fn_null_check.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

format_args.rs

Mark uninlined_format_args as pedantic

2023-01-30 19:28:27 -08:00

format_impl.rs

…

format_push_string.rs

…

format.rs

…

formatting.rs

…

from_over_into.rs

change impl_trait_ref query to return EarlyBinder; remove bound_impl_trait_ref query; add EarlyBinder to impl_trait_ref in metadata

2023-01-14 00:29:56 -07:00

from_raw_with_void_ptr.rs

Update version attribute for 1.67 lints

2023-01-19 21:58:08 +01:00

from_str_radix_10.rs

…

future_not_send.rs

fix: use LocalDefId instead of HirId in trait res

2023-01-23 11:42:18 +00:00

if_let_mutex.rs

…

if_not_else.rs

…

if_then_some_else_none.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

implicit_hasher.rs

…

implicit_return.rs

…

implicit_saturating_add.rs

Merge commit '4bdfb0741dbcecd5279a2635c3280726db0604b5' into clippyup

2022-12-17 14:12:54 +01:00

implicit_saturating_sub.rs

change impl_trait_ref query to return EarlyBinder; remove bound_impl_trait_ref query; add EarlyBinder to impl_trait_ref in metadata

2023-01-14 00:29:56 -07:00

inconsistent_struct_constructor.rs

…

index_refutable_slice.rs

rename get_parent_node to parent_id

2023-01-04 00:43:13 +00:00

indexing_slicing.rs

Merge commit '4bdfb0741dbcecd5279a2635c3280726db0604b5' into clippyup

2022-12-17 14:12:54 +01:00

infinite_iter.rs

…

inherent_impl.rs

Allow for more efficient sorting when exporting Unord collections.

2023-01-19 10:40:54 +01:00

inherent_to_string.rs

…

init_numbered_fields.rs

…

inline_fn_without_body.rs

…

instant_subtraction.rs

Update version attribute for 1.67 lints

2023-01-19 21:58:08 +01:00

int_plus_one.rs

…

invalid_upcast_comparisons.rs

…

invalid_utf8_in_unchecked.rs

Add StrStyle to ast::LitKind::ByteStr.

2022-12-02 10:38:58 +11:00

items_after_statements.rs

…

iter_not_returning_iterator.rs

…

large_const_arrays.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

large_enum_variant.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

large_include_file.rs

Add StrStyle to ast::LitKind::ByteStr.

2022-12-02 10:38:58 +11:00

large_stack_arrays.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

len_zero.rs

prevents len_without_is_empty from yielding positive when len takes

2023-01-29 17:35:36 -05:00

let_if_seq.rs

…

let_underscore.rs

Update version attribute for 1.67 lints

2023-01-19 21:58:08 +01:00

lib.deprecated.rs

…

lib.rs

Add extra_unused_type_parameters lint

2023-02-02 19:37:34 -05:00

lifetimes.rs

Add machine applicable suggestion for needless_lifetimes

2023-01-31 14:12:03 +00:00

literal_representation.rs

…

macro_use.rs

Merge remote-tracking branch 'upstream/master' into rustup

2022-12-17 13:56:32 +01:00

main_recursion.rs

…

manual_assert.rs

Don't depend on FormatArgsExpn in ManualAssert.

2023-02-01 22:50:43 +01:00

manual_async_fn.rs

Auto merge of #106266 - matthiaskrgr:rollup-cxrdbzy, r=matthiaskrgr

2022-12-29 19:40:06 +00:00

manual_bits.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

manual_clamp.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

manual_is_ascii_check.rs

Update version attribute for 1.67 lints

2023-01-19 21:58:08 +01:00

manual_let_else.rs

Merge commit '4bdfb0741dbcecd5279a2635c3280726db0604b5' into clippyup

2022-12-17 14:12:54 +01:00

manual_non_exhaustive.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

manual_rem_euclid.rs

get_parent and find_parent

2023-01-04 00:43:13 +00:00

manual_retain.rs

Merge commit '4bdfb0741dbcecd5279a2635c3280726db0604b5' into clippyup

2022-12-17 14:12:54 +01:00

manual_string_new.rs

…

manual_strip.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

map_unit_fn.rs

…

match_result_ok.rs

Apply uninlined_format-args to clippy_lints

2022-09-23 13:42:59 -04:00

mem_forget.rs

…

mem_replace.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

minmax.rs

…

misc.rs

Merge commit '4bdfb0741dbcecd5279a2635c3280726db0604b5' into clippyup

2022-12-17 14:12:54 +01:00

mismatching_type_param_order.rs

…

missing_const_for_fn.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

missing_doc.rs

change impl_trait_ref query to return EarlyBinder; remove bound_impl_trait_ref query; add EarlyBinder to impl_trait_ref in metadata

2023-01-14 00:29:56 -07:00

missing_enforced_import_rename.rs

rustc_hir: Change representation of import paths to support multiple resolutions

2022-12-01 18:51:05 +03:00

missing_inline.rs

change impl_trait_ref query to return EarlyBinder; remove bound_impl_trait_ref query; add EarlyBinder to impl_trait_ref in metadata

2023-01-14 00:29:56 -07:00

missing_trait_methods.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-01-27 20:26:35 +01:00

mixed_read_write_in_expression.rs

rename get_parent_node to parent_id

2023-01-04 00:43:13 +00:00

module_style.rs

…

multi_assignments.rs

…

multiple_unsafe_ops_per_block.rs

multiple_unsafe_ops_per_block: don't lint in external macros

2023-01-30 20:42:40 +03:00

mut_key.rs

…

mut_mut.rs

Rename Rptr to Ref in AST and HIR

2022-12-28 18:52:36 +01:00

mut_reference.rs

…

mutable_debug_assertion.rs

…

mutex_atomic.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

needless_arbitrary_self_type.rs

Rename Rptr to Ref in AST and HIR

2022-12-28 18:52:36 +01:00

needless_bool.rs

…

needless_borrowed_ref.rs

…

needless_continue.rs

…

needless_for_each.rs

…

needless_late_init.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

needless_parens_on_range_literals.rs

…

needless_pass_by_value.rs

Check ADT fields for copy implementations considering regions

2023-01-13 23:06:29 +00:00

needless_question_mark.rs

…

needless_update.rs

…

neg_cmp_op_on_partial_ord.rs

…

neg_multiply.rs

…

new_without_default.rs

…

no_effect.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

non_copy_const.rs

rename get_parent_node to parent_id

2023-01-04 00:43:13 +00:00

non_expressive_names.rs

…

non_octal_unix_permissions.rs

…

non_send_fields_in_send_ty.rs

change impl_trait_ref query to return EarlyBinder; remove bound_impl_trait_ref query; add EarlyBinder to impl_trait_ref in metadata

2023-01-14 00:29:56 -07:00

nonstandard_macro_braces.rs

…

octal_escapes.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

only_used_in_recursion.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-01-27 20:26:35 +01:00

option_env_unwrap.rs

…

option_if_let_else.rs

option_if_let_else: update known problems wording

2022-12-30 16:10:21 -05:00

overflow_check_conditional.rs

…

panic_in_result_fn.rs

…

panic_unimplemented.rs

…

partial_pub_fields.rs

…

partialeq_ne_impl.rs

…

partialeq_to_none.rs

…

pass_by_ref_or_value.rs

Use UnordMap instead of FxHashMap in define_id_collections!().

2023-01-19 10:40:47 +01:00

pattern_type_mismatch.rs

…

permissions_set_readonly_false.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

precedence.rs

…

ptr_offset_with_cast.rs

…

ptr.rs

Rename Rptr to Ref in AST and HIR

2022-12-28 18:52:36 +01:00

pub_use.rs

…

question_mark.rs

…

ranges.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

rc_clone_in_vec_init.rs

…

read_zero_byte_vec.rs

…

redundant_clone.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

redundant_closure_call.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

redundant_else.rs

…

redundant_field_names.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

redundant_pub_crate.rs

Merge commit '4bdfb0741dbcecd5279a2635c3280726db0604b5' into clippyup

2022-12-17 14:12:54 +01:00

redundant_slicing.rs

…

redundant_static_lifetimes.rs

Rename Rptr to Ref in AST and HIR

2022-12-28 18:52:36 +01:00

ref_option_ref.rs

Rename Rptr to Ref in AST and HIR

2022-12-28 18:52:36 +01:00

reference.rs

…

regex.rs

invalid_regex: Show full error when string value doesn't match source

2023-01-26 15:33:40 +00:00

renamed_lints.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

return_self_not_must_use.rs

…

returns.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

same_name_method.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

self_named_constructors.rs

…

semicolon_block.rs

Fix version declared for semicolon_inside_block and semicolon_outside_block

2023-01-30 10:01:38 +01:00

semicolon_if_nothing_returned.rs

…

serde_api.rs

…

shadow.rs

…

single_char_lifetime_names.rs

…

single_component_path_imports.rs

rustc_ast_lowering: Stop lowering imports into multiple items

2022-12-01 18:51:20 +03:00

size_of_in_element_count.rs

…

size_of_ref.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

slow_vector_initialization.rs

…

std_instead_of_core.rs

…

strings.rs

Merge commit '4bdfb0741dbcecd5279a2635c3280726db0604b5' into clippyup

2022-12-17 14:12:54 +01:00

strlen_on_c_strings.rs

…

suspicious_operation_groupings.rs

Fix clippy code

2022-11-23 12:17:47 -08:00

suspicious_trait_impl.rs

…

suspicious_xor_used_as_pow.rs

Fix docs for suspicious_xor_used_as_pow lint

2023-01-26 16:52:39 -08:00

swap_ptr_to_ref.rs

…

swap.rs

Refactor almost_swapped to lint with let statement correctly

2023-02-13 16:16:31 +09:00

tabs_in_doc_comments.rs

…

temporary_assignment.rs

…

to_digit_is_some.rs

…

trailing_empty_array.rs

…

trait_bounds.rs

…

undocumented_unsafe_blocks.rs

Fix fp in unnecessary_safety_comment

2023-01-09 18:49:46 +09:00

unicode.rs

…

uninit_vec.rs

use is_integer_literal more

2022-10-01 17:55:22 +02:00

unit_return_expecting_ord.rs

Introduce PredicateKind::Clause

2022-11-25 00:04:54 -03:00

unnamed_address.rs

…

unnecessary_owned_empty_strings.rs

…

unnecessary_self_imports.rs

rustc_ast_lowering: Stop lowering imports into multiple items

2022-12-01 18:51:20 +03:00

unnecessary_wraps.rs

get_parent and find_parent

2023-01-04 00:43:13 +00:00

unnested_or_patterns.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

unsafe_removed_from_name.rs

rustc_ast_lowering: Stop lowering imports into multiple items

2022-12-01 18:51:20 +03:00

unused_async.rs

…

unused_io_amount.rs

Lint unused_io_amount with is_ok and is_err

2023-01-24 18:22:35 -05:00

unused_peekable.rs

…

unused_rounding.rs

Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup

2022-12-01 18:29:38 +01:00

unused_self.rs

Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup

2023-01-12 19:48:13 +01:00

unused_unit.rs

…

unwrap_in_result.rs

…

unwrap.rs

…

upper_case_acronyms.rs

…

use_self.rs

change impl_trait_ref query to return EarlyBinder; remove bound_impl_trait_ref query; add EarlyBinder to impl_trait_ref in metadata

2023-01-14 00:29:56 -07:00

useless_conversion.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

vec_init_then_push.rs

…

vec.rs

…

wildcard_imports.rs

rustc_hir: Change representation of import paths to support multiple resolutions

2022-12-01 18:51:05 +03:00

write.rs

Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup

2022-12-29 14:28:34 +01:00

zero_div_zero.rs

…

zero_sized_map_values.rs

…