73 lines
2.1 KiB
Rust
73 lines
2.1 KiB
Rust
//@no-rustfix: overlapping suggestions
|
|
//@compile-flags: -Zdeduplicate-diagnostics=yes
|
|
|
|
#![allow(clippy::uninlined_format_args)]
|
|
|
|
#[allow(unused_assignments)]
|
|
#[warn(clippy::misrefactored_assign_op, clippy::assign_op_pattern)]
|
|
fn main() {
|
|
let mut a = 5;
|
|
a += a + 1;
|
|
//~^ ERROR: variable appears on both sides of an assignment operation
|
|
//~| NOTE: `-D clippy::misrefactored-assign-op` implied by `-D warnings`
|
|
a += 1 + a;
|
|
//~^ ERROR: variable appears on both sides of an assignment operation
|
|
a -= a - 1;
|
|
//~^ ERROR: variable appears on both sides of an assignment operation
|
|
a *= a * 99;
|
|
//~^ ERROR: variable appears on both sides of an assignment operation
|
|
a *= 42 * a;
|
|
//~^ ERROR: variable appears on both sides of an assignment operation
|
|
a /= a / 2;
|
|
//~^ ERROR: variable appears on both sides of an assignment operation
|
|
a %= a % 5;
|
|
//~^ ERROR: variable appears on both sides of an assignment operation
|
|
a &= a & 1;
|
|
//~^ ERROR: variable appears on both sides of an assignment operation
|
|
a *= a * a;
|
|
//~^ ERROR: variable appears on both sides of an assignment operation
|
|
a = a * a * a;
|
|
a = a * 42 * a;
|
|
a = a * 2 + a;
|
|
a -= 1 - a;
|
|
a /= 5 / a;
|
|
a %= 42 % a;
|
|
a <<= 6 << a;
|
|
}
|
|
|
|
// check that we don't lint on op assign impls, because that's just the way to impl them
|
|
|
|
use std::ops::{Mul, MulAssign};
|
|
|
|
#[derive(Copy, Clone, Debug, PartialEq, Eq)]
|
|
pub struct Wrap(i64);
|
|
|
|
impl Mul<i64> for Wrap {
|
|
type Output = Self;
|
|
|
|
fn mul(self, rhs: i64) -> Self {
|
|
Wrap(self.0 * rhs)
|
|
}
|
|
}
|
|
|
|
impl MulAssign<i64> for Wrap {
|
|
fn mul_assign(&mut self, rhs: i64) {
|
|
*self = *self * rhs
|
|
}
|
|
}
|
|
|
|
fn cow_add_assign() {
|
|
use std::borrow::Cow;
|
|
let mut buf = Cow::Owned(String::from("bar"));
|
|
let cows = Cow::Borrowed("foo");
|
|
|
|
// this can be linted
|
|
buf = buf + cows.clone();
|
|
//~^ ERROR: manual implementation of an assign operation
|
|
//~| NOTE: `-D clippy::assign-op-pattern` implied by `-D warnings`
|
|
|
|
// this should not as cow<str> Add is not commutative
|
|
buf = cows + buf;
|
|
println!("{}", buf);
|
|
}
|