153 lines
2.7 KiB
Rust
153 lines
2.7 KiB
Rust
//@run-rustfix
|
|
|
|
#![warn(clippy::use_self)]
|
|
#![allow(dead_code)]
|
|
#![allow(clippy::should_implement_trait, clippy::boxed_local)]
|
|
|
|
use std::ops::Mul;
|
|
|
|
trait SelfTrait {
|
|
fn refs(p1: &Self) -> &Self;
|
|
fn ref_refs<'a>(p1: &'a &'a Self) -> &'a &'a Self;
|
|
fn mut_refs(p1: &mut Self) -> &mut Self;
|
|
fn nested(p1: Box<Self>, p2: (&u8, &Self));
|
|
fn vals(r: Self) -> Self;
|
|
}
|
|
|
|
#[derive(Default)]
|
|
struct Bad;
|
|
|
|
impl SelfTrait for Bad {
|
|
fn refs(p1: &Self) -> &Self {
|
|
p1
|
|
}
|
|
|
|
fn ref_refs<'a>(p1: &'a &'a Self) -> &'a &'a Self {
|
|
p1
|
|
}
|
|
|
|
fn mut_refs(p1: &mut Self) -> &mut Self {
|
|
p1
|
|
}
|
|
|
|
fn nested(_p1: Box<Self>, _p2: (&u8, &Self)) {}
|
|
|
|
fn vals(_: Self) -> Self {
|
|
Self::default()
|
|
}
|
|
}
|
|
|
|
impl Mul for Bad {
|
|
type Output = Self;
|
|
|
|
fn mul(self, rhs: Self) -> Self {
|
|
rhs
|
|
}
|
|
}
|
|
|
|
impl Clone for Bad {
|
|
fn clone(&self) -> Self {
|
|
Self
|
|
}
|
|
}
|
|
|
|
#[derive(Default)]
|
|
struct Good;
|
|
|
|
impl SelfTrait for Good {
|
|
fn refs(p1: &Self) -> &Self {
|
|
p1
|
|
}
|
|
|
|
fn ref_refs<'a>(p1: &'a &'a Self) -> &'a &'a Self {
|
|
p1
|
|
}
|
|
|
|
fn mut_refs(p1: &mut Self) -> &mut Self {
|
|
p1
|
|
}
|
|
|
|
fn nested(_p1: Box<Self>, _p2: (&u8, &Self)) {}
|
|
|
|
fn vals(_: Self) -> Self {
|
|
Self::default()
|
|
}
|
|
}
|
|
|
|
impl Mul for Good {
|
|
type Output = Self;
|
|
|
|
fn mul(self, rhs: Self) -> Self {
|
|
rhs
|
|
}
|
|
}
|
|
|
|
trait NameTrait {
|
|
fn refs(p1: &u8) -> &u8;
|
|
fn ref_refs<'a>(p1: &'a &'a u8) -> &'a &'a u8;
|
|
fn mut_refs(p1: &mut u8) -> &mut u8;
|
|
fn nested(p1: Box<u8>, p2: (&u8, &u8));
|
|
fn vals(p1: u8) -> u8;
|
|
}
|
|
|
|
// Using `Self` instead of the type name is OK
|
|
impl NameTrait for u8 {
|
|
fn refs(p1: &Self) -> &Self {
|
|
p1
|
|
}
|
|
|
|
fn ref_refs<'a>(p1: &'a &'a Self) -> &'a &'a Self {
|
|
p1
|
|
}
|
|
|
|
fn mut_refs(p1: &mut Self) -> &mut Self {
|
|
p1
|
|
}
|
|
|
|
fn nested(_p1: Box<Self>, _p2: (&Self, &Self)) {}
|
|
|
|
fn vals(_: Self) -> Self {
|
|
Self::default()
|
|
}
|
|
}
|
|
|
|
mod impl_in_macro {
|
|
macro_rules! parse_ip_impl {
|
|
// minimized from serde=1.0.118
|
|
($ty:ty) => {
|
|
impl FooTrait for $ty {
|
|
fn new() -> Self {
|
|
<$ty>::bar()
|
|
}
|
|
}
|
|
};
|
|
}
|
|
|
|
struct Foo;
|
|
|
|
trait FooTrait {
|
|
fn new() -> Self;
|
|
}
|
|
|
|
impl Foo {
|
|
fn bar() -> Self {
|
|
Self
|
|
}
|
|
}
|
|
parse_ip_impl!(Foo); // Should not lint
|
|
}
|
|
|
|
mod full_path_replacement {
|
|
trait Error {
|
|
fn custom<T: std::fmt::Display>(_msg: T) -> Self;
|
|
}
|
|
|
|
impl Error for std::fmt::Error {
|
|
fn custom<T: std::fmt::Display>(_msg: T) -> Self {
|
|
Self // Should lint
|
|
}
|
|
}
|
|
}
|
|
|
|
fn main() {}
|