e683e3eeac
There are cases where users create a unit variant for the purposes of tracking the number of variants for an nonexhaustive enum. We should check if an enum is explicitly marked as nonexhaustive before reporting `manual_non_exhaustive` in these cases. Fixes #11583
89 lines
1.4 KiB
Rust
89 lines
1.4 KiB
Rust
#![feature(lint_reasons)]
|
|
#![warn(clippy::manual_non_exhaustive)]
|
|
#![allow(unused)]
|
|
//@no-rustfix
|
|
enum E {
|
|
//~^ ERROR: this seems like a manual implementation of the non-exhaustive pattern
|
|
A,
|
|
B,
|
|
#[doc(hidden)]
|
|
_C,
|
|
}
|
|
|
|
// if the user explicitly marks as nonexhaustive we shouldn't warn them
|
|
#[non_exhaustive]
|
|
enum Ep {
|
|
A,
|
|
B,
|
|
#[doc(hidden)]
|
|
_C,
|
|
}
|
|
|
|
// marker variant does not have doc hidden attribute, should be ignored
|
|
enum NoDocHidden {
|
|
A,
|
|
B,
|
|
_C,
|
|
}
|
|
|
|
// name of variant with doc hidden does not start with underscore, should be ignored
|
|
enum NoUnderscore {
|
|
A,
|
|
B,
|
|
#[doc(hidden)]
|
|
C,
|
|
}
|
|
|
|
// variant with doc hidden is not unit, should be ignored
|
|
enum NotUnit {
|
|
A,
|
|
B,
|
|
#[doc(hidden)]
|
|
_C(bool),
|
|
}
|
|
|
|
// variant with doc hidden is the only one, should be ignored
|
|
enum OnlyMarker {
|
|
#[doc(hidden)]
|
|
_A,
|
|
}
|
|
|
|
// variant with multiple markers, should be ignored
|
|
enum MultipleMarkers {
|
|
A,
|
|
#[doc(hidden)]
|
|
_B,
|
|
#[doc(hidden)]
|
|
_C,
|
|
}
|
|
|
|
// already non_exhaustive and no markers, should be ignored
|
|
#[non_exhaustive]
|
|
enum NonExhaustive {
|
|
A,
|
|
B,
|
|
}
|
|
|
|
// marked is used, don't lint
|
|
enum UsedHidden {
|
|
#[doc(hidden)]
|
|
_A,
|
|
B,
|
|
C,
|
|
}
|
|
fn foo(x: &mut UsedHidden) {
|
|
if matches!(*x, UsedHidden::B) {
|
|
*x = UsedHidden::_A;
|
|
}
|
|
}
|
|
|
|
#[expect(clippy::manual_non_exhaustive)]
|
|
enum ExpectLint {
|
|
A,
|
|
B,
|
|
#[doc(hidden)]
|
|
_C,
|
|
}
|
|
|
|
fn main() {}
|