rust/crates
bors e4ead8a7c6 Auto merge of #12412 - yue4u:fix/visibility-completion, r=Veykril
fix: Retrigger visibility completion after parentheses

close #12390

This PR add `(` to trigger_characters as discussed in original issue.

Some questions:

1. Is lsp's `ctx.trigger_character` from `params.context` is the same as `ctx.original_token` inside actually completions?
    1. If not what's the difference?
    2. if they are the same, it's unnecessary to pass it down from handler at all.
    3.  if they are the same, maybe we could parse it from fixture directly instead of using the `check_with_trigger_character` I added.
2. Some completion fixtures written as `($0)` ( https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-completion/src/tests/fn_param.rs#L105 as an example), If I understand correctly they are not invoked outside tests at all?
    1. using `ctx.original_token` directly would break these tests as well as parsing trigger_character from fixture for now.
    2. I think it make sense to allow `(` triggering these cases?
3. I hope this line up with #12144
2022-05-30 11:22:10 +00:00
..
base-db minor: Simplify 2022-05-20 16:52:10 +02:00
cfg minor: Bump dependencies 2022-03-22 17:42:24 +01:00
flycheck internal: Show more project building errors to the user 2022-04-14 11:31:01 +02:00
hir fix: When reference searching macro inputs, don't search everything that was downmapped 2022-05-23 16:09:56 +02:00
hir-def Auto merge of #12395 - feniljain:fix_bugs, r=Veykril 2022-05-27 12:44:08 +00:00
hir-expand minor: Simplify 2022-05-20 16:52:10 +02:00
hir-ty fix overflow during tuple struct type inference 2022-05-29 16:22:33 +09:00
ide fix: visibility completion 2022-05-30 00:06:48 +09:00
ide-assists Make test pass 2022-05-25 18:31:08 +02:00
ide-completion fix: visibility completion 2022-05-30 00:06:48 +09:00
ide-db fix: Insert whitespace into trait-impl completions when coming from macros 2022-05-24 22:56:33 +02:00
ide-diagnostics Auto merge of #12010 - Veykril:r-a-config, r=Veykril 2022-05-10 12:07:24 +00:00
ide-ssr internal: Remove unqualified_path completions module 2022-05-05 22:21:42 +02:00
limit
mbe Revert "Auto merge of #12149 - jonas-schievink:literally-just-a-literal, r=jonas-schievink" 2022-05-13 15:08:14 +02:00
parser Revert "Auto merge of #12149 - jonas-schievink:literally-just-a-literal, r=jonas-schievink" 2022-05-13 15:08:14 +02:00
paths
proc-macro-api style: rename crates to kebab case 2022-05-01 10:48:58 +00:00
proc-macro-srv style: rename crates to kebab case 2022-05-01 10:48:58 +00:00
proc-macro-test delete a generated swap file 2022-05-01 10:48:58 +00:00
profile internal: vendor lsp-server 2022-05-14 21:15:43 +01:00
project-model minor: log build script invocations 2022-05-24 22:56:49 +02:00
rust-analyzer fix: visibility completion 2022-05-30 00:06:48 +09:00
sourcegen Bump xshell and fix dist 2022-03-17 08:53:33 +02:00
stdx minor: Bump dependencies 2022-03-22 17:42:24 +01:00
syntax fix: f32 and f64 representation during lowering 2022-05-26 20:03:05 +05:30
test-utils style: rename crates to kebab case 2022-05-01 10:48:58 +00:00
text-edit style: rename crates to kebab case 2022-05-01 10:48:58 +00:00
toolchain
tt minor: Bump dependencies 2022-03-22 17:42:24 +01:00
vfs minor: Bump dependencies 2022-03-22 17:42:24 +01:00
vfs-notify Fix build on OpenBSD (and probably other BSDs too) 2022-05-22 17:04:57 -04:00