d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
56 lines
1.9 KiB
Rust
56 lines
1.9 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_help;
|
|
use clippy_utils::ty::is_type_lang_item;
|
|
use clippy_utils::{match_function_call, paths};
|
|
use rustc_hir::{lang_items, Expr};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Prevents the safe `std::mem::drop` function from being called on `std::mem::ManuallyDrop`.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// The safe `drop` function does not drop the inner value of a `ManuallyDrop`.
|
|
///
|
|
/// ### Known problems
|
|
/// Does not catch cases if the user binds `std::mem::drop`
|
|
/// to a different name and calls it that way.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// struct S;
|
|
/// drop(std::mem::ManuallyDrop::new(S));
|
|
/// ```
|
|
/// Use instead:
|
|
/// ```rust
|
|
/// struct S;
|
|
/// unsafe {
|
|
/// std::mem::ManuallyDrop::drop(&mut std::mem::ManuallyDrop::new(S));
|
|
/// }
|
|
/// ```
|
|
#[clippy::version = "1.49.0"]
|
|
pub UNDROPPED_MANUALLY_DROPS,
|
|
correctness,
|
|
"use of safe `std::mem::drop` function to drop a std::mem::ManuallyDrop, which will not drop the inner value"
|
|
}
|
|
|
|
declare_lint_pass!(UndroppedManuallyDrops => [UNDROPPED_MANUALLY_DROPS]);
|
|
|
|
impl LateLintPass<'tcx> for UndroppedManuallyDrops {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
|
|
if let Some([arg_0, ..]) = match_function_call(cx, expr, &paths::DROP) {
|
|
let ty = cx.typeck_results().expr_ty(arg_0);
|
|
if is_type_lang_item(cx, ty, lang_items::LangItem::ManuallyDrop) {
|
|
span_lint_and_help(
|
|
cx,
|
|
UNDROPPED_MANUALLY_DROPS,
|
|
expr.span,
|
|
"the inner value of this ManuallyDrop will not be dropped",
|
|
None,
|
|
"to drop a `ManuallyDrop<T>`, use std::mem::ManuallyDrop::drop",
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|