4eff60ad6e
stacked_borrow now has an item module, and its own FrameExtra. These serve to protect the implementation of Item (which is a bunch of bit-packing tricks) from the primary logic of Stacked Borrows, and the FrameExtra we have separates Stacked Borrows more cleanly from the interpreter itself. The new strategy for checking protectors also makes some subtle performance tradeoffs, so they are now documented in Stack::item_popped because that function primarily benefits from them, and it also touches every aspect of them. Also separating the actual CallId that is protecting a Tag from the Tag makes it inconvienent to reproduce exactly the same protector errors, so this also takes the opportunity to use some slightly cleaner English in those errors. We need to make some change, might as well make it good.
39 lines
2.2 KiB
Plaintext
39 lines
2.2 KiB
Plaintext
error: Undefined Behavior: deallocating while item [SharedReadWrite for <TAG>] is protected by call ID
|
|
--> RUSTLIB/alloc/src/alloc.rs:LL:CC
|
|
|
|
|
LL | unsafe { __rust_dealloc(ptr, layout.size(), layout.align()) }
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ deallocating while item [SharedReadWrite for <TAG>] is protected by call ID
|
|
|
|
|
= help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental
|
|
= help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information
|
|
= note: backtrace:
|
|
= note: inside `std::alloc::dealloc` at RUSTLIB/alloc/src/alloc.rs:LL:CC
|
|
= note: inside `<std::alloc::Global as std::alloc::Allocator>::deallocate` at RUSTLIB/alloc/src/alloc.rs:LL:CC
|
|
= note: inside `alloc::alloc::box_free::<NotUnpin, std::alloc::Global>` at RUSTLIB/alloc/src/alloc.rs:LL:CC
|
|
= note: inside `std::ptr::drop_in_place::<std::boxed::Box<NotUnpin>> - shim(Some(std::boxed::Box<NotUnpin>))` at RUSTLIB/core/src/ptr/mod.rs:LL:CC
|
|
= note: inside `std::mem::drop::<std::boxed::Box<NotUnpin>>` at RUSTLIB/core/src/mem/mod.rs:LL:CC
|
|
note: inside closure at $DIR/deallocate_against_barrier2.rs:LL:CC
|
|
--> $DIR/deallocate_against_barrier2.rs:LL:CC
|
|
|
|
|
LL | drop(unsafe { Box::from_raw(raw) });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
= note: inside `<[closure@$DIR/deallocate_against_barrier2.rs:LL:CC] as std::ops::FnOnce<(&mut NotUnpin,)>>::call_once - shim` at RUSTLIB/core/src/ops/function.rs:LL:CC
|
|
note: inside `inner` at $DIR/deallocate_against_barrier2.rs:LL:CC
|
|
--> $DIR/deallocate_against_barrier2.rs:LL:CC
|
|
|
|
|
LL | f(x)
|
|
| ^^^^
|
|
note: inside `main` at $DIR/deallocate_against_barrier2.rs:LL:CC
|
|
--> $DIR/deallocate_against_barrier2.rs:LL:CC
|
|
|
|
|
LL | / inner(Box::leak(Box::new(NotUnpin(0, PhantomPinned))), |x| {
|
|
LL | | let raw = x as *mut _;
|
|
LL | | drop(unsafe { Box::from_raw(raw) });
|
|
LL | | });
|
|
| |______^
|
|
|
|
note: some details are omitted, run with `MIRIFLAGS=-Zmiri-backtrace=full` for a verbose backtrace
|
|
|
|
error: aborting due to previous error
|
|
|