mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
d5366b5c19
rust/crates
History
bors d5366b5c19 Auto merge of #16265 - Patryk27:suggest-pub-crate-imports, r=Veykril 
fix: Acknowledge `pub(crate)` imports in import suggestions

rust-analyzer has logic that discounts suggesting `use`s for private imports, but that logic is unnecessarily strict - for instance given this code:

```rust
mod foo {
    pub struct Foo;
}

pub(crate) use self::foo::*;

mod bar {
    fn main() {
        Foo$0;
    }
}
```

... RA will suggest to add `use crate::foo::Foo;`, which not only makes the code overly verbose (especially in larger code bases), but also is disjoint with what rustc itself suggests.

This commit adjusts the logic, so that `pub(crate)` imports are taken into account when generating the suggestions; considering rustc's behavior, I think this change doesn't warrant any extra configuration flag.

Note that this is my first commit to RA, so I guess the approach taken here might be suboptimal - certainly feels somewhat hacky, maybe there's some better way of finding out the optimal import path 😅
2024-01-11 09:54:22 +00:00
..
base-db Replace SourceRootCrates hashset output with slice for deterministic order 2024-01-10 14:51:51 +01:00
cfg Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2 2024-01-03 11:35:07 +02:00
flycheck Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2 2024-01-03 11:35:07 +02:00
hir Replace SourceRootCrates hashset output with slice for deterministic order 2024-01-10 14:51:51 +01:00
hir-def Auto merge of #16265 - Patryk27:suggest-pub-crate-imports, r=Veykril 2024-01-11 09:54:22 +00:00
hir-expand Auto merge of #16265 - Patryk27:suggest-pub-crate-imports, r=Veykril 2024-01-11 09:54:22 +00:00
hir-ty Auto merge of #16265 - Patryk27:suggest-pub-crate-imports, r=Veykril 2024-01-11 09:54:22 +00:00
ide Some minor perf improvements 2024-01-09 20:43:17 +01:00
ide-assists Auto merge of #16265 - Patryk27:suggest-pub-crate-imports, r=Veykril 2024-01-11 09:54:22 +00:00
ide-completion add tests to verify relevance of notable traits and some refactors 2024-01-10 16:30:22 +05:30
ide-db Auto merge of #16265 - Patryk27:suggest-pub-crate-imports, r=Veykril 2024-01-11 09:54:22 +00:00
ide-diagnostics Set experimental field at diagnostic new instead of lib 2024-01-10 05:58:25 -06:00
ide-ssr Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2 2024-01-03 11:35:07 +02:00
intern Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2 2024-01-03 11:35:07 +02:00
limit Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2 2024-01-03 11:35:07 +02:00
load-cargo fix: Differentiate between vfs config load and file changed events 2024-01-09 10:30:16 +01:00
mbe Set the in-rust-tree` feature for all rust-analyzer{-proc-macro-srv} steps 2024-01-04 11:02:20 +01:00
parser Auto merge of #16310 - Veykril:range-access-parse, r=Veykril 2024-01-09 09:49:25 +00:00
paths Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2 2024-01-03 11:35:07 +02:00
proc-macro-api Auto merge of #16312 - Veykril:win-proc-macro-srv, r=Veykril 2024-01-09 10:12:57 +00:00
proc-macro-srv Remove sysroot-abi feature flag from proc-macro-test 2024-01-10 09:53:12 +01:00
proc-macro-srv-cli Recognize proc macro server unexpectedly exiting and report the exit code 2024-01-09 10:37:26 +01:00
profile Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2 2024-01-03 11:35:07 +02:00
project-model fix: Differentiate between vfs config load and file changed events 2024-01-09 10:30:16 +01:00
rust-analyzer Auto merge of #16319 - Veykril:no-double-load, r=Veykril 2024-01-09 10:24:23 +00:00
sourcegen Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2 2024-01-03 11:35:07 +02:00
span Merge commit 'af40101841c45aa75b56f4e9ca745369da8fb4ba' into sync-from-ra 2024-01-08 11:29:25 +02:00
stdx Merge commit 'af40101841c45aa75b56f4e9ca745369da8fb4ba' into sync-from-ra 2024-01-08 11:29:25 +02:00
syntax Auto merge of #16275 - davidsemakula:ast-path-segments, r=Veykril 2024-01-09 15:41:48 +00:00
test-fixture Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2 2024-01-03 11:35:07 +02:00
test-utils Builtin derives are hygienic 2024-01-08 12:50:11 +01:00
text-edit Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2 2024-01-03 11:35:07 +02:00
toolchain Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2 2024-01-03 11:35:07 +02:00
tt Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2 2024-01-03 11:35:07 +02:00
vfs fix: Differentiate between vfs config load and file changed events 2024-01-09 10:30:16 +01:00
vfs-notify fix: Differentiate between vfs config load and file changed events 2024-01-09 10:30:16 +01:00