Remove `__rust_force_expr`. This was added (with a different name) to improve an error message. It is no longer needed -- removing it changes the error message, but overall I think the new message is no worse: - the mention of `#` in the first line is a little worse, - but the extra context makes it very clear what the problem is, perhaps even clearer than the old message, - and the removal of the note about the `expr` fragment (an internal detail of `__rust_force_expr`) is an improvement. Overall I think the error is quite clear and still far better than the old message that prompted #61933, which didn't even mention patterns. The motivation for this is #124141, which will cause pasted metavariables to be tokenized and reparsed instead of the AST node being cached. This change in behaviour occasionally has a non-zero perf cost, and `__rust_force_expr` causes the tokenize/reparse step to occur twice. Removing `__rust_force_expr` greatly reduces the extra overhead for the `deep-vector` benchmark. r? ```@oli-obk```
UI Tests
This folder contains rustc
's
UI tests.
Test Directives (Headers)
Typically, a UI test will have some test directives / headers which are special comments that tell compiletest how to build and intepret a test.
As part of an on-going effort to rewrite compiletest
(see https://github.com/rust-lang/compiler-team/issues/536), a major
change proposal to change legacy compiletest-style headers // <directive>
to ui_test
-style headers
//@ <directive>
was accepted (see
https://github.com/rust-lang/compiler-team/issues/512.
An example directive is ignore-test
. In legacy compiletest style, the header
would be written as
// ignore-test
but in ui_test
style, the header would be written as
//@ ignore-test
compiletest is changed to accept only //@
directives for UI tests
(currently), and will reject and report an error if it encounters any
comments // <content>
that may be parsed as an legacy compiletest-style
test header. To fix this, you should migrate to the ui_test
-style header
//@ <content>
.