07e7823c01
If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
53 lines
1.5 KiB
Rust
53 lines
1.5 KiB
Rust
// Private types and traits are not allowed in interfaces of associated types.
|
|
// This test also ensures that the checks are performed even inside private modules.
|
|
|
|
#![feature(associated_type_defaults)]
|
|
#![feature(type_alias_impl_trait)]
|
|
|
|
mod m {
|
|
struct Priv;
|
|
trait PrivTr {}
|
|
impl PrivTr for Priv {}
|
|
pub trait PubTrAux1<T> {}
|
|
pub trait PubTrAux2 {
|
|
type A;
|
|
}
|
|
impl<T> PubTrAux1<T> for u8 {}
|
|
impl PubTrAux2 for u8 {
|
|
type A = Priv;
|
|
//~^ ERROR private type `Priv` in public interface
|
|
}
|
|
|
|
// "Private-in-public in associated types is hard error" in RFC 2145
|
|
// applies only to the aliased types, not bounds.
|
|
pub trait PubTr {
|
|
//~^ WARN private trait `PrivTr` in public interface
|
|
//~| WARN this was previously accepted
|
|
//~| WARN private type `Priv` in public interface
|
|
//~| WARN private type `Priv` in public interface
|
|
//~| WARN this was previously accepted
|
|
//~| WARN this was previously accepted
|
|
type Alias1: PrivTr;
|
|
type Alias2: PubTrAux1<Priv> = u8;
|
|
type Alias3: PubTrAux2<A = Priv> = u8;
|
|
|
|
type Alias4 = Priv;
|
|
//~^ ERROR private type `Priv` in public interface
|
|
|
|
type Exist;
|
|
fn infer_exist() -> Self::Exist;
|
|
}
|
|
impl PubTr for u8 {
|
|
type Alias1 = Priv;
|
|
//~^ ERROR private type `Priv` in public interface
|
|
|
|
type Exist = impl PrivTr;
|
|
//~^ ERROR private trait `PrivTr` in public interface
|
|
fn infer_exist() -> Self::Exist {
|
|
Priv
|
|
}
|
|
}
|
|
}
|
|
|
|
fn main() {}
|