d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
67 lines
2.3 KiB
Rust
67 lines
2.3 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_help;
|
|
use rustc_ast::ast::{Expr, ExprKind};
|
|
use rustc_lint::{EarlyContext, EarlyLintPass};
|
|
use rustc_middle::lint::in_external_macro;
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for usage of `as` conversions.
|
|
///
|
|
/// Note that this lint is specialized in linting *every single* use of `as`
|
|
/// regardless of whether good alternatives exist or not.
|
|
/// If you want more precise lints for `as`, please consider using these separate lints:
|
|
/// `unnecessary_cast`, `cast_lossless/possible_truncation/possible_wrap/precision_loss/sign_loss`,
|
|
/// `fn_to_numeric_cast(_with_truncation)`, `char_lit_as_u8`, `ref_to_mut` and `ptr_as_ptr`.
|
|
/// There is a good explanation the reason why this lint should work in this way and how it is useful
|
|
/// [in this issue](https://github.com/rust-lang/rust-clippy/issues/5122).
|
|
///
|
|
/// ### Why is this bad?
|
|
/// `as` conversions will perform many kinds of
|
|
/// conversions, including silently lossy conversions and dangerous coercions.
|
|
/// There are cases when it makes sense to use `as`, so the lint is
|
|
/// Allow by default.
|
|
///
|
|
/// ### Example
|
|
/// ```rust,ignore
|
|
/// let a: u32;
|
|
/// ...
|
|
/// f(a as u16);
|
|
/// ```
|
|
///
|
|
/// Usually better represents the semantics you expect:
|
|
/// ```rust,ignore
|
|
/// f(a.try_into()?);
|
|
/// ```
|
|
/// or
|
|
/// ```rust,ignore
|
|
/// f(a.try_into().expect("Unexpected u16 overflow in f"));
|
|
/// ```
|
|
///
|
|
#[clippy::version = "1.41.0"]
|
|
pub AS_CONVERSIONS,
|
|
restriction,
|
|
"using a potentially dangerous silent `as` conversion"
|
|
}
|
|
|
|
declare_lint_pass!(AsConversions => [AS_CONVERSIONS]);
|
|
|
|
impl EarlyLintPass for AsConversions {
|
|
fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) {
|
|
if in_external_macro(cx.sess, expr.span) {
|
|
return;
|
|
}
|
|
|
|
if let ExprKind::Cast(_, _) = expr.kind {
|
|
span_lint_and_help(
|
|
cx,
|
|
AS_CONVERSIONS,
|
|
expr.span,
|
|
"using a potentially dangerous silent `as` conversion",
|
|
None,
|
|
"consider using a safe wrapper for this conversion",
|
|
);
|
|
}
|
|
}
|
|
}
|