53 lines
1.9 KiB
Rust
53 lines
1.9 KiB
Rust
#![allow(unused_must_use)]
|
|
#![warn(clippy::nonsensical_open_options)]
|
|
|
|
use std::fs::OpenOptions;
|
|
|
|
trait OpenOptionsExt {
|
|
fn truncate_write(&mut self, opt: bool) -> &mut Self;
|
|
}
|
|
|
|
impl OpenOptionsExt for OpenOptions {
|
|
fn truncate_write(&mut self, opt: bool) -> &mut Self {
|
|
self.truncate(opt).write(opt)
|
|
}
|
|
}
|
|
|
|
fn main() {
|
|
OpenOptions::new().read(true).truncate(true).open("foo.txt");
|
|
//~^ ERROR: file opened with `truncate` and `read`
|
|
//~| NOTE: `-D clippy::nonsensical-open-options` implied by `-D warnings`
|
|
OpenOptions::new().append(true).truncate(true).open("foo.txt");
|
|
//~^ ERROR: file opened with `append` and `truncate`
|
|
|
|
OpenOptions::new().read(true).read(false).open("foo.txt");
|
|
//~^ ERROR: the method `read` is called more than once
|
|
OpenOptions::new()
|
|
.create(true)
|
|
.truncate(true) // Ensure we don't trigger suspicious open options by having create without truncate
|
|
.create(false)
|
|
//~^ ERROR: the method `create` is called more than once
|
|
.open("foo.txt");
|
|
OpenOptions::new().write(true).write(false).open("foo.txt");
|
|
//~^ ERROR: the method `write` is called more than once
|
|
OpenOptions::new().append(true).append(false).open("foo.txt");
|
|
//~^ ERROR: the method `append` is called more than once
|
|
OpenOptions::new().truncate(true).truncate(false).open("foo.txt");
|
|
//~^ ERROR: the method `truncate` is called more than once
|
|
|
|
std::fs::File::options().read(true).read(false).open("foo.txt");
|
|
//~^ ERROR: the method `read` is called more than once
|
|
|
|
let mut options = std::fs::OpenOptions::new();
|
|
options.read(true);
|
|
options.read(false);
|
|
// Possible future improvement: recognize open options method call chains across statements.
|
|
options.open("foo.txt");
|
|
|
|
let mut options = std::fs::OpenOptions::new();
|
|
options.truncate(true);
|
|
options.create(true).open("foo.txt");
|
|
|
|
OpenOptions::new().create(true).truncate_write(true).open("foo.txt");
|
|
}
|