ce339b219a
`BindingAnnotation` refactor
* `ast::BindingMode` is deleted and replaced with `hir::BindingAnnotation` (which is moved to `ast`)
* `BindingAnnotation` is changed from an enum to a tuple struct e.g. `BindingAnnotation(ByRef::No, Mutability::Mut)`
* Associated constants added for convenience `BindingAnnotation::{NONE, REF, MUT, REF_MUT}`
One goal is to make it more clear that `BindingAnnotation` merely represents syntax `ref mut` and not the actual binding mode. This was especially confusing since we had `ast::BindingMode`->`hir::BindingAnnotation`->`thir::BindingMode`.
I wish there were more symmetry between `ByRef` and `Mutability` (variant) naming (maybe `Mutable::Yes`?), and I also don't love how long the name `BindingAnnotation` is, but this seems like the best compromise. Ideas welcome.
|
||
|---|---|---|
| .. | ||
| empty_loop.rs | ||
| explicit_counter_loop.rs | ||
| explicit_into_iter_loop.rs | ||
| explicit_iter_loop.rs | ||
| for_kv_map.rs | ||
| for_loops_over_fallibles.rs | ||
| iter_next_loop.rs | ||
| manual_find.rs | ||
| manual_flatten.rs | ||
| manual_memcpy.rs | ||
| missing_spin_loop.rs | ||
| mod.rs | ||
| mut_range_bound.rs | ||
| needless_collect.rs | ||
| needless_range_loop.rs | ||
| never_loop.rs | ||
| same_item_push.rs | ||
| single_element_loop.rs | ||
| utils.rs | ||
| while_immutable_condition.rs | ||
| while_let_loop.rs | ||
| while_let_on_iterator.rs | ||