bors cd477d4b0c Auto merge of #11621 - GuillaumeGomez:needless_pass_by_ref_mut-closure-non-async-fn, r=blyxyas ...

Needless pass by ref mut closure non async fn

Fixes https://github.com/rust-lang/rust-clippy/issues/11620.
Fixes https://github.com/rust-lang/rust-clippy/issues/11561.

changelog: [`needless_pass_by_ref_mut`]: Correctly handle arguments moved into closure in non-async functions.

r? `@Centri3`

2023-10-19 12:04:07 +00:00

..

cargo

…

casts

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

functions

add lint for struct field names

2023-10-18 19:20:08 +02:00

loops

dogfood

2023-10-04 18:08:30 +02:00

matches

Deserialize Msrv directly in Conf

2023-10-18 20:35:09 +00:00

methods

Auto merge of #11673 - y21:issue11672, r=Manishearth

2023-10-16 16:27:01 +00:00

misc_early

…

operators

Update version attribute for 1.73 lints

2023-10-04 01:08:45 +02:00

transmute

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

types

add lint for struct field names

2023-10-18 19:20:08 +02:00

unit_types

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

utils

Auto merge of #11683 - Alexendoo:msrv-config, r=Manishearth,flip1995

2023-10-19 11:51:08 +00:00

absolute_paths.rs

…

allow_attributes.rs

Add missing lint description headers

2023-09-29 03:08:34 +02:00

almost_complete_range.rs

…

approx_const.rs

…

arc_with_non_send_sync.rs

…

as_conversions.rs

…

asm_syntax.rs

…

assertions_on_constants.rs

…

assertions_on_result_states.rs

…

async_yields_async.rs

…

attrs.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

await_holding_invalid.rs

Enable drop_tracking_mir by default.

2023-09-23 13:34:09 +00:00

blocks_in_if_conditions.rs

…

bool_assert_comparison.rs

…

bool_to_int_with_if.rs

…

booleans.rs

…

borrow_deref_ref.rs

…

box_default.rs

…

checked_conversions.rs

…

cognitive_complexity.rs

…

collapsible_if.rs

…

collection_is_never_read.rs

…

comparison_chain.rs

…

copies.rs

…

copy_iterator.rs

…

crate_in_macro_def.rs

…

create_dir.rs

…

dbg_macro.rs

…

declared_lints.rs

add lint for struct field names

2023-10-18 19:20:08 +02:00

default_constructed_unit_structs.rs

…

default_instead_of_iter_empty.rs

…

default_numeric_fallback.rs

…

default_union_representation.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

default.rs

…

deprecated_lints.rs

…

dereference.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

derivable_impls.rs

Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup

2023-09-12 18:44:06 +02:00

derive.rs

treat host effect params as erased generics in codegen

2023-09-14 07:34:35 +00:00

disallowed_macros.rs

Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup

2023-09-12 18:44:06 +02:00

disallowed_methods.rs

…

disallowed_names.rs

…

disallowed_script_idents.rs

…

disallowed_types.rs

…

doc.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

double_parens.rs

…

drop_forget_ref.rs

…

duplicate_mod.rs

…

else_if_without_else.rs

…

empty_drop.rs

…

empty_enum.rs

…

empty_structs_with_brackets.rs

…

endian_bytes.rs

…

entry.rs

…

enum_clike.rs

it's not Miri but MIR constants

2023-09-25 16:19:02 +02:00

equatable_if_let.rs

…

error_impl_error.rs

Update version attribute for 1.73 lints

2023-10-04 01:08:45 +02:00

escape.rs

…

eta_reduction.rs

…

excessive_bools.rs

…

excessive_nesting.rs

…

exhaustive_items.rs

…

exit.rs

…

explicit_write.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

extra_unused_type_parameters.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

fallible_impl_from.rs

…

float_literal.rs

…

floating_point_arithmetic.rs

…

format_args.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

format_impl.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

format_push_string.rs

…

format.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

formatting.rs

…

four_forward_slashes.rs

Update version attribute for 1.73 lints

2023-10-04 01:08:45 +02:00

from_over_into.rs

…

from_raw_with_void_ptr.rs

…

from_str_radix_10.rs

…

future_not_send.rs

…

if_let_mutex.rs

…

if_not_else.rs

…

if_then_some_else_none.rs

Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup

2023-09-12 18:44:06 +02:00

ignored_unit_patterns.rs

Avoid invoking ignored_unit_patterns in macro definition

2023-10-03 20:36:35 +09:00

implicit_hasher.rs

Use Span#from_expansion instead of in_external_macro

2023-10-02 00:38:01 +09:00

implicit_return.rs

…

implicit_saturating_add.rs

…

implicit_saturating_sub.rs

…

implied_bounds_in_impls.rs

Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup

2023-09-12 18:44:06 +02:00

inconsistent_struct_constructor.rs

…

index_refutable_slice.rs

…

indexing_slicing.rs

…

infinite_iter.rs

…

inherent_impl.rs

…

inherent_to_string.rs

…

init_numbered_fields.rs

Don't store lazyness in DefKind

2023-09-26 02:53:59 +00:00

inline_fn_without_body.rs

…

instant_subtraction.rs

…

int_plus_one.rs

…

invalid_upcast_comparisons.rs

…

item_name_repetitions.rs

add lint for struct field names

2023-10-18 19:20:08 +02:00

items_after_statements.rs

…

items_after_test_module.rs

Fix items_after_test_module for non root modules, add applicable suggestion

2023-10-06 12:46:04 +00:00

iter_not_returning_iterator.rs

…

iter_without_into_iter.rs

Auto merge of #11638 - samueltardieu:into-iter, r=Manishearth

2023-10-07 21:33:53 +00:00

large_const_arrays.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

large_enum_variant.rs

…

large_futures.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

large_include_file.rs

…

large_stack_arrays.rs

…

large_stack_frames.rs

…

len_zero.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

let_if_seq.rs

…

let_underscore.rs

…

let_with_type_underscore.rs

…

lib.deprecated.rs

…

lib.rs

Auto merge of #11683 - Alexendoo:msrv-config, r=Manishearth,flip1995

2023-10-19 11:51:08 +00:00

lifetimes.rs

…

lines_filter_map_ok.rs

…

literal_representation.rs

…

macro_use.rs

…

main_recursion.rs

…

manual_assert.rs

…

manual_async_fn.rs

…

manual_bits.rs

dogfood

2023-10-04 18:08:30 +02:00

manual_clamp.rs

…

manual_float_methods.rs

Update version attribute for 1.73 lints

2023-10-04 01:08:45 +02:00

manual_hash_one.rs

Add manual_hash_one lint

2023-09-26 13:49:15 +00:00

manual_is_ascii_check.rs

[manual_is_ascii_check]: Also check for is_ascii_hexdigt

2023-10-12 19:12:42 +00:00

manual_let_else.rs

[manual_let_else]: only omit block if span is from same ctxt

2023-09-29 16:54:50 +02:00

manual_main_separator_str.rs

…

manual_non_exhaustive.rs

Remove extraneous #[non_exhaustive] check in lint

2023-10-01 09:54:45 -05:00

manual_range_patterns.rs

Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup

2023-09-12 18:44:06 +02:00

manual_rem_euclid.rs

…

manual_retain.rs

…

manual_slice_size_calculation.rs

…

manual_string_new.rs

…

manual_strip.rs

…

map_unit_fn.rs

…

match_result_ok.rs

…

mem_replace.rs

…

min_ident_chars.rs

…

minmax.rs

…

misc.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

mismatching_type_param_order.rs

…

missing_assert_message.rs

Mention that missing_assert_message lint ignores test functions

2023-09-27 22:06:01 +01:00

missing_asserts_for_indexing.rs

Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup

2023-09-12 18:44:06 +02:00

missing_const_for_fn.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

missing_doc.rs

dogfood

2023-10-04 18:08:30 +02:00

missing_enforced_import_rename.rs

…

missing_fields_in_debug.rs

…

missing_inline.rs

…

missing_trait_methods.rs

…

mixed_read_write_in_expression.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-10-06 17:31:44 +02:00

module_style.rs

…

multi_assignments.rs

…

multiple_unsafe_ops_per_block.rs

Make multiple_unsafe_ops_per_block ignore await desugaring

2023-10-14 23:15:00 +02:00

mut_key.rs

…

mut_mut.rs

…

mut_reference.rs

…

mutable_debug_assertion.rs

…

mutex_atomic.rs

…

needless_arbitrary_self_type.rs

…

needless_bool.rs

…

needless_borrowed_ref.rs

…

needless_borrows_for_generic_args.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

needless_continue.rs

dogfood

2023-10-04 18:08:30 +02:00

needless_else.rs

…

needless_for_each.rs

…

needless_if.rs

…

needless_late_init.rs

…

needless_parens_on_range_literals.rs

…

needless_pass_by_ref_mut.rs

Fix invalid warning for closure in non-async function for needless_pass_by_ref_mut lint

2023-10-18 21:17:02 +02:00

needless_pass_by_value.rs

…

needless_question_mark.rs

…

needless_update.rs

…

neg_cmp_op_on_partial_ord.rs

…

neg_multiply.rs

…

new_without_default.rs

…

no_effect.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

no_mangle_with_rust_abi.rs

…

non_canonical_impls.rs

Update version attribute for 1.73 lints

2023-10-04 01:08:45 +02:00

non_copy_const.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

non_expressive_names.rs

…

non_octal_unix_permissions.rs

…

non_send_fields_in_send_ty.rs

…

nonstandard_macro_braces.rs

…

octal_escapes.rs

…

only_used_in_recursion.rs

add lint for struct field names

2023-10-18 19:20:08 +02:00

option_env_unwrap.rs

…

option_if_let_else.rs

…

overflow_check_conditional.rs

…

panic_in_result_fn.rs

…

panic_unimplemented.rs

…

partial_pub_fields.rs

…

partialeq_ne_impl.rs

…

partialeq_to_none.rs

…

pass_by_ref_or_value.rs

…

pattern_type_mismatch.rs

…

permissions_set_readonly_false.rs

…

precedence.rs

…

ptr_offset_with_cast.rs

…

ptr.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

pub_use.rs

…

question_mark_used.rs

…

question_mark.rs

…

ranges.rs

…

raw_strings.rs

Move needless_raw_string_hashes to pedantic

2023-09-28 21:24:42 +02:00

rc_clone_in_vec_init.rs

…

read_zero_byte_vec.rs

…

redundant_async_block.rs

…

redundant_clone.rs

…

redundant_closure_call.rs

Record asyncness span in HIR

2023-09-21 19:18:14 +00:00

redundant_else.rs

…

redundant_field_names.rs

…

redundant_locals.rs

Fix ice

2023-10-07 01:28:06 +09:00

redundant_pub_crate.rs

…

redundant_slicing.rs

…

redundant_static_lifetimes.rs

…

redundant_type_annotations.rs

…

ref_option_ref.rs

…

ref_patterns.rs

…

reference.rs

…

regex.rs

…

renamed_lints.rs

Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup

2023-09-12 18:44:06 +02:00

reserve_after_initialization.rs

…

return_self_not_must_use.rs

…

returns.rs

…

same_name_method.rs

…

self_named_constructors.rs

…

semicolon_block.rs

…

semicolon_if_nothing_returned.rs

…

serde_api.rs

…

shadow.rs

…

significant_drop_tightening.rs

…

single_call_fn.rs

…

single_char_lifetime_names.rs

…

single_component_path_imports.rs

…

single_range_in_vec_init.rs

…

size_of_in_element_count.rs

…

size_of_ref.rs

…

slow_vector_initialization.rs

dogfood

2023-10-04 18:08:30 +02:00

std_instead_of_core.rs

Avoid linting in external/proc macro

2023-09-30 23:56:11 +09:00

strings.rs

…

strlen_on_c_strings.rs

…

suspicious_doc_comments.rs

…

suspicious_operation_groupings.rs

Update tools and fulldeps tests

2023-09-11 15:51:19 +00:00

suspicious_trait_impl.rs

…

suspicious_xor_used_as_pow.rs

…

swap_ptr_to_ref.rs

…

swap.rs

…

tabs_in_doc_comments.rs

…

temporary_assignment.rs

…

tests_outside_test_module.rs

…

to_digit_is_some.rs

…

trailing_empty_array.rs

…

trait_bounds.rs

…

tuple_array_conversions.rs

…

undocumented_unsafe_blocks.rs

Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup

2023-09-12 18:44:06 +02:00

unicode.rs

…

uninit_vec.rs

dogfood

2023-10-04 18:08:30 +02:00

unit_return_expecting_ord.rs

Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup

2023-09-12 18:44:06 +02:00

unnamed_address.rs

…

unnecessary_box_returns.rs

…

unnecessary_map_on_constructor.rs

dogfood

2023-10-04 18:08:30 +02:00

unnecessary_owned_empty_strings.rs

…

unnecessary_self_imports.rs

…

unnecessary_struct_initialization.rs

…

unnecessary_wraps.rs

…

unnested_or_patterns.rs

Update tools and fulldeps tests

2023-09-11 15:51:19 +00:00

unsafe_removed_from_name.rs

…

unused_async.rs

…

unused_io_amount.rs

…

unused_peekable.rs

…

unused_rounding.rs

…

unused_self.rs

…

unused_unit.rs

…

unwrap_in_result.rs

…

unwrap.rs

Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup

2023-09-12 18:44:06 +02:00

upper_case_acronyms.rs

…

use_self.rs

Deserialize Msrv directly in Conf

2023-10-18 20:35:09 +00:00

useless_conversion.rs

Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup

2023-09-25 11:28:58 +02:00

vec_init_then_push.rs

…

vec.rs

…

visibility.rs

…

wildcard_imports.rs

Do not lint when imported item contains underscore

2023-09-26 12:58:48 +09:00

write.rs

Don't escape unicode escape braces in print_literal

2023-10-01 21:43:09 +00:00

zero_div_zero.rs

…

zero_sized_map_values.rs

…