4aba2c55e6
Start pointing to where bindings were declared when they are captured in closures: ``` error[E0597]: `x` does not live long enough --> $DIR/suggest-return-closure.rs:23:9 | LL | let x = String::new(); | - binding `x` declared here ... LL | |c| { | --- value captured here LL | x.push(c); | ^ borrowed value does not live long enough ... LL | } | -- borrow later used here | | | `x` dropped here while still borrowed ``` Suggest cloning in more cases involving closures: ``` error[E0507]: cannot move out of `foo` in pattern guard --> $DIR/issue-27282-move-ref-mut-into-guard.rs:11:19 | LL | if { (|| { let mut bar = foo; bar.take() })(); false } => {}, | ^^ --- move occurs because `foo` has type `&mut Option<&i32>`, which does not implement the `Copy` trait | | | `foo` is moved here | = note: variables bound in patterns cannot be moved from until after the end of the pattern guard help: consider cloning the value if the performance cost is acceptable | LL | if { (|| { let mut bar = foo.clone(); bar.take() })(); false } => {}, | ++++++++ ```
57 lines
1.6 KiB
Plaintext
57 lines
1.6 KiB
Plaintext
note: external requirements
|
|
--> $DIR/escape-upvar-nested.rs:21:32
|
|
|
|
|
LL | let mut closure1 = || p = &y;
|
|
| ^^
|
|
|
|
|
= note: defining type: test::{closure#0}::{closure#0} with closure args [
|
|
i16,
|
|
extern "rust-call" fn(()),
|
|
(&'?1 mut &'?2 i32, &'?3 i32),
|
|
]
|
|
= note: number of external vids: 4
|
|
= note: where '?3: '?2
|
|
|
|
note: external requirements
|
|
--> $DIR/escape-upvar-nested.rs:20:27
|
|
|
|
|
LL | let mut closure = || {
|
|
| ^^
|
|
|
|
|
= note: defining type: test::{closure#0} with closure args [
|
|
i16,
|
|
extern "rust-call" fn(()),
|
|
(&'?1 mut &'?2 i32, &'?3 i32),
|
|
]
|
|
= note: number of external vids: 4
|
|
= note: where '?3: '?2
|
|
|
|
note: no external requirements
|
|
--> $DIR/escape-upvar-nested.rs:13:1
|
|
|
|
|
LL | fn test() {
|
|
| ^^^^^^^^^
|
|
|
|
|
= note: defining type: test
|
|
|
|
error[E0597]: `y` does not live long enough
|
|
--> $DIR/escape-upvar-nested.rs:21:40
|
|
|
|
|
LL | let y = 22;
|
|
| - binding `y` declared here
|
|
LL |
|
|
LL | let mut closure = || {
|
|
| -- value captured here
|
|
LL | let mut closure1 = || p = &y;
|
|
| ^ borrowed value does not live long enough
|
|
...
|
|
LL | }
|
|
| - `y` dropped here while still borrowed
|
|
LL |
|
|
LL | deref(p);
|
|
| - borrow later used here
|
|
|
|
error: aborting due to 1 previous error
|
|
|
|
For more information about this error, try `rustc --explain E0597`.
|