d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
103 lines
3.3 KiB
Rust
103 lines
3.3 KiB
Rust
use clippy_utils::{diagnostics::span_lint_and_sugg, source::snippet_opt};
|
|
|
|
use rustc_data_structures::fx::FxHashMap;
|
|
use rustc_errors::Applicability;
|
|
use rustc_hir::{def::Res, def_id::DefId, Item, ItemKind, UseKind};
|
|
use rustc_lint::{LateContext, LateLintPass, LintContext};
|
|
use rustc_session::{declare_tool_lint, impl_lint_pass};
|
|
use rustc_span::Symbol;
|
|
|
|
use crate::utils::conf::Rename;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for imports that do not rename the item as specified
|
|
/// in the `enforce-import-renames` config option.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Consistency is important, if a project has defined import
|
|
/// renames they should be followed. More practically, some item names are too
|
|
/// vague outside of their defining scope this can enforce a more meaningful naming.
|
|
///
|
|
/// ### Example
|
|
/// An example clippy.toml configuration:
|
|
/// ```toml
|
|
/// # clippy.toml
|
|
/// enforced-import-renames = [ { path = "serde_json::Value", rename = "JsonValue" }]
|
|
/// ```
|
|
///
|
|
/// ```rust,ignore
|
|
/// use serde_json::Value;
|
|
/// ```
|
|
/// Use instead:
|
|
/// ```rust,ignore
|
|
/// use serde_json::Value as JsonValue;
|
|
/// ```
|
|
#[clippy::version = "1.55.0"]
|
|
pub MISSING_ENFORCED_IMPORT_RENAMES,
|
|
restriction,
|
|
"enforce import renames"
|
|
}
|
|
|
|
pub struct ImportRename {
|
|
conf_renames: Vec<Rename>,
|
|
renames: FxHashMap<DefId, Symbol>,
|
|
}
|
|
|
|
impl ImportRename {
|
|
pub fn new(conf_renames: Vec<Rename>) -> Self {
|
|
Self {
|
|
conf_renames,
|
|
renames: FxHashMap::default(),
|
|
}
|
|
}
|
|
}
|
|
|
|
impl_lint_pass!(ImportRename => [MISSING_ENFORCED_IMPORT_RENAMES]);
|
|
|
|
impl LateLintPass<'_> for ImportRename {
|
|
fn check_crate(&mut self, cx: &LateContext<'_>) {
|
|
for Rename { path, rename } in &self.conf_renames {
|
|
if let Res::Def(_, id) = clippy_utils::path_to_res(cx, &path.split("::").collect::<Vec<_>>()) {
|
|
self.renames.insert(id, Symbol::intern(rename));
|
|
}
|
|
}
|
|
}
|
|
|
|
fn check_item(&mut self, cx: &LateContext<'_>, item: &Item<'_>) {
|
|
if_chain! {
|
|
if let ItemKind::Use(path, UseKind::Single) = &item.kind;
|
|
if let Res::Def(_, id) = path.res;
|
|
if let Some(name) = self.renames.get(&id);
|
|
// Remove semicolon since it is not present for nested imports
|
|
let span_without_semi = cx.sess().source_map().span_until_char(item.span, ';');
|
|
if let Some(snip) = snippet_opt(cx, span_without_semi);
|
|
if let Some(import) = match snip.split_once(" as ") {
|
|
None => Some(snip.as_str()),
|
|
Some((import, rename)) => {
|
|
if rename.trim() == &*name.as_str() {
|
|
None
|
|
} else {
|
|
Some(import.trim())
|
|
}
|
|
},
|
|
};
|
|
then {
|
|
span_lint_and_sugg(
|
|
cx,
|
|
MISSING_ENFORCED_IMPORT_RENAMES,
|
|
span_without_semi,
|
|
"this import should be renamed",
|
|
"try",
|
|
format!(
|
|
"{} as {}",
|
|
import,
|
|
name,
|
|
),
|
|
Applicability::MachineApplicable,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|