2e486be8d2
Use SipHash-1-3 instead of SipHash-2-4 for StableHasher Noticed this, and it seems easy and likely a perf win. IIUC we don't need DDOS resistance (just collision) so we ideally would have an even faster hash, but it's hard to beat this SipHash impl here, since it's been so highly tuned for the interface. It wouldn't surprise me if there's some subtle reason changing this sucks, as it's so obvious it seems likely to have been done. Still, SipHash-1-3 seems to still have the guarantees StableHasher should need (and seemingly more), and is clearly less work. So it's worth a shot. Not fully tested locally. |
||
|---|---|---|
| .. | ||
| basic.legacy.stderr | ||
| basic.rs | ||
| basic.v0.stderr | ||
| const-generics-demangling.legacy.stderr | ||
| const-generics-demangling.rs | ||
| const-generics-demangling.v0.stderr | ||
| const-generics-str-demangling.rs | ||
| const-generics-str-demangling.stderr | ||
| const-generics-structural-demangling.rs | ||
| const-generics-structural-demangling.stderr | ||
| const-generics.rs | ||
| foreign-types.rs | ||
| foreign-types.stderr | ||
| impl1.legacy.stderr | ||
| impl1.rs | ||
| impl1.v0.stderr | ||
| impl2.rs | ||
| impl2.stderr | ||
| issue-53912.rs | ||
| issue-60925.legacy.stderr | ||
| issue-60925.rs | ||
| issue-60925.v0.stderr | ||
| issue-75326.legacy.stderr | ||
| issue-75326.rs | ||
| issue-75326.v0.stderr | ||
| issue-76365.rs | ||
| trait-objects.rs | ||
| trait-objects.v0.stderr | ||
| types.legacy.stderr | ||
| types.rs | ||
| types.verbose-legacy.stderr | ||
| verbose.rs | ||
| x86-stdcall.rs | ||