rust/compiler
bors c84d5e7078 Auto merge of #112346 - saethlin:no-comment, r=oli-obk
Remove comments from mir-opt MIR dumps

See https://rust-lang.zulipchat.com/#narrow/stream/189540-t-compiler.2Fwg-mir-opt/topic/Line.20numbers.20in.20mir-opt.20tests/near/363849874

In https://github.com/rust-lang/rust/pull/99780 there is mention that "there has been a zulip conversation about disabling line numbers with mixed opinions" which to me means that some people opposed this. I can't find the referenced conversation so... here we go.

The current situation is quite chaotic. It's not hard to find MIR diffs which contain

* Absolute line numbers
* Relative line numbers
* Substituted line numbers (LL)
For example: 408bbd0406/tests/mir-opt/inline/inline_shims.drop.Inline.diff (L10-L17)

And sometimes adding a comment at the top of a mir-opt test generates a diff in the test because a line number changed: https://github.com/rust-lang/rust/pull/98112/files#diff-b8cf4bcce95078e6a3faf075e9abf6864872fb28a64d95c04f04513b9e3bbd81

And irrelevant changes to the standard library can generate diffs in mir-opt tests: https://github.com/rust-lang/rust/pull/110694/files#diff-bf96b0e7c67b8b272814536888fd9428c314991e155beae1f0a2a67f0ac47b2c
769886cc35

I think we should, specifically in mir-opt tests, completely remove the comments, or insert placeholders for all line and column numbers.
2023-06-16 01:55:34 +00:00
..
rustc
rustc_abi
rustc_apfloat
rustc_arena
rustc_ast
rustc_ast_lowering
rustc_ast_passes
rustc_ast_pretty
rustc_attr
rustc_baked_icu_data
rustc_borrowck Rollup merge of #112654 - aliemjay:closure-output-normalize, r=compiler-errors 2023-06-15 22:04:57 +02:00
rustc_builtin_macros
rustc_codegen_cranelift
rustc_codegen_gcc
rustc_codegen_llvm
rustc_codegen_ssa Rollup merge of #112669 - Nilstrieb:typo, r=jyn514 2023-06-15 22:04:58 +02:00
rustc_const_eval
rustc_data_structures
rustc_driver
rustc_driver_impl
rustc_error_codes
rustc_error_messages
rustc_errors
rustc_expand
rustc_feature
rustc_fluent_macro
rustc_fs_util
rustc_graphviz
rustc_hir
rustc_hir_analysis
rustc_hir_pretty
rustc_hir_typeck
rustc_incremental
rustc_index
rustc_infer
rustc_interface Remove comments from mir-opt MIR dumps 2023-06-15 15:19:11 -04:00
rustc_lexer
rustc_lint Rollup merge of #112529 - jieyouxu:block-expr-unused-must-use, r=oli-obk 2023-06-15 22:04:56 +02:00
rustc_lint_defs
rustc_llvm
rustc_log
rustc_macros
rustc_metadata
rustc_middle Auto merge of #112346 - saethlin:no-comment, r=oli-obk 2023-06-16 01:55:34 +00:00
rustc_mir_build
rustc_mir_dataflow
rustc_mir_transform Rollup merge of #112403 - nbdd0121:eh_frame, r=Nilstrieb 2023-06-15 22:04:55 +02:00
rustc_monomorphize
rustc_parse
rustc_parse_format
rustc_passes
rustc_plugin_impl
rustc_privacy
rustc_query_impl
rustc_query_system
rustc_resolve
rustc_serialize
rustc_session Remove comments from mir-opt MIR dumps 2023-06-15 15:19:11 -04:00
rustc_smir
rustc_span
rustc_symbol_mangling
rustc_target
rustc_trait_selection
rustc_traits
rustc_transmute
rustc_ty_utils
rustc_type_ir