rust/crates
Aleksey Kladov b56e020077 Apply couple of rule of thumbs to simplify highlighting code
Main one: instead of adding a parameter to function to handle special
case, make the caller handle it.

Second main one: make sure that function does a reasonable thing.
`highlight_def` picks  a color for def, *regardless* of the context
the def is use. Feeding an info from the call-site muddies the
responsibilities here.

Minor smells, flagging the function as having space for improvement in
the first place:

* many parameters, some of which are set as constants on most
call-sites (introduce severalfunction instad)
* boolean param (add two functions instead)
2020-08-19 17:53:41 +02:00
..
arena
assists Introduce Label 2020-08-18 16:50:07 +02:00
base_db Rename ra_ide -> ide 2020-08-13 17:58:27 +02:00
cfg
expect Rename ra_ide -> ide 2020-08-13 17:58:27 +02:00
flycheck Rename ra_ide -> ide 2020-08-13 17:58:27 +02:00
hir Better API factoring around self access modes 2020-08-19 17:02:50 +02:00
hir_def Add type safety to diagnostic codes 2020-08-18 18:39:43 +02:00
hir_expand Add type safety to diagnostic codes 2020-08-18 18:39:43 +02:00
hir_ty Add type safety to diagnostic codes 2020-08-18 18:39:43 +02:00
ide Apply couple of rule of thumbs to simplify highlighting code 2020-08-19 17:53:41 +02:00
ide_db Introduce Label 2020-08-18 16:50:07 +02:00
mbe
parser Better recovery in use foo::; 2020-08-13 18:50:21 +02:00
paths Rename ra_ide -> ide 2020-08-13 17:58:27 +02:00
proc_macro_api Hacky support for fn-like proc macros 2020-08-15 15:34:56 +02:00
proc_macro_srv Add a proc_macro_test crate 2020-08-15 00:27:32 +02:00
proc_macro_test Add a proc_macro_test crate 2020-08-15 00:27:32 +02:00
profile
project_model Better error if Cargo is not in Path 2020-08-19 16:34:11 +02:00
rust-analyzer Merge #5643 2020-08-19 11:27:02 +00:00
ssr Add SelfParam to code_model 2020-08-19 15:16:24 +02:00
stdx Make RacyFlag actually work 2020-08-18 23:51:01 +02:00
syntax Merge #5776 #5780 2020-08-17 14:30:24 +00:00
test_utils Rename ra_ide -> ide 2020-08-13 17:58:27 +02:00
text_edit
toolchain
tt
vfs Sophisticate Windows path encoding 2020-08-14 02:03:54 +02:00
vfs-notify Rename ra_ide -> ide 2020-08-13 17:58:27 +02:00