8172166f34
Only crate root def-ids don't have a parent, and in majority of cases the argument of `DefIdTree::parent` cannot be a crate root. So we now panic by default in `parent` and introduce a new non-panicing function `opt_parent` for cases where the argument can be a crate root. Same applies to `local_parent`/`opt_local_parent`.
52 lines
1.7 KiB
Rust
52 lines
1.7 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_sugg;
|
|
use clippy_utils::source::snippet_with_applicability;
|
|
use clippy_utils::{method_chain_args, path_def_id};
|
|
use if_chain::if_chain;
|
|
use rustc_errors::Applicability;
|
|
use rustc_hir as hir;
|
|
use rustc_lint::LateContext;
|
|
use rustc_lint::Lint;
|
|
use rustc_middle::ty::{self, DefIdTree};
|
|
|
|
/// Wrapper fn for `CHARS_NEXT_CMP` and `CHARS_LAST_CMP` lints.
|
|
pub(super) fn check(
|
|
cx: &LateContext<'_>,
|
|
info: &crate::methods::BinaryExprInfo<'_>,
|
|
chain_methods: &[&str],
|
|
lint: &'static Lint,
|
|
suggest: &str,
|
|
) -> bool {
|
|
if_chain! {
|
|
if let Some(args) = method_chain_args(info.chain, chain_methods);
|
|
if let hir::ExprKind::Call(fun, [arg_char]) = info.other.kind;
|
|
if let Some(id) = path_def_id(cx, fun).map(|ctor_id| cx.tcx.parent(ctor_id));
|
|
if Some(id) == cx.tcx.lang_items().option_some_variant();
|
|
then {
|
|
let mut applicability = Applicability::MachineApplicable;
|
|
let self_ty = cx.typeck_results().expr_ty_adjusted(&args[0][0]).peel_refs();
|
|
|
|
if *self_ty.kind() != ty::Str {
|
|
return false;
|
|
}
|
|
|
|
span_lint_and_sugg(
|
|
cx,
|
|
lint,
|
|
info.expr.span,
|
|
&format!("you should use the `{}` method", suggest),
|
|
"like this",
|
|
format!("{}{}.{}({})",
|
|
if info.eq { "" } else { "!" },
|
|
snippet_with_applicability(cx, args[0][0].span, "..", &mut applicability),
|
|
suggest,
|
|
snippet_with_applicability(cx, arg_char.span, "..", &mut applicability)),
|
|
applicability,
|
|
);
|
|
|
|
return true;
|
|
}
|
|
}
|
|
|
|
false
|
|
}
|