d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
91 lines
2.9 KiB
Rust
91 lines
2.9 KiB
Rust
//! lint on if branches that could be swapped so no `!` operation is necessary
|
|
//! on the condition
|
|
|
|
use clippy_utils::diagnostics::span_lint_and_help;
|
|
use clippy_utils::is_else_clause;
|
|
use rustc_hir::{BinOpKind, Expr, ExprKind, UnOp};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for usage of `!` or `!=` in an if condition with an
|
|
/// else branch.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Negations reduce the readability of statements.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// # let v: Vec<usize> = vec![];
|
|
/// # fn a() {}
|
|
/// # fn b() {}
|
|
/// if !v.is_empty() {
|
|
/// a()
|
|
/// } else {
|
|
/// b()
|
|
/// }
|
|
/// ```
|
|
///
|
|
/// Could be written:
|
|
///
|
|
/// ```rust
|
|
/// # let v: Vec<usize> = vec![];
|
|
/// # fn a() {}
|
|
/// # fn b() {}
|
|
/// if v.is_empty() {
|
|
/// b()
|
|
/// } else {
|
|
/// a()
|
|
/// }
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub IF_NOT_ELSE,
|
|
pedantic,
|
|
"`if` branches that could be swapped so no negation operation is necessary on the condition"
|
|
}
|
|
|
|
declare_lint_pass!(IfNotElse => [IF_NOT_ELSE]);
|
|
|
|
impl LateLintPass<'_> for IfNotElse {
|
|
fn check_expr(&mut self, cx: &LateContext<'_>, item: &Expr<'_>) {
|
|
// While loops will be desugared to ExprKind::If. This will cause the lint to fire.
|
|
// To fix this, return early if this span comes from a macro or desugaring.
|
|
if item.span.from_expansion() {
|
|
return;
|
|
}
|
|
if let ExprKind::If(cond, _, Some(els)) = item.kind {
|
|
if let ExprKind::Block(..) = els.kind {
|
|
// Disable firing the lint in "else if" expressions.
|
|
if is_else_clause(cx.tcx, item) {
|
|
return;
|
|
}
|
|
|
|
match cond.peel_drop_temps().kind {
|
|
ExprKind::Unary(UnOp::Not, _) => {
|
|
span_lint_and_help(
|
|
cx,
|
|
IF_NOT_ELSE,
|
|
item.span,
|
|
"unnecessary boolean `not` operation",
|
|
None,
|
|
"remove the `!` and swap the blocks of the `if`/`else`",
|
|
);
|
|
},
|
|
ExprKind::Binary(ref kind, _, _) if kind.node == BinOpKind::Ne => {
|
|
span_lint_and_help(
|
|
cx,
|
|
IF_NOT_ELSE,
|
|
item.span,
|
|
"unnecessary `!=` operation",
|
|
None,
|
|
"change to `==` and swap the blocks of the `if`/`else`",
|
|
);
|
|
},
|
|
_ => (),
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|