e9ad12c0ca
This breaks code like:
struct Foo {
...
}
pub fn make_foo() -> Foo {
...
}
Change this code to:
pub struct Foo { // note `pub`
...
}
pub fn make_foo() -> Foo {
...
}
The `visible_private_types` lint has been removed, since it is now an
error to attempt to expose a private type in a public API. In its place
a `#[feature(visible_private_types)]` gate has been added.
Closes #16463.
RFC #48.
[breaking-change]
109 lines
2.6 KiB
Rust
109 lines
2.6 KiB
Rust
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution and at
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
#![no_std]
|
|
#![allow(unused_variable)]
|
|
#![allow(non_camel_case_types)]
|
|
#![deny(dead_code)]
|
|
#![feature(lang_items)]
|
|
|
|
#![crate_type="lib"]
|
|
|
|
pub use foo2::Bar2;
|
|
|
|
#[lang="sized"]
|
|
pub trait Sized {}
|
|
|
|
mod foo {
|
|
pub struct Bar; //~ ERROR: code is never used
|
|
}
|
|
|
|
mod foo2 {
|
|
pub struct Bar2;
|
|
}
|
|
|
|
pub static pub_static: int = 0;
|
|
static priv_static: int = 0; //~ ERROR: code is never used
|
|
static used_static: int = 0;
|
|
pub static used_static2: int = used_static;
|
|
static USED_STATIC: int = 0;
|
|
static STATIC_USED_IN_ENUM_DISCRIMINANT: int = 10;
|
|
|
|
pub type typ = *const UsedStruct4;
|
|
pub struct PubStruct;
|
|
struct PrivStruct; //~ ERROR: code is never used
|
|
struct UsedStruct1 {
|
|
#[allow(dead_code)]
|
|
x: int
|
|
}
|
|
struct UsedStruct2(int);
|
|
struct UsedStruct3;
|
|
struct UsedStruct4;
|
|
// this struct is never used directly, but its method is, so we don't want
|
|
// to warn it
|
|
struct SemiUsedStruct;
|
|
impl SemiUsedStruct {
|
|
fn la_la_la() {}
|
|
}
|
|
struct StructUsedAsField;
|
|
pub struct StructUsedInEnum;
|
|
struct StructUsedInGeneric;
|
|
pub struct PubStruct2 {
|
|
#[allow(dead_code)]
|
|
struct_used_as_field: *const StructUsedAsField
|
|
}
|
|
|
|
pub enum pub_enum { foo1, bar1 }
|
|
pub enum pub_enum2 { a(*const StructUsedInEnum) }
|
|
pub enum pub_enum3 { Foo = STATIC_USED_IN_ENUM_DISCRIMINANT }
|
|
enum priv_enum { foo2, bar2 } //~ ERROR: code is never used
|
|
enum used_enum { foo3, bar3 }
|
|
|
|
fn f<T>() {}
|
|
|
|
pub fn pub_fn() {
|
|
used_fn();
|
|
let used_struct1 = UsedStruct1 { x: 1 };
|
|
let used_struct2 = UsedStruct2(1);
|
|
let used_struct3 = UsedStruct3;
|
|
let e = foo3;
|
|
SemiUsedStruct::la_la_la();
|
|
|
|
let i = 1i;
|
|
match i {
|
|
USED_STATIC => (),
|
|
_ => ()
|
|
}
|
|
f::<StructUsedInGeneric>();
|
|
}
|
|
fn priv_fn() { //~ ERROR: code is never used
|
|
let unused_struct = PrivStruct;
|
|
}
|
|
fn used_fn() {}
|
|
|
|
fn foo() { //~ ERROR: code is never used
|
|
bar();
|
|
let unused_enum = foo2;
|
|
}
|
|
|
|
fn bar() { //~ ERROR: code is never used
|
|
foo();
|
|
}
|
|
|
|
// Code with #[allow(dead_code)] should be marked live (and thus anything it
|
|
// calls is marked live)
|
|
#[allow(dead_code)]
|
|
fn g() { h(); }
|
|
fn h() {}
|
|
|
|
// Similarly, lang items are live
|
|
#[lang="fail_"]
|
|
fn fail(_: *const u8, _: *const u8, _: uint) -> ! { loop {} }
|