d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
64 lines
1.9 KiB
Rust
64 lines
1.9 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_help;
|
|
use clippy_utils::source::snippet;
|
|
use clippy_utils::{is_entrypoint_fn, is_no_std_crate};
|
|
use if_chain::if_chain;
|
|
use rustc_hir::{Expr, ExprKind, QPath};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_tool_lint, impl_lint_pass};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for recursion using the entrypoint.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Apart from special setups (which we could detect following attributes like #![no_std]),
|
|
/// recursing into main() seems like an unintuitive antipattern we should be able to detect.
|
|
///
|
|
/// ### Example
|
|
/// ```no_run
|
|
/// fn main() {
|
|
/// main();
|
|
/// }
|
|
/// ```
|
|
#[clippy::version = "1.38.0"]
|
|
pub MAIN_RECURSION,
|
|
style,
|
|
"recursion using the entrypoint"
|
|
}
|
|
|
|
#[derive(Default)]
|
|
pub struct MainRecursion {
|
|
has_no_std_attr: bool,
|
|
}
|
|
|
|
impl_lint_pass!(MainRecursion => [MAIN_RECURSION]);
|
|
|
|
impl LateLintPass<'_> for MainRecursion {
|
|
fn check_crate(&mut self, cx: &LateContext<'_>) {
|
|
self.has_no_std_attr = is_no_std_crate(cx);
|
|
}
|
|
|
|
fn check_expr_post(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) {
|
|
if self.has_no_std_attr {
|
|
return;
|
|
}
|
|
|
|
if_chain! {
|
|
if let ExprKind::Call(func, _) = &expr.kind;
|
|
if let ExprKind::Path(QPath::Resolved(_, path)) = &func.kind;
|
|
if let Some(def_id) = path.res.opt_def_id();
|
|
if is_entrypoint_fn(cx, def_id);
|
|
then {
|
|
span_lint_and_help(
|
|
cx,
|
|
MAIN_RECURSION,
|
|
func.span,
|
|
&format!("recursing into entrypoint `{}`", snippet(cx, func.span, "main")),
|
|
None,
|
|
"consider using another function for this recursion"
|
|
)
|
|
}
|
|
}
|
|
}
|
|
}
|