d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
84 lines
3.0 KiB
Rust
84 lines
3.0 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_help;
|
|
use if_chain::if_chain;
|
|
use rustc_ast::ast::LitKind;
|
|
use rustc_hir::{Expr, ExprKind, PathSegment};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_middle::ty;
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::{source_map::Spanned, symbol::sym, Span};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for calls to `ends_with` with possible file extensions
|
|
/// and suggests to use a case-insensitive approach instead.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// `ends_with` is case-sensitive and may not detect files with a valid extension.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// fn is_rust_file(filename: &str) -> bool {
|
|
/// filename.ends_with(".rs")
|
|
/// }
|
|
/// ```
|
|
/// Use instead:
|
|
/// ```rust
|
|
/// fn is_rust_file(filename: &str) -> bool {
|
|
/// filename.rsplit('.').next().map(|ext| ext.eq_ignore_ascii_case("rs")) == Some(true)
|
|
/// }
|
|
/// ```
|
|
#[clippy::version = "1.51.0"]
|
|
pub CASE_SENSITIVE_FILE_EXTENSION_COMPARISONS,
|
|
pedantic,
|
|
"Checks for calls to ends_with with case-sensitive file extensions"
|
|
}
|
|
|
|
declare_lint_pass!(CaseSensitiveFileExtensionComparisons => [CASE_SENSITIVE_FILE_EXTENSION_COMPARISONS]);
|
|
|
|
fn check_case_sensitive_file_extension_comparison(ctx: &LateContext<'_>, expr: &Expr<'_>) -> Option<Span> {
|
|
if_chain! {
|
|
if let ExprKind::MethodCall(PathSegment { ident, .. }, _, [obj, extension, ..], span) = expr.kind;
|
|
if ident.as_str() == "ends_with";
|
|
if let ExprKind::Lit(Spanned { node: LitKind::Str(ext_literal, ..), ..}) = extension.kind;
|
|
if (2..=6).contains(&ext_literal.as_str().len());
|
|
if ext_literal.as_str().starts_with('.');
|
|
if ext_literal.as_str().chars().skip(1).all(|c| c.is_uppercase() || c.is_digit(10))
|
|
|| ext_literal.as_str().chars().skip(1).all(|c| c.is_lowercase() || c.is_digit(10));
|
|
then {
|
|
let mut ty = ctx.typeck_results().expr_ty(obj);
|
|
ty = match ty.kind() {
|
|
ty::Ref(_, ty, ..) => ty,
|
|
_ => ty
|
|
};
|
|
|
|
match ty.kind() {
|
|
ty::Str => {
|
|
return Some(span);
|
|
},
|
|
ty::Adt(&ty::AdtDef { did, .. }, _) => {
|
|
if ctx.tcx.is_diagnostic_item(sym::String, did) {
|
|
return Some(span);
|
|
}
|
|
},
|
|
_ => { return None; }
|
|
}
|
|
}
|
|
}
|
|
None
|
|
}
|
|
|
|
impl LateLintPass<'tcx> for CaseSensitiveFileExtensionComparisons {
|
|
fn check_expr(&mut self, ctx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) {
|
|
if let Some(span) = check_case_sensitive_file_extension_comparison(ctx, expr) {
|
|
span_lint_and_help(
|
|
ctx,
|
|
CASE_SENSITIVE_FILE_EXTENSION_COMPARISONS,
|
|
span,
|
|
"case-sensitive file extension comparison",
|
|
None,
|
|
"consider using a case-insensitive comparison instead",
|
|
);
|
|
}
|
|
}
|
|
}
|