d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
92 lines
2.9 KiB
Rust
92 lines
2.9 KiB
Rust
use clippy_utils::diagnostics::span_lint;
|
|
use clippy_utils::return_ty;
|
|
use clippy_utils::ty::{contains_adt_constructor, contains_ty};
|
|
use rustc_hir::{Impl, ImplItem, ImplItemKind, ItemKind, Node};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Warns when constructors have the same name as their types.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Repeating the name of the type is redundant.
|
|
///
|
|
/// ### Example
|
|
/// ```rust,ignore
|
|
/// struct Foo {}
|
|
///
|
|
/// impl Foo {
|
|
/// pub fn foo() -> Foo {
|
|
/// Foo {}
|
|
/// }
|
|
/// }
|
|
/// ```
|
|
/// Use instead:
|
|
/// ```rust,ignore
|
|
/// struct Foo {}
|
|
///
|
|
/// impl Foo {
|
|
/// pub fn new() -> Foo {
|
|
/// Foo {}
|
|
/// }
|
|
/// }
|
|
/// ```
|
|
#[clippy::version = "1.55.0"]
|
|
pub SELF_NAMED_CONSTRUCTORS,
|
|
style,
|
|
"method should not have the same name as the type it is implemented for"
|
|
}
|
|
|
|
declare_lint_pass!(SelfNamedConstructors => [SELF_NAMED_CONSTRUCTORS]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for SelfNamedConstructors {
|
|
fn check_impl_item(&mut self, cx: &LateContext<'tcx>, impl_item: &'tcx ImplItem<'_>) {
|
|
match impl_item.kind {
|
|
ImplItemKind::Fn(ref sig, _) => {
|
|
if sig.decl.implicit_self.has_implicit_self() {
|
|
return;
|
|
}
|
|
},
|
|
_ => return,
|
|
}
|
|
|
|
let parent = cx.tcx.hir().get_parent_item(impl_item.hir_id());
|
|
let item = cx.tcx.hir().expect_item(parent);
|
|
let self_ty = cx.tcx.type_of(item.def_id);
|
|
let ret_ty = return_ty(cx, impl_item.hir_id());
|
|
|
|
// Do not check trait impls
|
|
if matches!(item.kind, ItemKind::Impl(Impl { of_trait: Some(_), .. })) {
|
|
return;
|
|
}
|
|
|
|
// Ensure method is constructor-like
|
|
if let Some(self_adt) = self_ty.ty_adt_def() {
|
|
if !contains_adt_constructor(cx.tcx, ret_ty, self_adt) {
|
|
return;
|
|
}
|
|
} else if !contains_ty(cx.tcx, ret_ty, self_ty) {
|
|
return;
|
|
}
|
|
|
|
if_chain! {
|
|
if let Some(self_def) = self_ty.ty_adt_def();
|
|
if let Some(self_local_did) = self_def.did.as_local();
|
|
let self_id = cx.tcx.hir().local_def_id_to_hir_id(self_local_did);
|
|
if let Some(Node::Item(x)) = cx.tcx.hir().find(self_id);
|
|
let type_name = x.ident.name.as_str().to_lowercase();
|
|
if impl_item.ident.name.as_str() == type_name || impl_item.ident.name.as_str().replace("_", "") == type_name;
|
|
|
|
then {
|
|
span_lint(
|
|
cx,
|
|
SELF_NAMED_CONSTRUCTORS,
|
|
impl_item.span,
|
|
&format!("constructor `{}` has the same name as the type", impl_item.ident.name),
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|