Go to file
bors[bot] 982f72c022 Merge #844
844: Refactor find_all_refs to return ReferenceSearchResult r=vipentti a=vipentti

This refactors `find_all_refs` to return a new `ReferenceSearchResult` based on feedback in #839.

There are few questions/notes regarding the refactor:

1. Introducing `NavigationTarget::from_bind_pat` this simply forwards the call to `NavigationTarget::from_named`, could we just expose `from_named` directly as `pub(crate)` ?
2. Added an utility method `NavigationTarget::range` since there were few places where you would use `self.focus_range.unwrap_or(self.full_range)`
3. Implementing `IntoIterator` for `ReferenceSearchResult`. This turns `ReferenceSearchResult` into an iterator over `FileRanges` and allows previous code to mostly stay as it was based on the order that `find_all_refs` previously had (declaration first and then the references). I'm not sure if there is a way of doing the conversion to `IntoIter` without the allocation of a new vector
4. Is it possible to have a binding without a name? I'm not sure if the `NavigationTarget::from_bind_pat` can cause some edge-cases that previously were ok



This fixes #835.

Co-authored-by: Ville Penttinen <villem.penttinen@gmail.com>
2019-02-17 15:38:33 +00:00
.cargo Add cargo jinstall-lsp as a shorthand to include jemalloc support 2019-01-29 17:02:06 +00:00
.vscode Config for raLspServerPath will be overwritten if __RA_LSP_SERVER_DEBUG is set 2019-01-19 15:36:54 +03:00
crates Merge #844 2019-02-17 15:38:33 +00:00
editors Add my emacs configuration 2019-02-16 15:39:44 +01:00
.gitignore Add .vscode/settings.json to .gitignore 2019-01-19 15:37:25 +03:00
.travis.yml fix verification on CI 2019-01-27 02:30:54 +03:00
ARCHITECTURE.md Add cargo jinstall-lsp as a shorthand to include jemalloc support 2019-01-29 17:02:06 +00:00
bors.toml don't gate on appveyor 2018-10-09 19:06:05 +03:00
Cargo.lock automatically wait for worker threads 2019-02-14 21:11:07 +03:00
Cargo.toml update salsa 2019-01-15 15:06:45 +03:00
CONTRIBUTING.md brush up docs 2018-10-15 01:05:18 +03:00
DEBUGGING.md Removed gif 2019-01-19 15:36:58 +03:00
guide.md add illustrations 2019-01-21 10:27:01 +02:00
LICENSE-APACHE
LICENSE-MIT
README.md update readme to point to the WG 2019-02-12 17:55:02 +03:00
ROADMAP.md don't mention beta channel Rust in ROADMAP 2018-12-28 14:38:27 -08:00
rustfmt.toml enable "small heuristics" 2019-02-08 14:49:26 +03:00

Rust Analyzer

Build Status

Rust Analyzer is an experimental modular compiler frontend for the Rust language. It is a part of a larger rls-2.0 effort to create excellent IDE support for Rust. If you want to get involved, check rls-2.0 working group repository:

https://github.com/rust-analyzer/WG-rls2.0

Work on the Rust Analyzer is sponsored by

Ferrous Systems

Quick Start

Rust analyzer builds on Rust >= 1.31.0 and uses the 2018 edition.

# run tests
$ cargo test

# show syntax tree of a Rust file
$ cargo run --package ra_cli parse < crates/ra_syntax/src/lib.rs

# show symbols of a Rust file
$ cargo run --package ra_cli symbols < crates/ra_syntax/src/lib.rs

# install the language server
$ cargo install-lsp
or
$ cargo install --path crates/ra_lsp_server

See these instructions for VS Code setup and the list of features (some of which are VS Code specific).

Debugging

See these instructions on how to debug the vscode extension and the lsp server.

Getting in touch

We are on the rust-lang Zulip!

https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frls-2.2E0

Contributing

See CONTRIBUTING.md and ARCHITECTURE.md

Supported LSP features

General

Workspace

Text Synchronization

Diagnostics

Lanuguage Features

License

Rust analyzer is primarily distributed under the terms of both the MIT license and the Apache License (Version 2.0).

See LICENSE-APACHE and LICENSE-MIT for details.