mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
rust/compiler
History
bors 97fff1f2ed Auto merge of #114790 - taiki-e:asm-maybe-uninit, r=Amanieu 
Allow MaybeUninit in input and output of inline assembly

**Motivation:**

As part of the work to remove UBs from crossbeam's AtomicCell, I'm writing a library to implement atomic operations on MaybeUnint using inline assembly ([atomic-maybe-uninit](https://github.com/taiki-e/atomic-maybe-uninit), https://github.com/crossbeam-rs/crossbeam/pull/1015).

However, currently, MaybeUnint cannot be used in input&output of inline assembly, so when processing MaybeUninit, values must be [passed through memory](https://github.com/taiki-e/atomic-maybe-uninit/blob/main/src/arch/aarch64.rs#L121-L122). It is inefficient and microbenchmarks have [actually shown significant performance degradation](https://github.com/crossbeam-rs/crossbeam/pull/1015#issuecomment-1676549870).

It would be nice if we could allow MaybeUninit in input and output of inline assembly.

---

This PR changed the type check in rustc_hir_analysis to allow `MaybeUnint<int | float | ptr | fn ptr | simd vector>` in input and output of inline assembly and added a simple test.

To be honest, I'm not sure that this is the correct way to do it, because this is like doing transmute to integers/floats/etc from MaybeUninit on the compiler side. EDIT: [this seems fine](https://rust-lang.zulipchat.com/#narrow/stream/216763-project-inline-asm/topic/MaybeUninit.20in.20asm!/near/384662900)

r? `@Amanieu`
cc `@thomcc` (because you [had previously proposed this](https://rust-lang.zulipchat.com/#narrow/stream/216763-project-inline-asm/topic/MaybeUninit.20in.20asm!))
2023-08-23 13:40:41 +00:00
..
rustc
…
rustc_abi
…
rustc_arena
Address comments
2023-08-14 21:29:19 +02:00
rustc_ast
Fix a stack overflow with long else if chains
2023-08-19 13:11:16 +02:00
rustc_ast_lowering
Move scrutinee HirId into MatchSource::TryDesugar
2023-08-14 21:43:56 +00:00
rustc_ast_passes
…
rustc_ast_pretty
Add helpful comments to tt_prepend_space.
2023-08-17 09:01:05 +10:00
rustc_attr
…
rustc_baked_icu_data
…
rustc_borrowck
give some unwind-related terminators a more clear name
2023-08-20 15:52:38 +02:00
rustc_builtin_macros
…
rustc_codegen_cranelift
give some unwind-related terminators a more clear name
2023-08-20 15:52:38 +02:00
rustc_codegen_gcc
Auto merge of #114643 - dpaoliello:inlinedebuginfo, r=wesleywiser
2023-08-22 20:15:29 +00:00
rustc_codegen_llvm
Auto merge of #114643 - dpaoliello:inlinedebuginfo, r=wesleywiser
2023-08-22 20:15:29 +00:00
rustc_codegen_ssa
Auto merge of #114643 - dpaoliello:inlinedebuginfo, r=wesleywiser
2023-08-22 20:15:29 +00:00
rustc_const_eval
avoid return in tail position
2023-08-20 15:52:40 +02:00
rustc_data_structures
…
rustc_driver
…
rustc_driver_impl
…
rustc_error_codes
Fix syntax in E0191 explanation.
2023-08-21 18:45:51 +07:00
rustc_error_messages
…
rustc_errors
fix
2023-08-18 15:19:23 +08:00
rustc_expand
Auto merge of #114915 - nnethercote:Nonterminal-cleanups, r=petrochenkov
2023-08-18 16:07:40 +00:00
rustc_feature
Add the relocation_model to the cfg
2023-08-18 19:57:28 +02:00
rustc_fluent_macro
…
rustc_fs_util
…
rustc_graphviz
…
rustc_hir
Move scrutinee HirId into MatchSource::TryDesugar
2023-08-14 21:43:56 +00:00
rustc_hir_analysis
Allow MaybeUninit in input and output of inline assembly
2023-08-23 21:57:18 +09:00
rustc_hir_pretty
…
rustc_hir_typeck
Auto merge of #115018 - matthiaskrgr:rollup-pxj0qdb, r=matthiaskrgr
2023-08-20 08:11:08 +00:00
rustc_incremental
Ignore unexpected incr-comp session dirs
2023-08-18 19:57:41 +02:00
rustc_index
Convert it into a warning
2023-08-22 09:17:46 +00:00
rustc_infer
Auto merge of #114611 - nnethercote:type-system-chess, r=compiler-errors
2023-08-18 06:29:38 +00:00
rustc_interface
Fix review comment
2023-08-14 16:16:51 +00:00
rustc_lexer
…
rustc_lint
Rollup merge of #115100 - Urgau:invalid_ref_casting-ptr-writes, r=est31
2023-08-23 05:35:17 +00:00
rustc_lint_defs
Auto merge of #115104 - compiler-errors:rollup-8235xz5, r=compiler-errors
2023-08-22 16:16:32 +00:00
rustc_llvm
add a csky-unknown-linux-gnuabiv2 target
2023-08-14 23:02:36 +08:00
rustc_log
…
rustc_macros
Make enum decoding errors more informative.
2023-08-18 16:50:41 +10:00
rustc_metadata
…
rustc_middle
Auto merge of #114993 - RalfJung:panic-nounwind, r=fee1-dead
2023-08-20 22:01:18 +00:00
rustc_mir_build
give some unwind-related terminators a more clear name
2023-08-20 15:52:38 +02:00
rustc_mir_dataflow
give some unwind-related terminators a more clear name
2023-08-20 15:52:38 +02:00
rustc_mir_transform
Auto merge of #115005 - compiler-errors:passes, r=cjgillot
2023-08-22 22:04:49 +00:00
rustc_monomorphize
give some unwind-related terminators a more clear name
2023-08-20 15:52:38 +02:00
rustc_parse
Fix a stack overflow with long else if chains
2023-08-19 13:11:16 +02:00
rustc_parse_format
…
rustc_passes
Contents of reachable statics is reachable
2023-08-22 00:00:00 +00:00
rustc_plugin_impl
…
rustc_privacy
…
rustc_query_impl
…
rustc_query_system
Remove conditional use of Sharded from query caches
2023-08-16 14:16:05 +02:00
rustc_resolve
Rollup merge of #115011 - compiler-errors:warn-on-elided-assoc-ct-lt, r=cjgillot
2023-08-22 09:00:49 -07:00
rustc_serialize
…
rustc_session
unknown unstable lint command line
2023-08-22 18:58:39 +08:00
rustc_smir
add generics_of to smir
2023-08-22 21:47:46 +03:00
rustc_span
Add support for ptr::write for the invalid_reference_casting lint
2023-08-22 15:47:29 +02:00
rustc_symbol_mangling
…
rustc_target
Add the relocation_model to the cfg
2023-08-18 19:57:28 +02:00
rustc_trait_selection
instantiate response: no unnecessary new universe
2023-08-18 23:55:28 +02:00
rustc_traits
…
rustc_transmute
…
rustc_ty_utils
…
rustc_type_ir
Revert "Implement references VarDebugInfo."
2023-08-17 17:02:04 +00:00