5a83d1be66
The general problem we are dealing with here is this: ``` macro_rules! thrice { ($e:expr) => { $e * 3} } fn main() { let x = thrice!(1 + 2); } ``` we really want this to print 9 rather than 7. The way rustc solves this is rather ad-hoc. In rustc, token trees are allowed to include whole AST fragments, so 1+2 is passed through macro expansion as a single unit. This is a significant violation of token tree model. In rust-analyzer, we intended to handle this in a more elegant way, using token trees with "invisible" delimiters. The idea was is that we introduce a new kind of parenthesis, "left $"/"right $", and let the parser intelligently handle this. The idea was inspired by the relevant comment in the proc_macro crate: https://doc.rust-lang.org/stable/proc_macro/enum.Delimiter.html#variant.None > An implicit delimiter, that may, for example, appear around tokens > coming from a “macro variable” $var. It is important to preserve > operator priorities in cases like $var * 3 where $var is 1 + 2. > Implicit delimiters might not survive roundtrip of a token stream > through a string. Now that we are older and wiser, we conclude that the idea doesn't work. _First_, the comment in the proc-macro crate is wishful thinking. Rustc currently completely ignores none delimiters. It solves the (1 + 2) * 3 problem by having magical token trees which can't be duplicated: * https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/TIL.20that.20token.20streams.20are.20magic * https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Handling.20of.20Delimiter.3A.3ANone.20by.20the.20parser _Second_, it's not like our implementation in rust-analyzer works. We special-case expressions (as opposed to treating all kinds of $var captures the same) and we don't know how parser error recovery should work with these dollar-parenthesis. So, in this PR we simplify the whole thing away by not pretending that we are doing something proper and instead just explicitly special-casing expressions by wrapping them into real `()`. In the future, to maintain bug-parity with `rustc` what we are going to do is probably adding an explicit `CAPTURED_EXPR` *token* which we can explicitly account for in the parser. If/when rustc starts handling delimiter=none properly, we'll port that logic as well, in addition to special handling.
122 lines
4.5 KiB
Rust
122 lines
4.5 KiB
Rust
//! This module takes a (parsed) definition of `macro_rules` invocation, a
|
|
//! `tt::TokenTree` representing an argument of macro invocation, and produces a
|
|
//! `tt::TokenTree` for the result of the expansion.
|
|
|
|
mod matcher;
|
|
mod transcriber;
|
|
|
|
use rustc_hash::FxHashMap;
|
|
use syntax::SmolStr;
|
|
|
|
use crate::{ExpandError, ExpandResult};
|
|
|
|
pub(crate) fn expand_rules(
|
|
rules: &[crate::Rule],
|
|
input: &tt::Subtree,
|
|
) -> ExpandResult<tt::Subtree> {
|
|
let mut match_: Option<(matcher::Match, &crate::Rule)> = None;
|
|
for rule in rules {
|
|
let new_match = matcher::match_(&rule.lhs, input);
|
|
|
|
if new_match.err.is_none() {
|
|
// If we find a rule that applies without errors, we're done.
|
|
// Unconditionally returning the transcription here makes the
|
|
// `test_repeat_bad_var` test fail.
|
|
let ExpandResult { value, err: transcribe_err } =
|
|
transcriber::transcribe(&rule.rhs, &new_match.bindings);
|
|
if transcribe_err.is_none() {
|
|
return ExpandResult::ok(value);
|
|
}
|
|
}
|
|
// Use the rule if we matched more tokens, or bound variables count
|
|
if let Some((prev_match, _)) = &match_ {
|
|
if (new_match.unmatched_tts, -(new_match.bound_count as i32))
|
|
< (prev_match.unmatched_tts, -(prev_match.bound_count as i32))
|
|
{
|
|
match_ = Some((new_match, rule));
|
|
}
|
|
} else {
|
|
match_ = Some((new_match, rule));
|
|
}
|
|
}
|
|
if let Some((match_, rule)) = match_ {
|
|
// if we got here, there was no match without errors
|
|
let ExpandResult { value, err: transcribe_err } =
|
|
transcriber::transcribe(&rule.rhs, &match_.bindings);
|
|
ExpandResult { value, err: match_.err.or(transcribe_err) }
|
|
} else {
|
|
ExpandResult::only_err(ExpandError::NoMatchingRule)
|
|
}
|
|
}
|
|
|
|
/// The actual algorithm for expansion is not too hard, but is pretty tricky.
|
|
/// `Bindings` structure is the key to understanding what we are doing here.
|
|
///
|
|
/// On the high level, it stores mapping from meta variables to the bits of
|
|
/// syntax it should be substituted with. For example, if `$e:expr` is matched
|
|
/// with `1 + 1` by macro_rules, the `Binding` will store `$e -> 1 + 1`.
|
|
///
|
|
/// The tricky bit is dealing with repetitions (`$()*`). Consider this example:
|
|
///
|
|
/// ```not_rust
|
|
/// macro_rules! foo {
|
|
/// ($($ i:ident $($ e:expr),*);*) => {
|
|
/// $(fn $ i() { $($ e);*; })*
|
|
/// }
|
|
/// }
|
|
/// foo! { foo 1,2,3; bar 4,5,6 }
|
|
/// ```
|
|
///
|
|
/// Here, the `$i` meta variable is matched first with `foo` and then with
|
|
/// `bar`, and `$e` is matched in turn with `1`, `2`, `3`, `4`, `5`, `6`.
|
|
///
|
|
/// To represent such "multi-mappings", we use a recursive structures: we map
|
|
/// variables not to values, but to *lists* of values or other lists (that is,
|
|
/// to the trees).
|
|
///
|
|
/// For the above example, the bindings would store
|
|
///
|
|
/// ```not_rust
|
|
/// i -> [foo, bar]
|
|
/// e -> [[1, 2, 3], [4, 5, 6]]
|
|
/// ```
|
|
///
|
|
/// We construct `Bindings` in the `match_lhs`. The interesting case is
|
|
/// `TokenTree::Repeat`, where we use `push_nested` to create the desired
|
|
/// nesting structure.
|
|
///
|
|
/// The other side of the puzzle is `expand_subtree`, where we use the bindings
|
|
/// to substitute meta variables in the output template. When expanding, we
|
|
/// maintain a `nesting` stack of indices which tells us which occurrence from
|
|
/// the `Bindings` we should take. We push to the stack when we enter a
|
|
/// repetition.
|
|
///
|
|
/// In other words, `Bindings` is a *multi* mapping from `SmolStr` to
|
|
/// `tt::TokenTree`, where the index to select a particular `TokenTree` among
|
|
/// many is not a plain `usize`, but a `&[usize]`.
|
|
#[derive(Debug, Default, Clone, PartialEq, Eq)]
|
|
struct Bindings {
|
|
inner: FxHashMap<SmolStr, Binding>,
|
|
}
|
|
|
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
|
enum Binding {
|
|
Fragment(Fragment),
|
|
Nested(Vec<Binding>),
|
|
Empty,
|
|
}
|
|
|
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
|
enum Fragment {
|
|
/// token fragments are just copy-pasted into the output
|
|
Tokens(tt::TokenTree),
|
|
/// Expr ast fragments are surrounded with `()` on insertion to preserve
|
|
/// precedence. Note that this impl is different from the one currently in
|
|
/// `rustc` -- `rustc` doesn't translate fragments into token trees at all.
|
|
///
|
|
/// At one point in time, we tried to to use "fake" delimiters here a-la
|
|
/// proc-macro delimiter=none. As we later discovered, "none" delimiters are
|
|
/// tricky to handle in the parser, and rustc doesn't handle those either.
|
|
Expr(tt::TokenTree),
|
|
}
|