mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
939a71162d
rust/compiler
History
bors cb93c24bf3 Auto merge of #124157 - wutchzone:partial_eq, r=estebank 
Do not add leading asterisk in the `PartialEq`

I think we should address this issue, however I am not exactly sure, if this is the right way to do it. It is related to the #123056.

Imagine the simplified code:

```rust
trait MyTrait {}

impl PartialEq for dyn MyTrait {
    fn eq(&self, _other: &Self) -> bool {
        true
    }
}

#[derive(PartialEq)]
enum Bar {
    Foo(Box<dyn MyTrait>),
}
```

On the nightly compiler, the `derive` produces invalid code with the weird error message:
```
error[E0507]: cannot move out of `*__arg1_0` which is behind a shared reference
  --> src/main.rs:11:9
   |
9  | #[derive(PartialEq)]
   |          --------- in this derive macro expansion
10 | enum Things {
11 |     Foo(Box<dyn MyTrait>),
   |         ^^^^^^^^^^^^^^^^ move occurs because `*__arg1_0` has type `Box<dyn MyTrait>`, which does not implement the `Copy` trait
   |
   = note: this error originates in the derive macro `PartialEq` (in Nightly builds, run with -Z macro-backtrace for more info)
```

It may be related to the perfect derive problem, although requiring the _type_ to be `Copy` seems unfortunate because it is not necessary. Besides, we are adding the extra dereference only for the diagnostics?
2024-05-09 08:34:14 +00:00
..
rustc Change SIGPIPE ui from #[unix_sigpipe = "..."] to -Zon-broken-pipe=... 2024-05-02 19:48:29 +02:00
rustc_abi Use generic NonZero. 2024-05-08 21:37:55 +02:00
rustc_arena
rustc_ast Rollup merge of #124587 - reitermarkus:use-generic-nonzero, r=dtolnay 2024-05-08 23:33:25 +02:00
rustc_ast_ir Remove extern crate rustc_macros from numerous crates. 2024-04-29 10:21:54 +10:00
rustc_ast_lowering Rollup merge of #123344 - pietroalbini:pa-unused-imports, r=Nilstrieb 2024-05-08 23:33:24 +02:00
rustc_ast_passes Stabilize exclusive_range 2024-05-02 19:42:31 -04:00
rustc_ast_pretty Rollup merge of #123344 - pietroalbini:pa-unused-imports, r=Nilstrieb 2024-05-08 23:33:24 +02:00
rustc_attr Remove extern crate rustc_macros from numerous crates. 2024-04-29 10:21:54 +10:00
rustc_baked_icu_data
rustc_borrowck Auto merge of #124831 - nnethercote:rustc_data_structures-cleanups, r=michaelwoerister 2024-05-09 04:04:09 +00:00
rustc_builtin_macros Auto merge of #124157 - wutchzone:partial_eq, r=estebank 2024-05-09 08:34:14 +00:00
rustc_codegen_cranelift debuginfo: Stabilize -Z debug-macros, -Z collapse-macro-debuginfo and #[collapse_debuginfo] 2024-04-25 22:14:47 +03:00
rustc_codegen_gcc Simplify use crate::rustc_foo::bar occurrences. 2024-05-08 16:57:31 +10:00
rustc_codegen_llvm Adjust 64-bit ARM data layouts for LLVM update 2024-05-06 16:53:17 +00:00
rustc_codegen_ssa Rollup merge of #124892 - jfgoog:update-cc, r=workingjubilee 2024-05-08 23:33:27 +02:00
rustc_const_eval replace another Option<Span> by DUMMY_SP 2024-05-07 14:52:42 +02:00
rustc_data_structures Remove enum_from_u32. 2024-05-09 09:01:59 +10:00
rustc_driver
rustc_driver_impl compiler: upgrade time from 0.3.34 to 0.3.36 2024-05-04 21:18:41 -07:00
rustc_error_codes Stabilize exclusive_range 2024-05-02 19:42:31 -04:00
rustc_error_messages
rustc_errors Remove some low-value use renamings. 2024-05-03 16:03:12 +10:00
rustc_expand Rollup merge of #123344 - pietroalbini:pa-unused-imports, r=Nilstrieb 2024-05-08 23:33:24 +02:00
rustc_feature Auto merge of #124747 - MasterAwesome:master, r=davidtwco 2024-05-06 00:55:49 +00:00
rustc_fluent_macro
rustc_fs_util Stabilize std::path::absolute 2024-04-24 14:35:02 +00:00
rustc_graphviz
rustc_hir Remove enum_from_u32. 2024-05-09 09:01:59 +10:00
rustc_hir_analysis Auto merge of #124219 - gurry:122989-ice-unexpected-anon-const, r=compiler-errors 2024-05-07 20:01:18 +00:00
rustc_hir_pretty put hir::AnonConst on the hir arena 2024-04-26 12:57:02 +00:00
rustc_hir_typeck Rollup merge of #124876 - nnethercote:rm-use-crate-rustc_foo, r=compiler-errors 2024-05-08 23:33:26 +02:00
rustc_incremental Auto merge of #123441 - saethlin:fixed-len-file-names, r=oli-obk 2024-05-03 17:41:48 +00:00
rustc_index
rustc_index_macros
rustc_infer Rollup merge of #124827 - lcnr:generalize-incomplete, r=compiler-errors 2024-05-07 18:12:55 +02:00
rustc_interface Improve check-cfg CLI errors with more structured diagnostics 2024-05-06 07:44:41 +02:00
rustc_lexer Improved the compiler code with clippy 2024-04-24 09:41:44 +02:00
rustc_lint Rollup merge of #124908 - saethlin:ref-casting_bigger_place_projection, r=fee1-dead 2024-05-09 06:04:40 +02:00
rustc_lint_defs Stabilize exclusive_range 2024-05-02 19:42:31 -04:00
rustc_llvm Update cc crate to v1.0.97 2024-05-08 15:06:35 +00:00
rustc_log
rustc_macros Rollup merge of #124287 - 41Leahcim:master, r=fmease 2024-04-25 18:57:56 +02:00
rustc_metadata Rollup merge of #124582 - RalfJung:std-not-found, r=Nilstrieb 2024-05-02 15:11:22 +02:00
rustc_middle Auto merge of #124831 - nnethercote:rustc_data_structures-cleanups, r=michaelwoerister 2024-05-09 04:04:09 +00:00
rustc_mir_build Auto merge of #124223 - Zalathar:conditional-let, r=compiler-errors 2024-05-07 22:28:51 +00:00
rustc_mir_dataflow Inline & delete Ty::new_unit, since it's just a field access 2024-05-02 17:49:23 +02:00
rustc_mir_transform Simplify use crate::rustc_foo::bar occurrences. 2024-05-08 16:57:31 +10:00
rustc_monomorphize Remove extern crate rustc_middle from numerous crates. 2024-04-29 14:50:45 +10:00
rustc_next_trait_solver Use super_fold in RegionsToStatic visitor 2024-05-06 12:22:15 -04:00
rustc_parse Rollup merge of #123344 - pietroalbini:pa-unused-imports, r=Nilstrieb 2024-05-08 23:33:24 +02:00
rustc_parse_format
rustc_passes Fix Error Messages for break Inside Coroutines 2024-05-08 17:32:25 -04:00
rustc_pattern_analysis Stabilize exclusive_range 2024-05-02 19:42:31 -04:00
rustc_privacy Remove some unneeded Cargo.toml dependencies. 2024-05-03 15:33:52 +10:00
rustc_query_impl Simplify use crate::rustc_foo::bar occurrences. 2024-05-08 16:57:31 +10:00
rustc_query_system Remove some unneeded Cargo.toml dependencies. 2024-05-03 15:33:52 +10:00
rustc_resolve Rollup merge of #123344 - pietroalbini:pa-unused-imports, r=Nilstrieb 2024-05-08 23:33:24 +02:00
rustc_sanitizers
rustc_serialize Step bootstrap cfgs 2024-05-01 22:19:11 -04:00
rustc_session Add rustfmt cfg to well known cfgs list 2024-05-05 14:30:35 +02:00
rustc_smir Rollup merge of #122598 - Nadrieril:full-derefpats, r=matthewjasper 2024-04-23 17:25:15 +02:00
rustc_span Auto merge of #124747 - MasterAwesome:master, r=davidtwco 2024-05-06 00:55:49 +00:00
rustc_symbol_mangling Auto merge of #123441 - saethlin:fixed-len-file-names, r=oli-obk 2024-05-03 17:41:48 +00:00
rustc_target Auto merge of #124858 - alexcrichton:some-wasi-changes, r=michaelwoerister 2024-05-08 11:39:26 +00:00
rustc_trait_selection Fix ICEs in diagnostic::on_unimplemented 2024-05-07 23:13:44 -04:00
rustc_traits Use ObligationCtxt in favor of TraitEngine in many places 2024-05-02 22:03:01 -04:00
rustc_transmute Align: add bytes_usize and bits_usize 2024-05-01 15:57:33 +02:00
rustc_ty_utils Inline & delete Ty::new_unit, since it's just a field access 2024-05-02 17:49:23 +02:00
rustc_type_ir Remove extern crate bitflags from a couple of crates. 2024-04-29 18:47:54 +10:00
stable_mir Use generic NonZero. 2024-05-08 21:37:55 +02:00