0374e6aab7
In preparation for incremental compilation this commit refactors the lint handling infrastructure in the compiler to be more "eager" and overall more incremental-friendly. Many passes of the compiler can emit lints at various points but before this commit all lints were buffered in a table to be emitted at the very end of compilation. This commit changes these lints to be emitted immediately during compilation using pre-calculated lint level-related data structures. Linting today is split into two phases, one set of "early" lints run on the `syntax::ast` and a "late" set of lints run on the HIR. This commit moves the "early" lints to running as late as possible in compilation, just before HIR lowering. This notably means that we're catching resolve-related lints just before HIR lowering. The early linting remains a pass very similar to how it was before, maintaining context of the current lint level as it walks the tree. Post-HIR, however, linting is structured as a method on the `TyCtxt` which transitively executes a query to calculate lint levels. Each request to lint on a `TyCtxt` will query the entire crate's 'lint level data structure' and then go from there about whether the lint should be emitted or not. The query depends on the entire HIR crate but should be very quick to calculate (just a quick walk of the HIR) and the red-green system should notice that the lint level data structure rarely changes, and should hopefully preserve incrementality. Overall this resulted in a pretty big change to the test suite now that lints are emitted much earlier in compilation (on-demand vs only at the end). This in turn necessitated the addition of many `#![allow(warnings)]` directives throughout the compile-fail test suite and a number of updates to the UI test suite.
42 lines
1.2 KiB
Rust
42 lines
1.2 KiB
Rust
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution and at
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
#![warn(unused)]
|
|
#![allow(dead_code)]
|
|
#![deny(non_snake_case)]
|
|
|
|
mod foo {
|
|
pub enum Foo { Foo }
|
|
}
|
|
|
|
struct Something {
|
|
X: usize //~ ERROR structure field `X` should have a snake case name such as `x`
|
|
}
|
|
|
|
fn test(Xx: usize) { //~ ERROR variable `Xx` should have a snake case name such as `xx`
|
|
println!("{}", Xx);
|
|
}
|
|
|
|
fn main() {
|
|
let Test: usize = 0; //~ ERROR variable `Test` should have a snake case name such as `test`
|
|
println!("{}", Test);
|
|
|
|
match foo::Foo::Foo {
|
|
Foo => {}
|
|
//~^ ERROR variable `Foo` should have a snake case name such as `foo`
|
|
//~^^ WARN `Foo` is named the same as one of the variants of the type `foo::Foo`
|
|
//~^^^ WARN unused variable: `Foo`
|
|
}
|
|
|
|
test(1);
|
|
|
|
let _ = Something { X: 0 };
|
|
}
|