d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
57 lines
1.8 KiB
Rust
57 lines
1.8 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_help;
|
|
use clippy_utils::is_direct_expn_of;
|
|
use if_chain::if_chain;
|
|
use rustc_ast::ast::{Expr, ExprKind};
|
|
use rustc_lint::{EarlyContext, EarlyLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::sym;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for usage of `option_env!(...).unwrap()` and
|
|
/// suggests usage of the `env!` macro.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Unwrapping the result of `option_env!` will panic
|
|
/// at run-time if the environment variable doesn't exist, whereas `env!`
|
|
/// catches it at compile-time.
|
|
///
|
|
/// ### Example
|
|
/// ```rust,no_run
|
|
/// let _ = option_env!("HOME").unwrap();
|
|
/// ```
|
|
///
|
|
/// Is better expressed as:
|
|
///
|
|
/// ```rust,no_run
|
|
/// let _ = env!("HOME");
|
|
/// ```
|
|
#[clippy::version = "1.43.0"]
|
|
pub OPTION_ENV_UNWRAP,
|
|
correctness,
|
|
"using `option_env!(...).unwrap()` to get environment variable"
|
|
}
|
|
|
|
declare_lint_pass!(OptionEnvUnwrap => [OPTION_ENV_UNWRAP]);
|
|
|
|
impl EarlyLintPass for OptionEnvUnwrap {
|
|
fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) {
|
|
if_chain! {
|
|
if let ExprKind::MethodCall(path_segment, args, _) = &expr.kind;
|
|
if matches!(path_segment.ident.name, sym::expect | sym::unwrap);
|
|
if let ExprKind::Call(caller, _) = &args[0].kind;
|
|
if is_direct_expn_of(caller.span, "option_env").is_some();
|
|
then {
|
|
span_lint_and_help(
|
|
cx,
|
|
OPTION_ENV_UNWRAP,
|
|
expr.span,
|
|
"this will panic at run-time if the environment variable doesn't exist at compile-time",
|
|
None,
|
|
"consider using the `env!` macro instead"
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|