d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
63 lines
1.8 KiB
Rust
63 lines
1.8 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_note;
|
|
use clippy_utils::ty::is_copy;
|
|
use rustc_hir::{Impl, Item, ItemKind};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::sym;
|
|
|
|
use if_chain::if_chain;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for types that implement `Copy` as well as
|
|
/// `Iterator`.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Implicit copies can be confusing when working with
|
|
/// iterator combinators.
|
|
///
|
|
/// ### Example
|
|
/// ```rust,ignore
|
|
/// #[derive(Copy, Clone)]
|
|
/// struct Countdown(u8);
|
|
///
|
|
/// impl Iterator for Countdown {
|
|
/// // ...
|
|
/// }
|
|
///
|
|
/// let a: Vec<_> = my_iterator.take(1).collect();
|
|
/// let b: Vec<_> = my_iterator.collect();
|
|
/// ```
|
|
#[clippy::version = "1.30.0"]
|
|
pub COPY_ITERATOR,
|
|
pedantic,
|
|
"implementing `Iterator` on a `Copy` type"
|
|
}
|
|
|
|
declare_lint_pass!(CopyIterator => [COPY_ITERATOR]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for CopyIterator {
|
|
fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'_>) {
|
|
if_chain! {
|
|
if let ItemKind::Impl(Impl {
|
|
of_trait: Some(ref trait_ref),
|
|
..
|
|
}) = item.kind;
|
|
let ty = cx.tcx.type_of(item.def_id);
|
|
if is_copy(cx, ty);
|
|
if let Some(trait_id) = trait_ref.trait_def_id();
|
|
if cx.tcx.is_diagnostic_item(sym::Iterator, trait_id);
|
|
then {
|
|
span_lint_and_note(
|
|
cx,
|
|
COPY_ITERATOR,
|
|
item.span,
|
|
"you are implementing `Iterator` on a `Copy` type",
|
|
None,
|
|
"consider implementing `IntoIterator` instead",
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|