d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
82 lines
2.5 KiB
Rust
82 lines
2.5 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_help;
|
|
use clippy_utils::{meets_msrv, msrvs};
|
|
use if_chain::if_chain;
|
|
use rustc_hir as hir;
|
|
use rustc_lint::{LateContext, LateLintPass, LintContext};
|
|
use rustc_semver::RustcVersion;
|
|
use rustc_session::{declare_tool_lint, impl_lint_pass};
|
|
use rustc_span::symbol::sym;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Searches for implementations of the `Into<..>` trait and suggests to implement `From<..>` instead.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// According the std docs implementing `From<..>` is preferred since it gives you `Into<..>` for free where the reverse isn't true.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// struct StringWrapper(String);
|
|
///
|
|
/// impl Into<StringWrapper> for String {
|
|
/// fn into(self) -> StringWrapper {
|
|
/// StringWrapper(self)
|
|
/// }
|
|
/// }
|
|
/// ```
|
|
/// Use instead:
|
|
/// ```rust
|
|
/// struct StringWrapper(String);
|
|
///
|
|
/// impl From<String> for StringWrapper {
|
|
/// fn from(s: String) -> StringWrapper {
|
|
/// StringWrapper(s)
|
|
/// }
|
|
/// }
|
|
/// ```
|
|
#[clippy::version = "1.51.0"]
|
|
pub FROM_OVER_INTO,
|
|
style,
|
|
"Warns on implementations of `Into<..>` to use `From<..>`"
|
|
}
|
|
|
|
pub struct FromOverInto {
|
|
msrv: Option<RustcVersion>,
|
|
}
|
|
|
|
impl FromOverInto {
|
|
#[must_use]
|
|
pub fn new(msrv: Option<RustcVersion>) -> Self {
|
|
FromOverInto { msrv }
|
|
}
|
|
}
|
|
|
|
impl_lint_pass!(FromOverInto => [FROM_OVER_INTO]);
|
|
|
|
impl LateLintPass<'_> for FromOverInto {
|
|
fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx hir::Item<'_>) {
|
|
if !meets_msrv(self.msrv.as_ref(), &msrvs::RE_REBALANCING_COHERENCE) {
|
|
return;
|
|
}
|
|
|
|
if_chain! {
|
|
if let hir::ItemKind::Impl{ .. } = &item.kind;
|
|
if let Some(impl_trait_ref) = cx.tcx.impl_trait_ref(item.def_id);
|
|
if cx.tcx.is_diagnostic_item(sym::Into, impl_trait_ref.def_id);
|
|
|
|
then {
|
|
span_lint_and_help(
|
|
cx,
|
|
FROM_OVER_INTO,
|
|
cx.tcx.sess.source_map().guess_head_span(item.span),
|
|
"an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true",
|
|
None,
|
|
&format!("consider to implement `From<{}>` instead", impl_trait_ref.self_ty()),
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
extract_msrv_attr!(LateContext);
|
|
}
|