cde0cde151
In the stabilization attempt of `#[unix_sigpipe = "sig_dfl"]`, a concern was raised related to using a language attribute for the feature: Long term, we want `fn lang_start()` to be definable by any crate, not just libstd. Having a special language attribute in that case becomes awkward. So as a first step towards towards the next stabilization attempt, this PR changes the `#[unix_sigpipe = "..."]` attribute to a compiler flag `-Zon-broken-pipe=...` to remove that concern, since now the language is not "contaminated" by this feature. Another point was also raised, namely that the ui should not leak **how** it does things, but rather what the **end effect** is. The new flag uses the proposed naming. This is of course something that can be iterated on further before stabilization.
50 lines
1.8 KiB
Rust
50 lines
1.8 KiB
Rust
//@ revisions: default error kill inherit
|
|
//@ ignore-cross-compile because aux-bin does not yet support it
|
|
//@ only-unix because SIGPIPE is a unix thing
|
|
//@ run-pass
|
|
//@ aux-bin:assert-sigpipe-disposition.rs
|
|
//@ aux-crate:sigpipe_utils=sigpipe-utils.rs
|
|
//@ [kill] compile-flags: -Zunstable-options -Zon-broken-pipe=kill
|
|
//@ [error] compile-flags: -Zunstable-options -Zon-broken-pipe=error
|
|
//@ [inherit] compile-flags: -Zunstable-options -Zon-broken-pipe=inherit
|
|
|
|
// Checks the signal disposition of `SIGPIPE` in child processes, and in our own
|
|
// process for robustness.
|
|
|
|
extern crate sigpipe_utils;
|
|
|
|
use sigpipe_utils::*;
|
|
|
|
fn main() {
|
|
// By default we get SIG_IGN but the child gets SIG_DFL through an explicit
|
|
// reset before exec:
|
|
// https://github.com/rust-lang/rust/blob/bf4de3a874753bbee3323081c8b0c133444fed2d/library/std/src/sys/pal/unix/process/process_unix.rs#L363-L384
|
|
#[cfg(default)]
|
|
let (we_expect, child_expects) = (SignalHandler::Ignore, "SIG_DFL");
|
|
|
|
// We get SIG_DFL and the child does too without any special code running
|
|
// before exec.
|
|
#[cfg(kill)]
|
|
let (we_expect, child_expects) = (SignalHandler::Default, "SIG_DFL");
|
|
|
|
// We get SIG_IGN and the child does too without any special code running
|
|
// before exec.
|
|
#[cfg(error)]
|
|
let (we_expect, child_expects) = (SignalHandler::Ignore, "SIG_IGN");
|
|
|
|
// We get SIG_DFL and the child does too without any special code running
|
|
// before exec.
|
|
#[cfg(inherit)]
|
|
let (we_expect, child_expects) = (SignalHandler::Default, "SIG_DFL");
|
|
|
|
assert_sigpipe_handler(we_expect);
|
|
|
|
assert!(
|
|
std::process::Command::new("./auxiliary/bin/assert-sigpipe-disposition")
|
|
.arg(child_expects)
|
|
.status()
|
|
.unwrap()
|
|
.success()
|
|
);
|
|
}
|