bors 7a870aef1a Auto merge of #10432 - samueltardieu:issue-10430, r=Manishearth ...

New lint: detect `if` expressions with simple boolean assignments to the same target

Closes #10430

changelog: [`needless_bool_assign`] new lint to detect simple boolean assignment to the same target in `if` branches

2023-04-23 15:47:00 +00:00

..

cargo

…

casts

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

functions

Update version attribute for 1.69 lints

2023-04-19 14:55:18 +02:00

loops

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

matches

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

methods

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

misc_early

…

operators

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

transmute

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

types

Standardize lint formulation

2023-04-12 13:48:03 +02:00

unit_types

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

utils

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

allow_attributes.rs

Standardize lint formulation

2023-04-12 13:48:03 +02:00

almost_complete_range.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

approx_const.rs

…

as_conversions.rs

…

asm_syntax.rs

…

assertions_on_constants.rs

…

assertions_on_result_states.rs

…

async_yields_async.rs

…

attrs.rs

…

await_holding_invalid.rs

…

blocks_in_if_conditions.rs

…

bool_assert_comparison.rs

Alloc hir::Lit in an arena to remove the destructor from Expr

2023-04-16 15:35:51 +00:00

bool_to_int_with_if.rs

…

booleans.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

borrow_deref_ref.rs

…

box_default.rs

…

checked_conversions.rs

…

cognitive_complexity.rs

Use local key in providers

2023-03-21 15:38:51 +00:00

collapsible_if.rs

…

collection_is_never_read.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

comparison_chain.rs

…

copies.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

copy_iterator.rs

…

crate_in_macro_def.rs

Standardize lint formulation

2023-04-12 13:48:03 +02:00

create_dir.rs

…

dbg_macro.rs

…

declared_lints.rs

Auto merge of #10432 - samueltardieu:issue-10430, r=Manishearth

2023-04-23 15:47:00 +00:00

default_instead_of_iter_empty.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

default_numeric_fallback.rs

…

default_union_representation.rs

…

default.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

deprecated_lints.rs

…

dereference.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

derivable_impls.rs

Use local key in providers

2023-03-21 15:38:51 +00:00

derive.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

disallowed_macros.rs

…

disallowed_methods.rs

…

disallowed_names.rs

…

disallowed_script_idents.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

disallowed_types.rs

…

doc.rs

Revert "Dogfood missing_assert_message on Clippy"

2023-03-08 08:51:50 +00:00

double_parens.rs

…

drop_forget_ref.rs

…

duplicate_mod.rs

Revert "Dogfood missing_assert_message on Clippy"

2023-03-08 08:51:50 +00:00

else_if_without_else.rs

…

empty_drop.rs

…

empty_enum.rs

…

empty_structs_with_brackets.rs

…

entry.rs

Standardize lint formulation

2023-04-12 13:48:03 +02:00

enum_clike.rs

…

enum_variants.rs

Fix #[allow(clippy::enum_variant_names)] directly on variants

2023-04-22 14:53:15 +00:00

equatable_if_let.rs

…

escape.rs

…

eta_reduction.rs

…

excessive_bools.rs

…

exhaustive_items.rs

…

exit.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

explicit_write.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

extra_unused_type_parameters.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

fallible_impl_from.rs

…

float_literal.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

floating_point_arithmetic.rs

Auto merge of #10670 - lukaslueg:issue10634, r=Jarcho

2023-04-23 13:23:48 +00:00

fn_null_check.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

format_args.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

format_impl.rs

Standardize lint formulation

2023-04-12 13:48:03 +02:00

format_push_string.rs

…

format.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

formatting.rs

Standardize lint formulation

2023-04-12 13:48:03 +02:00

from_over_into.rs

…

from_raw_with_void_ptr.rs

…

from_str_radix_10.rs

…

future_not_send.rs

remove some trait solver helpers

2023-03-21 09:57:20 +01:00

if_let_mutex.rs

…

if_not_else.rs

…

if_then_some_else_none.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

implicit_hasher.rs

…

implicit_return.rs

…

implicit_saturating_add.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

implicit_saturating_sub.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

inconsistent_struct_constructor.rs

…

index_refutable_slice.rs

…

indexing_slicing.rs

…

infinite_iter.rs

Remove box expressions from HIR

2023-03-14 17:18:26 +00:00

inherent_impl.rs

…

inherent_to_string.rs

…

init_numbered_fields.rs

…

inline_fn_without_body.rs

…

instant_subtraction.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

int_plus_one.rs

…

invalid_upcast_comparisons.rs

…

invalid_utf8_in_unchecked.rs

…

items_after_statements.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

items_after_test_module.rs

Compact emmited lint

2023-04-22 21:12:55 +02:00

iter_not_returning_iterator.rs

…

large_const_arrays.rs

…

large_enum_variant.rs

…

large_futures.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

large_include_file.rs

…

large_stack_arrays.rs

…

len_zero.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

let_if_seq.rs

…

let_underscore.rs

Ignore impl Trait(s)

2023-04-23 12:09:36 +02:00

let_with_type_underscore.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

lib.deprecated.rs

…

lib.rs

Add lint items_after_test_module

2023-04-22 21:12:45 +02:00

lifetimes.rs

…

lines_filter_map_ok.rs

Standardize lint formulation

2023-04-12 13:48:03 +02:00

literal_representation.rs

…

macro_use.rs

…

main_recursion.rs

…

manual_assert.rs

…

manual_async_fn.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

manual_bits.rs

Standardize lint formulation

2023-04-12 13:48:03 +02:00

manual_clamp.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

manual_is_ascii_check.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

manual_let_else.rs

…

manual_main_separator_str.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

manual_non_exhaustive.rs

…

manual_rem_euclid.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

manual_retain.rs

…

manual_slice_size_calculation.rs

Ignore manual_slice_size_calculation in code from macro expansions

2023-04-18 17:54:26 +00:00

manual_string_new.rs

…

manual_strip.rs

Alloc hir::Lit in an arena to remove the destructor from Expr

2023-04-16 15:35:51 +00:00

map_unit_fn.rs

…

match_result_ok.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

mem_forget.rs

…

mem_replace.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

minmax.rs

…

misc.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

mismatching_type_param_order.rs

…

missing_assert_message.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

missing_const_for_fn.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

missing_doc.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

missing_enforced_import_rename.rs

…

missing_inline.rs

…

missing_trait_methods.rs

…

mixed_read_write_in_expression.rs

…

module_style.rs

…

multi_assignments.rs

…

multiple_unsafe_ops_per_block.rs

Update version attribute for 1.69 lints

2023-04-19 14:55:18 +02:00

mut_key.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

mut_mut.rs

…

mut_reference.rs

…

mutable_debug_assertion.rs

…

mutex_atomic.rs

Standardize lint formulation

2023-04-12 13:48:03 +02:00

needless_arbitrary_self_type.rs

…

needless_bool.rs

Auto merge of #10432 - samueltardieu:issue-10430, r=Manishearth

2023-04-23 15:47:00 +00:00

needless_borrowed_ref.rs

…

needless_continue.rs

…

needless_for_each.rs

…

needless_late_init.rs

…

needless_parens_on_range_literals.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

needless_pass_by_value.rs

Make elaborator generic

2023-04-06 23:30:22 +00:00

needless_question_mark.rs

…

needless_update.rs

…

neg_cmp_op_on_partial_ord.rs

…

neg_multiply.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

new_without_default.rs

…

no_effect.rs

Remove box expressions from HIR

2023-03-14 17:18:26 +00:00

no_mangle_with_rust_abi.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

non_copy_const.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

non_expressive_names.rs

Revert "Dogfood missing_assert_message on Clippy"

2023-03-08 08:51:50 +00:00

non_octal_unix_permissions.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

non_send_fields_in_send_ty.rs

…

nonstandard_macro_braces.rs

…

octal_escapes.rs

fix

2023-04-06 16:31:50 +02:00

only_used_in_recursion.rs

…

option_env_unwrap.rs

…

option_if_let_else.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

overflow_check_conditional.rs

…

panic_in_result_fn.rs

…

panic_unimplemented.rs

…

partial_pub_fields.rs

…

partialeq_ne_impl.rs

Use local key in providers

2023-03-21 15:38:51 +00:00

partialeq_to_none.rs

…

pass_by_ref_or_value.rs

…

pattern_type_mismatch.rs

…

permissions_set_readonly_false.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

precedence.rs

…

ptr_offset_with_cast.rs

…

ptr.rs

…

pub_use.rs

…

question_mark_used.rs

Update version attribute for 1.69 lints

2023-04-19 14:55:18 +02:00

question_mark.rs

…

ranges.rs

…

rc_clone_in_vec_init.rs

…

read_zero_byte_vec.rs

…

redundant_async_block.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

redundant_clone.rs

…

redundant_closure_call.rs

…

redundant_else.rs

…

redundant_field_names.rs

…

redundant_pub_crate.rs

…

redundant_slicing.rs

…

redundant_static_lifetimes.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

ref_option_ref.rs

Add (..) syntax for RTN

2023-03-28 01:14:28 +00:00

reference.rs

…

regex.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

renamed_lints.rs

…

return_self_not_must_use.rs

…

returns.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

same_name_method.rs

…

self_named_constructors.rs

…

semicolon_block.rs

…

semicolon_if_nothing_returned.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

serde_api.rs

…

shadow.rs

Remove box expressions from HIR

2023-03-14 17:18:26 +00:00

significant_drop_tightening.rs

Fix typo in significant_drop_tightening

2023-04-20 20:59:59 +02:00

single_char_lifetime_names.rs

…

single_component_path_imports.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

size_of_in_element_count.rs

…

size_of_ref.rs

Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup

2023-03-10 10:53:50 +01:00

slow_vector_initialization.rs

…

std_instead_of_core.rs

…

strings.rs

…

strlen_on_c_strings.rs

…

suspicious_doc_comments.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

suspicious_operation_groupings.rs

Remove the NodeId of ast::ExprKind::Async

2023-03-19 19:01:31 +01:00

suspicious_trait_impl.rs

…

suspicious_xor_used_as_pow.rs

…

swap_ptr_to_ref.rs

…

swap.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

tabs_in_doc_comments.rs

…

temporary_assignment.rs

…

tests_outside_test_module.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

to_digit_is_some.rs

…

trailing_empty_array.rs

…

trait_bounds.rs

…

undocumented_unsafe_blocks.rs

…

unicode.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-04-23 03:39:03 -07:00

uninit_vec.rs

…

unit_return_expecting_ord.rs

…

unnamed_address.rs

…

unnecessary_box_returns.rs

Add size-parameter to unecessary_box_returns

2023-04-19 14:32:05 +02:00

unnecessary_owned_empty_strings.rs

…

unnecessary_self_imports.rs

…

unnecessary_struct_initialization.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

unnecessary_wraps.rs

…

unnested_or_patterns.rs

…

unsafe_removed_from_name.rs

…

unused_async.rs

…

unused_io_amount.rs

…

unused_peekable.rs

…

unused_rounding.rs

…

unused_self.rs

…

unused_unit.rs

…

unwrap_in_result.rs

…

unwrap.rs

…

upper_case_acronyms.rs

…

use_self.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

useless_conversion.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

vec_init_then_push.rs

…

vec.rs

…

wildcard_imports.rs

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

2023-03-24 14:26:19 +01:00

write.rs

Standardize lint formulation

2023-04-12 13:48:03 +02:00

zero_div_zero.rs

…

zero_sized_map_values.rs

…