bors 78e36d9f53 Auto merge of #10996 - Centri3:mem_forget, r=xFrednet ...

Lint `mem_forget` if any fields are `Drop`

Closes #9298
I think this way of doing it (`needs_drop`) should be fine.

---

changelog: Enhancement: [`mem_forget`]: Now lints on types with fields that implement `Drop`
[#10996](https://github.com/rust-lang/rust-clippy/pull/10996)

2023-06-25 09:40:13 +00:00

..

cargo

…

casts

Auto merge of #10948 - Centri3:borrow_as_ptr, r=dswij

2023-06-21 17:07:52 +00:00

functions

…

loops

Reborrow mutable references in explicit_iter_loop

2023-06-09 21:40:03 -04:00

matches

Auto merge of #10990 - y21:issue8634-partial, r=blyxyas,xFrednet

2023-06-20 13:57:19 +00:00

methods

Auto merge of #10979 - y21:issue9909, r=giraffate

2023-06-21 23:57:02 +00:00

misc_early

Reborrow mutable references in explicit_iter_loop

2023-06-09 21:40:03 -04:00

operators

Fix #10792

2023-06-17 17:03:31 -03:00

transmute

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

types

…

unit_types

…

utils

Auto merge of #10994 - y21:issue8772, r=giraffate

2023-06-23 00:31:04 +00:00

allow_attributes.rs

remove tuple

2023-06-03 14:38:16 -05:00

almost_complete_range.rs

…

approx_const.rs

…

arc_with_non_send_sync.rs

Swapping to matches macro.

2023-06-08 00:38:18 -07:00

as_conversions.rs

Don't ling as_conversions in proc macros

2023-06-08 19:04:35 +01:00

asm_syntax.rs

…

assertions_on_constants.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

assertions_on_result_states.rs

…

async_yields_async.rs

…

attrs.rs

Reborrow mutable references in explicit_iter_loop

2023-06-09 21:40:03 -04:00

await_holding_invalid.rs

…

blocks_in_if_conditions.rs

…

bool_assert_comparison.rs

…

bool_to_int_with_if.rs

…

booleans.rs

Auto merge of #10814 - y21:issue10743, r=llogiq

2023-06-03 15:57:36 +00:00

borrow_deref_ref.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

box_default.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

checked_conversions.rs

…

cognitive_complexity.rs

…

collapsible_if.rs

…

collection_is_never_read.rs

Update version attribute for 1.70 lints

2023-05-29 00:46:29 +02:00

comparison_chain.rs

…

copies.rs

…

copy_iterator.rs

…

crate_in_macro_def.rs

…

create_dir.rs

…

dbg_macro.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

declared_lints.rs

move to drop_forget_ref

2023-06-21 15:56:24 -05:00

default_constructed_unit_structs.rs

Add lint to check lint formulation messages

2023-06-03 00:00:30 +05:30

default_instead_of_iter_empty.rs

…

default_numeric_fallback.rs

Reborrow mutable references in explicit_iter_loop

2023-06-09 21:40:03 -04:00

default_union_representation.rs

…

default.rs

…

deprecated_lints.rs

…

dereference.rs

Auto merge of #10855 - Centri3:explicit_deref_methods, r=llogiq

2023-06-04 14:40:50 +00:00

derivable_impls.rs

fix internal lints

2023-06-14 17:15:57 +02:00

derive.rs

…

disallowed_macros.rs

…

disallowed_methods.rs

…

disallowed_names.rs

…

disallowed_script_idents.rs

…

disallowed_types.rs

…

doc.rs

Exlude todo!() from missing_panics_in_doc

2023-06-17 23:20:33 +08:00

double_parens.rs

…

drop_forget_ref.rs

make note less verbose

2023-06-25 04:28:40 -05:00

duplicate_mod.rs

…

else_if_without_else.rs

…

empty_drop.rs

…

empty_enum.rs

…

empty_structs_with_brackets.rs

…

endian_bytes.rs

derive Copy/PartialEq for Prefix

2023-06-03 14:31:40 -05:00

entry.rs

…

enum_clike.rs

Fix #10792

2023-06-17 17:03:31 -03:00

enum_variants.rs

allow disabling module inception on private modules

2023-06-10 08:09:07 -05:00

equatable_if_let.rs

…

escape.rs

…

eta_reduction.rs

actually don't lint for inclusive range

2023-06-08 00:34:23 +02:00

excessive_bools.rs

…

excessive_nesting.rs

Update excessive_nesting.rs

2023-06-09 16:29:34 -05:00

exhaustive_items.rs

…

exit.rs

…

explicit_write.rs

…

extra_unused_type_parameters.rs

Avoid linting on procedural macros

2023-06-24 19:45:16 -03:00

fallible_impl_from.rs

…

float_literal.rs

Don't lint excessive_precision on inf

2023-06-15 06:16:04 -05:00

floating_point_arithmetic.rs

Fix #10792

2023-06-17 17:03:31 -03:00

fn_null_check.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

format_args.rs

…

format_impl.rs

…

format_push_string.rs

[format_push_string]: look through match, if, if-let

2023-06-24 19:54:12 +02:00

format.rs

…

formatting.rs

Don't warn if there is a comment between else and curly bracket

2023-06-07 09:42:37 +01:00

from_over_into.rs

Auto merge of #10840 - Alexendoo:from-over-into-expanded-path, r=dswij

2023-06-15 07:14:40 +00:00

from_raw_with_void_ptr.rs

…

from_str_radix_10.rs

…

future_not_send.rs

…

if_let_mutex.rs

…

if_not_else.rs

…

if_then_some_else_none.rs

…

implicit_hasher.rs

…

implicit_return.rs

…

implicit_saturating_add.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

implicit_saturating_sub.rs

…

inconsistent_struct_constructor.rs

…

incorrect_impls.rs

rename lint and disallow clone_from

2023-06-15 07:04:47 -05:00

index_refutable_slice.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

indexing_slicing.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

infinite_iter.rs

…

inherent_impl.rs

…

inherent_to_string.rs

…

init_numbered_fields.rs

…

inline_fn_without_body.rs

…

instant_subtraction.rs

…

int_plus_one.rs

…

invalid_upcast_comparisons.rs

…

items_after_statements.rs

…

items_after_test_module.rs

Ignore in-proc-macros items

2023-06-19 20:50:24 +02:00

iter_not_returning_iterator.rs

…

large_const_arrays.rs

…

large_enum_variant.rs

…

large_futures.rs

Update version attribute for 1.70 lints

2023-05-29 00:46:29 +02:00

large_include_file.rs

…

large_stack_arrays.rs

consider array initializer for large_stack_arrays

2023-05-21 15:02:51 +02:00

large_stack_frames.rs

make lint description easier to read, prevent ICE

2023-06-12 12:21:38 +02:00

len_zero.rs

…

let_if_seq.rs

…

let_underscore.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

let_with_type_underscore.rs

check for _ instead

2023-06-06 21:01:14 -05:00

lib.deprecated.rs

…

lib.rs

Auto merge of #10996 - Centri3:mem_forget, r=xFrednet

2023-06-25 09:40:13 +00:00

lifetimes.rs

[needless_lifetimes]' suggestion now points at the lifetimes

2023-06-13 14:05:22 -05:00

lines_filter_map_ok.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

literal_representation.rs

…

macro_use.rs

Reborrow mutable references in explicit_iter_loop

2023-06-09 21:40:03 -04:00

main_recursion.rs

…

manual_assert.rs

…

manual_async_fn.rs

…

manual_bits.rs

…

manual_clamp.rs

…

manual_is_ascii_check.rs

…

manual_let_else.rs

Support struct patterns

2023-06-02 14:46:27 +02:00

manual_main_separator_str.rs

…

manual_non_exhaustive.rs

…

manual_rem_euclid.rs

…

manual_retain.rs

…

manual_slice_size_calculation.rs

…

manual_string_new.rs

…

manual_strip.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

map_unit_fn.rs

…

match_result_ok.rs

…

mem_replace.rs

…

min_ident_chars.rs

refactor and add link to issue

2023-06-12 03:22:01 -05:00

minmax.rs

Fix #10792

2023-06-17 17:03:31 -03:00

misc.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

mismatching_type_param_order.rs

Reborrow mutable references in explicit_iter_loop

2023-06-09 21:40:03 -04:00

missing_assert_message.rs

Update version attribute for 1.70 lints

2023-05-29 00:46:29 +02:00

missing_const_for_fn.rs

Use Cow in {D,Subd}iagnosticMessage.

2023-05-29 09:23:43 +10:00

missing_doc.rs

…

missing_enforced_import_rename.rs

…

missing_fields_in_debug.rs

don't call type_of on generic params

2023-06-06 01:23:42 +02:00

missing_inline.rs

…

missing_trait_methods.rs

…

mixed_read_write_in_expression.rs

refactor

2023-06-09 15:32:42 -05:00

module_style.rs

Move continue into if statement

2023-06-19 08:36:27 +08:00

multi_assignments.rs

…

multiple_unsafe_ops_per_block.rs

Make EarlyBinder's inner value private; and fix all of the resulting errors

2023-05-28 10:44:53 -06:00

mut_key.rs

…

mut_mut.rs

…

mut_reference.rs

…

mutable_debug_assertion.rs

…

mutex_atomic.rs

…

needless_arbitrary_self_type.rs

…

needless_bool.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

needless_borrowed_ref.rs

…

needless_continue.rs

…

needless_else.rs

Ignore #[cfg]'d out code in needless_else

2023-05-24 21:45:46 +00:00

needless_for_each.rs

…

needless_if.rs

Don't lint non-statement/faux empty needless_ifs

2023-06-12 15:19:00 +00:00

needless_late_init.rs

…

needless_parens_on_range_literals.rs

…

needless_pass_by_value.rs

Remove dead code in needless_pass_by_value

2023-06-13 17:08:51 +02:00

needless_question_mark.rs

…

needless_update.rs

…

neg_cmp_op_on_partial_ord.rs

…

neg_multiply.rs

…

new_without_default.rs

…

no_effect.rs

[no_effect]: suggest adding return if applicable

2023-06-13 13:23:33 -05:00

no_mangle_with_rust_abi.rs

…

non_copy_const.rs

…

non_expressive_names.rs

…

non_octal_unix_permissions.rs

…

non_send_fields_in_send_ty.rs

…

nonstandard_macro_braces.rs

Add spans to clippy.toml error messages

2023-06-02 00:56:27 +01:00

octal_escapes.rs

…

only_used_in_recursion.rs

…

option_env_unwrap.rs

…

option_if_let_else.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

overflow_check_conditional.rs

…

panic_in_result_fn.rs

…

panic_unimplemented.rs

…

partial_pub_fields.rs

…

partialeq_ne_impl.rs

…

partialeq_to_none.rs

…

pass_by_ref_or_value.rs

…

pattern_type_mismatch.rs

…

permissions_set_readonly_false.rs

…

precedence.rs

…

ptr_offset_with_cast.rs

…

ptr.rs

Don't lint ptr_arg when return type uses Cow's lifetime

2023-06-24 03:26:40 -05:00

pub_use.rs

…

question_mark_used.rs

…

question_mark.rs

…

ranges.rs

Fix #10792

2023-06-17 17:03:31 -03:00

rc_clone_in_vec_init.rs

…

read_zero_byte_vec.rs

…

redundant_async_block.rs

Update version attribute for 1.70 lints

2023-05-29 00:46:29 +02:00

redundant_clone.rs

use PlaceRef abstractions

2023-06-19 03:44:04 -04:00

redundant_closure_call.rs

don't unnecessarily walk more in visitor and add more tests

2023-06-15 22:04:25 +02:00

redundant_else.rs

…

redundant_field_names.rs

…

redundant_pub_crate.rs

…

redundant_slicing.rs

…

redundant_static_lifetimes.rs

…

redundant_type_annotations.rs

Add Limitations section

2023-06-05 10:22:46 +02:00

ref_option_ref.rs

…

ref_patterns.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

reference.rs

…

regex.rs

Fixing invalid_regex with invalid UTF8. Also, adding more test cases

2023-05-28 12:53:03 +01:00

renamed_lints.rs

Drop uplifted clippy::cast_ref_to_mut

2023-05-31 13:42:53 +02:00

return_self_not_must_use.rs

…

returns.rs

Reborrow mutable references in explicit_iter_loop

2023-06-09 21:40:03 -04:00

same_name_method.rs

…

self_named_constructors.rs

…

semicolon_block.rs

…

semicolon_if_nothing_returned.rs

…

serde_api.rs

…

shadow.rs

…

significant_drop_tightening.rs

Reborrow mutable references in explicit_iter_loop

2023-06-09 21:40:03 -04:00

single_call_fn.rs

Ignore functions annotated with #[test]

2023-06-18 19:32:38 -05:00

single_char_lifetime_names.rs

…

single_component_path_imports.rs

…

single_range_in_vec_init.rs

refactor a bit

2023-06-14 08:41:20 -05:00

size_of_in_element_count.rs

…

size_of_ref.rs

…

slow_vector_initialization.rs

…

std_instead_of_core.rs

…

strings.rs

Merge remote-tracking branch 'upstream/master' into rustup

2023-06-02 10:17:55 +02:00

strlen_on_c_strings.rs

…

suspicious_doc_comments.rs

…

suspicious_operation_groupings.rs

…

suspicious_trait_impl.rs

…

suspicious_xor_used_as_pow.rs

…

swap_ptr_to_ref.rs

…

swap.rs

…

tabs_in_doc_comments.rs

…

temporary_assignment.rs

…

tests_outside_test_module.rs

…

to_digit_is_some.rs

…

trailing_empty_array.rs

…

trait_bounds.rs

rename MSRV alias, add MSRV to lint doc

2023-06-22 17:19:43 +02:00

undocumented_unsafe_blocks.rs

allow safety comment above attributes

2023-06-19 23:46:57 -05:00

unicode.rs

…

uninit_vec.rs

…

unit_return_expecting_ord.rs

…

unnamed_address.rs

…

unnecessary_box_returns.rs

…

unnecessary_owned_empty_strings.rs

…

unnecessary_self_imports.rs

…

unnecessary_struct_initialization.rs

…

unnecessary_wraps.rs

Use Cow in {D,Subd}iagnosticMessage.

2023-05-29 09:23:43 +10:00

unnested_or_patterns.rs

…

unsafe_removed_from_name.rs

…

unused_async.rs

point to await expr in note

2023-05-23 17:22:23 +02:00

unused_io_amount.rs

…

unused_peekable.rs

…

unused_rounding.rs

…

unused_self.rs

…

unused_unit.rs

…

unwrap_in_result.rs

…

unwrap.rs

…

upper_case_acronyms.rs

…

use_self.rs

…

useless_conversion.rs

add plural form to useless_conversion if depth > 0

2023-06-03 19:38:55 +02:00

vec_init_then_push.rs

…

vec.rs

[useless_vec]: detect unnecessary vec![_]

2023-06-12 15:48:04 +02:00

wildcard_imports.rs

[wildcard_imports] Modules that contain prelude are also allowed

2023-05-30 21:29:04 +03:00

write.rs

…

zero_div_zero.rs

…

zero_sized_map_values.rs

…