bors 73be4863f0 Auto merge of #12459 - y21:unconditional_recursion_from_into, r=Jarcho ...

lint when calling the blanket `Into` impl from a `From` impl

Closes #11150
```
warning: function cannot return without recursing
  --> x.rs:9:9
   |
9  | /         fn from(value: f32) -> Self {
10 | |             value.into()
11 | |         }
   | |_________^
   |
note: recursive call site
  --> x.rs:10:13
   |
10 |             value.into()
   |             ^^^^^^^^^^^^
```

I'm also thinking that we can probably generalize this lint to #11032 at some point (instead of hardcoding a bunch of impls), like how rustc's `unconditional_recursion` works, at least up to one indirect call, but this still seems useful for now :)

I've also noticed that we use `fn_def_id` in a bunch of lints and then try to get the node args of the call in a separate step, so I made a helper function that does both in one. I intend to refactor a bunch of uses of `fn_def_id` to use this later

I can add more test cases, but this is already using much of the same logic that exists for the other impls that this lint looks for (e.g. making sure that there are no conditional returns).

changelog: [`unconditional_recursion`]: emit a warning inside of `From::from` when unconditionally calling the blanket `.into()` impl

2024-03-13 16:32:25 +00:00

..

attrs

Add new duplicated_attributes lint

2024-03-09 12:43:18 +01:00

cargo

Merge commit '60cb29c5e4f9772685c9873752196725c946a849' into clippyup

2024-02-08 20:24:42 +01:00

casts

[cast_lossless]: Suggest type alias instead of the aliased type

2024-03-12 10:16:27 -05:00

doc

fix [empty_docs] trigger in proc-macro

2024-03-12 10:40:40 +08:00

functions

Rename DiagnosticBuilder as Diag.

2024-02-28 08:55:35 +11:00

loops

fix: manual_memcpy wrong suggestion for multi dimensional arrays

2024-02-28 03:48:49 +09:00

matches

[single_match]: Fix duplicate diagnostics

2024-03-11 01:08:37 +08:00

methods

Auto merge of #12469 - pavedroad:master, r=y21

2024-03-12 10:00:15 +00:00

misc_early

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

operators

Auto merge of #12413 - high-cloud:fix_assign_ops2, r=flip1995

2024-03-05 14:34:56 +00:00

transmute

Pointers cannot be converted to integers at compile time

2024-03-03 23:55:01 +01:00

types

Merge remote-tracking branch 'upstream/master' into rustup

2024-03-07 17:14:36 +01:00

unit_types

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

utils

Rename DiagnosticBuilder as Diag.

2024-02-28 08:55:35 +11:00

absolute_paths.rs

hir: Remove fn opt_hir_id and fn opt_span

2024-02-07 09:38:24 +03:00

allow_attributes.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

almost_complete_range.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

approx_const.rs

Propegate HIR and AST f16 and f128 types to clippy

2024-03-01 13:59:06 -05:00

arc_with_non_send_sync.rs

Merge commit '66c29b973b3b10278bd39f4e26b08522a379c2c9' into clippy-subtree-update

2024-01-25 19:17:36 +01:00

as_conversions.rs

Merge commit 'a859e5cc1ce100df22346a1005da30532d04de59' into clippyup

2023-12-16 14:12:50 +01:00

asm_syntax.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

assertions_on_constants.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

assertions_on_result_states.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

assigning_clones.rs

Fix tests

2024-03-01 16:37:23 +01:00

async_yields_async.rs

Deal with additional wrapping of async closure body in clippy

2024-01-16 17:12:10 +00:00

await_holding_invalid.rs

Fix clippy's usage of Body's coroutine_kind

2023-12-25 21:13:41 +00:00

blocks_in_conditions.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

bool_assert_comparison.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

bool_to_int_with_if.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

booleans.rs

Remove double expr lint

2024-03-03 08:32:30 +01:00

borrow_deref_ref.rs

Merge commit 'a859e5cc1ce100df22346a1005da30532d04de59' into clippyup

2023-12-16 14:12:50 +01:00

box_default.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

checked_conversions.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

cognitive_complexity.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

collapsible_if.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

collection_is_never_read.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

comparison_chain.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

copies.rs

Bump indexmap

2024-02-13 21:03:34 +00:00

copy_iterator.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

crate_in_macro_def.rs

Add spacing information to delimiters.

2023-12-11 09:36:40 +11:00

create_dir.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

dbg_macro.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

declared_lints.rs

Auto merge of #12378 - GuillaumeGomez:duplicated_attr, r=blyxyas

2024-03-11 18:36:21 +00:00

default_constructed_unit_structs.rs

Merge commit 'ac4c2094a6030530661bee3876e0228ddfeb6b8b' into clippy-subtree-sync

2023-12-28 19:33:07 +01:00

default_instead_of_iter_empty.rs

Merge commit '66c29b973b3b10278bd39f4e26b08522a379c2c9' into clippy-subtree-update

2024-01-25 19:17:36 +01:00

default_numeric_fallback.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

default_union_representation.rs

Don't forget that the lifetime on hir types is 'tcx

2024-01-18 16:07:10 +00:00

default.rs

Use correct param env in clippy

2024-02-07 22:57:55 +00:00

deprecated_lints.rs

…

dereference.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

derivable_impls.rs

hir: Remove fn opt_hir_id and fn opt_span

2024-02-07 09:38:24 +03:00

derive.rs

fix [derive_partial_eq_without_eq] FP on trait projection

2024-03-02 00:37:35 +08:00

disallowed_macros.rs

Rename DiagnosticBuilder as Diag.

2024-02-28 08:55:35 +11:00

disallowed_methods.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

disallowed_names.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

disallowed_script_idents.rs

Rename all ParseSess variables/fields/lifetimes as psess.

2024-03-05 08:11:45 +11:00

disallowed_types.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

double_parens.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

drop_forget_ref.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

duplicate_mod.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

else_if_without_else.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

empty_drop.rs

hir: Remove fn opt_hir_id and fn opt_span

2024-02-07 09:38:24 +03:00

empty_enum.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

empty_with_brackets.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

endian_bytes.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

entry.rs

[map_entry]: Check insert expression for map use

2024-02-27 15:20:49 +01:00

enum_clike.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

equatable_if_let.rs

Add PatKind::Err

2024-01-17 03:14:16 +01:00

error_impl_error.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

escape.rs

Bump indexmap

2024-02-13 21:03:34 +00:00

eta_reduction.rs

Merge commit '60cb29c5e4f9772685c9873752196725c946a849' into clippyup

2024-02-08 20:24:42 +01:00

excessive_bools.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

excessive_nesting.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

exhaustive_items.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

exit.rs

Move some methods from tcx.hir() to tcx

2023-12-12 06:40:29 -08:00

explicit_write.rs

hir: Remove fn opt_hir_id and fn opt_span

2024-02-07 09:38:24 +03:00

extra_unused_type_parameters.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

fallible_impl_from.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

float_literal.rs

Propegate HIR and AST f16 and f128 types to clippy

2024-03-01 13:59:06 -05:00

floating_point_arithmetic.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

format_args.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

format_impl.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

format_push_string.rs

Merge commit 'ac4c2094a6030530661bee3876e0228ddfeb6b8b' into clippy-subtree-sync

2023-12-28 19:33:07 +01:00

format.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

formatting.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

four_forward_slashes.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

from_over_into.rs

Clippy: Fix empty suggestion in from_over_into

2024-01-26 09:42:12 +01:00

from_raw_with_void_ptr.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

from_str_radix_10.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

future_not_send.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

if_let_mutex.rs

Rename DiagnosticBuilder as Diag.

2024-02-28 08:55:35 +11:00

if_not_else.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

if_then_some_else_none.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

ignored_unit_patterns.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

impl_hash_with_borrow_str_and_bytes.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

implicit_hasher.rs

Rename DiagnosticBuilder as Diag.

2024-02-28 08:55:35 +11:00

implicit_return.rs

rustc_span: Optimize syntax context comparisons

2024-01-06 01:25:20 +03:00

implicit_saturating_add.rs

Pack the u128 in LitKind::Int

2024-01-19 20:10:39 -08:00

implicit_saturating_sub.rs

Pack the u128 in LitKind::Int

2024-01-19 20:10:39 -08:00

implied_bounds_in_impls.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

incompatible_msrv.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

inconsistent_struct_constructor.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

index_refutable_slice.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

indexing_slicing.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

ineffective_open_options.rs

Merge commit 'ac4c2094a6030530661bee3876e0228ddfeb6b8b' into clippy-subtree-sync

2023-12-28 19:33:07 +01:00

infinite_iter.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

inherent_impl.rs

Merge commit '66c29b973b3b10278bd39f4e26b08522a379c2c9' into clippy-subtree-update

2024-01-25 19:17:36 +01:00

inherent_to_string.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

init_numbered_fields.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

inline_fn_without_body.rs

Rename DiagnosticExt as DiagExt.

2024-03-05 12:14:49 +11:00

instant_subtraction.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

int_plus_one.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

invalid_upcast_comparisons.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

item_name_repetitions.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

items_after_statements.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

items_after_test_module.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

iter_not_returning_iterator.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

iter_over_hash_type.rs

Merge commit '60cb29c5e4f9772685c9873752196725c946a849' into clippyup

2024-02-08 20:24:42 +01:00

iter_without_into_iter.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

large_const_arrays.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

large_enum_variant.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

large_futures.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

large_include_file.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

large_stack_arrays.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

large_stack_frames.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

len_zero.rs

hir: Remove fn opt_hir_id and fn opt_span

2024-02-07 09:38:24 +03:00

let_if_seq.rs

use span_lint_hir instead of span_lint in more lints

2024-03-09 17:43:04 +01:00

let_underscore.rs

[let_underscore_untyped]: fix false positive on async function

2024-03-03 14:03:02 +01:00

let_with_type_underscore.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

lib.deprecated.rs

…

lib.rs

Rename into manual_unwrap_or_default

2024-03-10 01:23:28 +01:00

lifetimes.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

lines_filter_map_ok.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

literal_representation.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

macro_use.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

main_recursion.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

manual_assert.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

manual_async_fn.rs

Merge commit 'ac4c2094a6030530661bee3876e0228ddfeb6b8b' into clippy-subtree-sync

2023-12-28 19:33:07 +01:00

manual_bits.rs

Pack the u128 in LitKind::Int

2024-01-19 20:10:39 -08:00

manual_clamp.rs

Rename DiagnosticBuilder as Diag.

2024-02-28 08:55:35 +11:00

manual_float_methods.rs

Merge commit 'a859e5cc1ce100df22346a1005da30532d04de59' into clippyup

2023-12-16 14:12:50 +01:00

manual_hash_one.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

manual_is_ascii_check.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

manual_let_else.rs

Merge commit 'ac4c2094a6030530661bee3876e0228ddfeb6b8b' into clippy-subtree-sync

2023-12-28 19:33:07 +01:00

manual_main_separator_str.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

manual_non_exhaustive.rs

Give VariantData::Struct named fields, to clairfy recovered.

2023-12-20 00:07:34 +00:00

manual_range_patterns.rs

Pack the u128 in LitKind::Int

2024-01-19 20:10:39 -08:00

manual_rem_euclid.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

manual_retain.rs

Fix duplicate lint emission from [manual_retain]

2024-03-09 18:58:40 -06:00

manual_slice_size_calculation.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

manual_string_new.rs

Merge commit 'a859e5cc1ce100df22346a1005da30532d04de59' into clippyup

2023-12-16 14:12:50 +01:00

manual_strip.rs

Pack the u128 in LitKind::Int

2024-01-19 20:10:39 -08:00

manual_unwrap_or_default.rs

Rename into manual_unwrap_or_default

2024-03-10 01:23:28 +01:00

map_unit_fn.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

match_result_ok.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

mem_replace.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

min_ident_chars.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

minmax.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

misc.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

mismatching_type_param_order.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

missing_assert_message.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

missing_asserts_for_indexing.rs

Rename DiagnosticBuilder as Diag.

2024-02-28 08:55:35 +11:00

missing_const_for_fn.rs

Remove Session methods that duplicate DiagCtxt methods.

2023-12-24 08:05:28 +11:00

missing_doc.rs

support manually search for docs in case attr was removed by proc macros

2024-03-08 16:32:47 +08:00

missing_enforced_import_rename.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

missing_fields_in_debug.rs

Move some methods from tcx.hir() to tcx

2023-12-12 06:40:29 -08:00

missing_inline.rs

remove redundant imports

2023-12-10 10:56:22 +08:00

missing_trait_methods.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

mixed_read_write_in_expression.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

module_style.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

multi_assignments.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

multiple_bound_locations.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

multiple_unsafe_ops_per_block.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

mut_key.rs

Rustdoc and Clippy stop misusing Key for Ty -> (adt) DefId

2024-01-08 20:30:10 +00:00

mut_mut.rs

use span_lint_hir instead of span_lint in more lints

2024-03-09 17:43:04 +01:00

mut_reference.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

mutable_debug_assertion.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

mutex_atomic.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

needless_arbitrary_self_type.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

needless_bool.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

needless_borrowed_ref.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

needless_borrows_for_generic_args.rs

Merge commit 'a859e5cc1ce100df22346a1005da30532d04de59' into clippyup

2023-12-16 14:12:50 +01:00

needless_continue.rs

Plumb awaitness of for loops

2023-12-19 12:26:20 -08:00

needless_else.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

needless_for_each.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

needless_if.rs

Merge commit 'a859e5cc1ce100df22346a1005da30532d04de59' into clippyup

2023-12-16 14:12:50 +01:00

needless_late_init.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

needless_parens_on_range_literals.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

needless_pass_by_ref_mut.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

needless_pass_by_value.rs

Rename DiagnosticBuilder as Diag.

2024-02-28 08:55:35 +11:00

needless_question_mark.rs

Fix clippy's usage of Body's coroutine_kind

2023-12-25 21:13:41 +00:00

needless_update.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

neg_cmp_op_on_partial_ord.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

neg_multiply.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

new_without_default.rs

Rename DiagnosticExt as DiagExt.

2024-03-05 12:14:49 +11:00

no_effect.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

no_mangle_with_rust_abi.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

non_canonical_impls.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

non_copy_const.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

non_expressive_names.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

non_octal_unix_permissions.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

non_send_fields_in_send_ty.rs

Move some methods from tcx.hir() to tcx

2023-12-12 06:40:29 -08:00

nonstandard_macro_braces.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

octal_escapes.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

only_used_in_recursion.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

option_env_unwrap.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

option_if_let_else.rs

Merge commit 'ac4c2094a6030530661bee3876e0228ddfeb6b8b' into clippy-subtree-sync

2023-12-28 19:33:07 +01:00

overflow_check_conditional.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

panic_in_result_fn.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

panic_unimplemented.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

partial_pub_fields.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

partialeq_ne_impl.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

partialeq_to_none.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

pass_by_ref_or_value.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

pattern_type_mismatch.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

permissions_set_readonly_false.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

precedence.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

ptr_offset_with_cast.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

ptr.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

pub_underscore_fields.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

pub_use.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

question_mark_used.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

question_mark.rs

move methods out of impl and remove unused &self param

2024-02-28 00:53:25 +01:00

ranges.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

raw_strings.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

rc_clone_in_vec_init.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

read_zero_byte_vec.rs

use span_lint_hir instead of span_lint in more lints

2024-03-09 17:43:04 +01:00

redundant_async_block.rs

Merge commit 'ac4c2094a6030530661bee3876e0228ddfeb6b8b' into clippy-subtree-sync

2023-12-28 19:33:07 +01:00

redundant_clone.rs

compiler: Lower fn call arg spans down to MIR

2024-01-15 19:07:11 +01:00

redundant_closure_call.rs

use span_lint_hir instead of span_lint in more lints

2024-03-09 17:43:04 +01:00

redundant_else.rs

Plumb awaitness of for loops

2023-12-19 12:26:20 -08:00

redundant_field_names.rs

Don't lint redundant_field_names across macro boundaries

2024-03-07 12:21:16 +00:00

redundant_locals.rs

is_closure_like

2024-02-11 22:09:52 +00:00

redundant_pub_crate.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

redundant_slicing.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

redundant_static_lifetimes.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

redundant_type_annotations.rs

Add ErrorGuaranteed to ast::LitKind::Err, token::LitKind::Err.

2024-02-15 14:46:08 +11:00

ref_option_ref.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

ref_patterns.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

reference.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

regex.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

renamed_lints.rs

Merge commit 'a859e5cc1ce100df22346a1005da30532d04de59' into clippyup

2023-12-16 14:12:50 +01:00

repeat_vec_with_capacity.rs

Merge commit '60cb29c5e4f9772685c9873752196725c946a849' into clippyup

2024-02-08 20:24:42 +01:00

reserve_after_initialization.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

return_self_not_must_use.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

returns.rs

use span_lint_hir instead of span_lint in more lints

2024-03-09 17:43:04 +01:00

same_name_method.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

self_named_constructors.rs

hir: Remove fn opt_hir_id and fn opt_span

2024-02-07 09:38:24 +03:00

semicolon_block.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

semicolon_if_nothing_returned.rs

Merge commit '66c29b973b3b10278bd39f4e26b08522a379c2c9' into clippy-subtree-update

2024-01-25 19:17:36 +01:00

serde_api.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

shadow.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

significant_drop_tightening.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

single_call_fn.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

single_char_lifetime_names.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

single_component_path_imports.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

single_range_in_vec_init.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

size_of_in_element_count.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

size_of_ref.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

slow_vector_initialization.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

std_instead_of_core.rs

Fix #12438 false positive regression

2024-03-09 18:37:18 +01:00

strings.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

strlen_on_c_strings.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

suspicious_operation_groupings.rs

Plumb awaitness of for loops

2023-12-19 12:26:20 -08:00

suspicious_trait_impl.rs

Move some methods from tcx.hir() to tcx

2023-12-12 06:40:29 -08:00

suspicious_xor_used_as_pow.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

swap_ptr_to_ref.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

swap.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

tabs_in_doc_comments.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

temporary_assignment.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

tests_outside_test_module.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

thread_local_initializer_can_be_made_const.rs

Added msrv to threadlocal initializer

2024-03-03 15:43:09 +01:00

to_digit_is_some.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

to_string_trait_impl.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

trailing_empty_array.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

trait_bounds.rs

Merge commit '66c29b973b3b10278bd39f4e26b08522a379c2c9' into clippy-subtree-update

2024-01-25 19:17:36 +01:00

tuple_array_conversions.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

unconditional_recursion.rs

[unconditional_recursion]: catch From -> Into -> From

2024-03-13 17:22:54 +01:00

undocumented_unsafe_blocks.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

unicode.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

uninhabited_references.rs

Don't forget that the lifetime on hir types is 'tcx

2024-01-18 16:07:10 +00:00

uninit_vec.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

unit_return_expecting_ord.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

unnamed_address.rs

Drop clippy::vtable_address_comparisons

2023-12-06 09:03:48 +01:00

unnecessary_box_returns.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

unnecessary_map_on_constructor.rs

Merge commit 'a859e5cc1ce100df22346a1005da30532d04de59' into clippyup

2023-12-16 14:12:50 +01:00

unnecessary_owned_empty_strings.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

unnecessary_self_imports.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

unnecessary_struct_initialization.rs

Move some methods from tcx.hir() to tcx

2023-12-12 06:40:29 -08:00

unnecessary_wraps.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

unnested_or_patterns.rs

Add PatKind::Err

2024-01-17 03:14:16 +01:00

unsafe_removed_from_name.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

unused_async.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

unused_io_amount.rs

use span_lint_hir instead of span_lint in more lints

2024-03-09 17:43:04 +01:00

unused_peekable.rs

use span_lint_hir instead of span_lint in more lints

2024-03-09 17:43:04 +01:00

unused_rounding.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

unused_self.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

unused_unit.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

unwrap_in_result.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

unwrap.rs

hir: Remove hir::Map::{opt_parent_id,parent_id,get_parent,find_parent}

2024-02-10 12:24:46 +03:00

upper_case_acronyms.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

use_self.rs

Don't forget that the lifetime on hir types is 'tcx

2024-01-18 16:07:10 +00:00

useless_conversion.rs

Use correct param env in clippy

2024-02-07 22:57:55 +00:00

vec_init_then_push.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

vec.rs

Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update

2024-02-27 15:50:17 +01:00

visibility.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

wildcard_imports.rs

chore: fix some typos

2024-03-12 14:38:57 +08:00

write.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

zero_div_zero.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

zero_repeat_side_effects.rs

fix example code

2024-03-09 19:04:35 +00:00

zero_sized_map_values.rs

Don't forget that the lifetime on hir types is 'tcx

2024-01-18 16:07:10 +00:00