bors a1dfd2490a Auto merge of #77080 - richkadel:llvm-coverage-counters-2, r=tmandry ... Working branch-level code coverage Add a generalized implementation for computing branch-level coverage spans. This iteration resolves some of the challenges I had identified a few weeks ago. I've tried to implement a solution that is general enough to work for a lot of different graphs/patterns. It's encouraging to see the results on fairly large and complex crates seem to meet my expectations. This may be a "functionally complete" implementation. Except for bug fixes or edge cases I haven't run into yet, the next and essentially final step, I think, is to replace some Counters with CounterExpressions (where their counter values can be computed by adding or subtracting other counters/expressions). Examples of branch-level coverage support enabled in this PR: * https://github.com/richkadel/rust/blob/llvm-coverage-counters-2/src/test/run-make-fulldeps/instrument-coverage-cov-reports-base/expected_show_coverage.coverage_of_drop_trait.txt * https://github.com/richkadel/rust/blob/llvm-coverage-counters-2/src/test/run-make-fulldeps/instrument-coverage-cov-reports-base/expected_show_coverage.coverage_of_if.txt * https://github.com/richkadel/rust/blob/llvm-coverage-counters-2/src/test/run-make-fulldeps/instrument-coverage-cov-reports-base/expected_show_coverage.coverage_of_if_else.txt * https://github.com/richkadel/rust/blob/llvm-coverage-counters-2/src/test/run-make-fulldeps/instrument-coverage-cov-reports-base/expected_show_coverage.coverage_of_simple_loop.txt * https://github.com/richkadel/rust/blob/llvm-coverage-counters-2/src/test/run-make-fulldeps/instrument-coverage-cov-reports-base/expected_show_coverage.coverage_of_simple_match.txt * ... _and others in the same directory_ Examples of coverage analysis results (MIR spanview files) used to inject counters in the right `BasicBlocks`: * https://htmlpreview.github.io/?https://github.com/richkadel/rust/blob/llvm-coverage-counters-2/src/test/run-make-fulldeps/instrument-coverage-mir-cov-html-base/expected_mir_dump.coverage_of_drop_trait/coverage_of_drop_trait.main.-------.InstrumentCoverage.0.html * https://htmlpreview.github.io/?https://github.com/richkadel/rust/blob/llvm-coverage-counters-2/src/test/run-make-fulldeps/instrument-coverage-mir-cov-html-base/expected_mir_dump.coverage_of_if/coverage_of_if.main.-------.InstrumentCoverage.0.html * https://htmlpreview.github.io/?https://github.com/richkadel/rust/blob/llvm-coverage-counters-2/src/test/run-make-fulldeps/instrument-coverage-mir-cov-html-base/expected_mir_dump.coverage_of_if_else/coverage_of_if_else.main.-------.InstrumentCoverage.0.html * https://htmlpreview.github.io/?https://github.com/richkadel/rust/blob/llvm-coverage-counters-2/src/test/run-make-fulldeps/instrument-coverage-mir-cov-html-base/expected_mir_dump.coverage_of_simple_loop/coverage_of_simple_loop.main.-------.InstrumentCoverage.0.html * https://htmlpreview.github.io/?https://github.com/richkadel/rust/blob/llvm-coverage-counters-2/src/test/run-make-fulldeps/instrument-coverage-mir-cov-html-base/expected_mir_dump.coverage_of_simple_match/coverage_of_simple_match.main.-------.InstrumentCoverage.0.html * ... _and others in the same directory_ Here is some sample coverage output after compiling a few real-world crates with the new branch-level coverage features: <img width="801" alt="Screen Shot 2020-09-25 at 1 03 11 PM" src="https://user-images.githubusercontent.com/3827298/94316848-fd882c00-ff39-11ea-9cff-0402d3abd1e7.png"> <img width="721" alt="Screen Shot 2020-09-25 at 1 00 36 PM" src="https://user-images.githubusercontent.com/3827298/94316886-11cc2900-ff3a-11ea-9d03-80b26c8a5173.png"> <img width="889" alt="Screen Shot 2020-09-25 at 12 54 57 PM" src="https://user-images.githubusercontent.com/3827298/94316900-18f33700-ff3a-11ea-8a80-58f67d84b8de.png"> r? `@tmandry` FYI: `@wesleywiser`		2020-10-05 19:34:44 +00:00
..
base_n
binary_search_util
graph	Updates to experimental coverage counter injection	2020-10-05 08:02:58 -07:00
obligation_forest
owning_ref
sip128	Stable hashing: add comments and tests concerning platform-independence	2020-09-30 00:57:35 -07:00
small_c_str
snapshot_map
sorted_map
sso	SsoHashSet/Map - genericiy over Q removed	2020-10-02 20:13:23 -05:00
stable_hasher	Stable hashing: add comments and tests concerning platform-independence	2020-09-30 00:57:35 -07:00
tagged_ptr	Use T::BITS instead of size_of::<T> * 8.	2020-09-19 06:54:42 +02:00
tiny_list
transitive_relation
atomic_ref.rs
base_n.rs
box_region.rs
captures.rs
const_cstr.rs
fingerprint.rs	Avoid rehashing Fingerprint as a map key	2020-09-01 18:27:02 -07:00
flock.rs
frozen.rs
fx.rs
jobserver.rs	datastructures: replace lazy_static by SyncLazy from std	2020-09-01 22:06:47 +01:00
lib.rs	Auto merge of #77171 - VFLashM:better_sso_structures, r=oli-obk	2020-10-05 17:18:01 +00:00
macros.rs	Remove unused static_assert macro	2020-09-20 11:40:51 +02:00
map_in_place.rs
profiling.rs	Use as_secs_f64 in profiling.rs	2020-09-20 10:27:14 +02:00
ptr_key.rs
sharded.rs
sip128.rs	Stable hashing: add comments and tests concerning platform-independence	2020-09-30 00:57:35 -07:00
small_c_str.rs
sorted_map.rs	use array_windows instead of windows in the compiler	2020-09-20 08:11:05 +02:00
stable_hasher.rs	Stable hashing: add comments and tests concerning platform-independence	2020-09-30 00:57:35 -07:00
stable_map.rs
stable_set.rs
stack.rs
svh.rs
sync.rs
tagged_ptr.rs
temp_dir.rs	Capitalize safety comments	2020-09-08 22:37:18 -04:00
thin_vec.rs
tiny_list.rs
transitive_relation.rs
unhash.rs	Avoid rehashing Fingerprint as a map key	2020-09-01 18:27:02 -07:00
vec_linked_list.rs
work_queue.rs