480c4a18d5
Remove confusing 'while checking' note from opaque future type mismatches
Maybe I'm just misinterpreting the wording of the note. The only value I can see in this note is that it points out where the async's opaque future is coming from, but the way it's doing it is misleading IMO.
For example:
```rust
note: while checking the return type of the `async fn`
--> $DIR/dont-suggest-missing-await.rs:7:24
|
LL | async fn make_u32() -> u32 {
| ^^^ checked the `Output` of this `async fn`, found opaque type
```
We point at the type `u32` in the HIR, but then say "found opaque type". We also say "while checking"... but we're typechecking a totally different function when we get this type mismatch!
r? ``@estebank`` but feel free to reassign and/or take your time reviewing this. I'd be inclined to also discuss reworking the presentation of this type mismatch to restore some of these labels in a way that makes it more clear what it's trying to point out.
46 lines
2.3 KiB
Plaintext
46 lines
2.3 KiB
Plaintext
error[E0271]: expected `callback` to be a fn item that returns `Pin<Box<dyn Future<Output = ()>>>`, but it returns `impl Future<Output = ()>`
|
|
--> $DIR/issue-98634.rs:45:23
|
|
|
|
|
LL | StructAsync { callback }.await;
|
|
| ^^^^^^^^ expected `Pin<Box<dyn Future<Output = ()>>>`, found opaque type
|
|
|
|
|
= note: expected struct `Pin<Box<(dyn Future<Output = ()> + 'static)>>`
|
|
found opaque type `impl Future<Output = ()>`
|
|
note: required by a bound in `StructAsync`
|
|
--> $DIR/issue-98634.rs:9:35
|
|
|
|
|
LL | pub struct StructAsync<F: Fn() -> Pin<Box<dyn Future<Output = ()>>>> {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `StructAsync`
|
|
|
|
error[E0271]: expected `callback` to be a fn item that returns `Pin<Box<dyn Future<Output = ()>>>`, but it returns `impl Future<Output = ()>`
|
|
--> $DIR/issue-98634.rs:45:9
|
|
|
|
|
LL | StructAsync { callback }.await;
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^ expected `Pin<Box<dyn Future<Output = ()>>>`, found opaque type
|
|
|
|
|
= note: expected struct `Pin<Box<(dyn Future<Output = ()> + 'static)>>`
|
|
found opaque type `impl Future<Output = ()>`
|
|
note: required by a bound in `StructAsync`
|
|
--> $DIR/issue-98634.rs:9:35
|
|
|
|
|
LL | pub struct StructAsync<F: Fn() -> Pin<Box<dyn Future<Output = ()>>>> {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `StructAsync`
|
|
|
|
error[E0271]: expected `callback` to be a fn item that returns `Pin<Box<dyn Future<Output = ()>>>`, but it returns `impl Future<Output = ()>`
|
|
--> $DIR/issue-98634.rs:45:33
|
|
|
|
|
LL | StructAsync { callback }.await;
|
|
| ^^^^^^ expected `Pin<Box<dyn Future<Output = ()>>>`, found opaque type
|
|
|
|
|
= note: expected struct `Pin<Box<(dyn Future<Output = ()> + 'static)>>`
|
|
found opaque type `impl Future<Output = ()>`
|
|
note: required by a bound in `StructAsync`
|
|
--> $DIR/issue-98634.rs:9:35
|
|
|
|
|
LL | pub struct StructAsync<F: Fn() -> Pin<Box<dyn Future<Output = ()>>>> {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `StructAsync`
|
|
|
|
error: aborting due to 3 previous errors
|
|
|
|
For more information about this error, try `rustc --explain E0271`.
|